Implement From for Cell, RefCell and UnsafeCell #35392

Merged
merged 1 commit into from Aug 15, 2016

Conversation

Projects
None yet
6 participants
@malbarbo
Contributor

malbarbo commented Aug 5, 2016

Considering that From is implemented for Box, Rc and Arc, it seems reasonable to implement it for Cell, RefCell and UnsafeCell.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Aug 5, 2016

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Aug 5, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Aug 7, 2016

Member

Thanks for the PR! Looks good to me, and I'm tagging as T-libs to ensure the rest of @rust-lang/libs sees this as well

Member

alexcrichton commented Aug 7, 2016

Thanks for the PR! Looks good to me, and I'm tagging as T-libs to ensure the rest of @rust-lang/libs sees this as well

@alexcrichton alexcrichton added the T-libs label Aug 7, 2016

@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Aug 11, 2016

Contributor

Libs team said 'yup'. Thanks @malbarbo !

@bors r+

Contributor

brson commented Aug 11, 2016

Libs team said 'yup'. Thanks @malbarbo !

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Aug 11, 2016

Contributor

📌 Commit 1403df7 has been approved by brson

Contributor

bors commented Aug 11, 2016

📌 Commit 1403df7 has been approved by brson

@brson brson added the relnotes label Aug 11, 2016

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 13, 2016

Rollup merge of #35392 - malbarbo:cell-from, r=brson
Implement From for Cell, RefCell and UnsafeCell

Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.

bors added a commit that referenced this pull request Aug 13, 2016

Auto merge of #35639 - Manishearth:rollup, r=Manishearth
Rollup of 9 pull requests

- Successful merges: #35348, #35392, #35414, #35444, #35447, #35491, #35533, #35538, #35539
- Failed merges: #35409
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Aug 13, 2016

Contributor

⌛️ Testing commit 1403df7 with merge ea78bd9...

Contributor

bors commented Aug 13, 2016

⌛️ Testing commit 1403df7 with merge ea78bd9...

bors added a commit that referenced this pull request Aug 13, 2016

Auto merge of #35392 - malbarbo:cell-from, r=brson
Implement From for Cell, RefCell and UnsafeCell

Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Aug 13, 2016

Contributor

💔 Test failed - auto-linux-64-debug-opt

Contributor

bors commented Aug 13, 2016

💔 Test failed - auto-linux-64-debug-opt

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Aug 14, 2016

Member

@bors: retry

On Sat, Aug 13, 2016 at 8:33 AM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-debug-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-debug-opt/builds/3462


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35392 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Gk-CFg6S0f-gjsBwQpwu5s7tiAbks5qfePXgaJpZM4JeBVp
.

Member

alexcrichton commented Aug 14, 2016

@bors: retry

On Sat, Aug 13, 2016 at 8:33 AM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-debug-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-debug-opt/builds/3462


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35392 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Gk-CFg6S0f-gjsBwQpwu5s7tiAbks5qfePXgaJpZM4JeBVp
.

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb

eddyb Aug 14, 2016

Member

@bors rollup

Member

eddyb commented Aug 14, 2016

@bors rollup

eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016

Rollup merge of #35392 - malbarbo:cell-from, r=brson
Implement From for Cell, RefCell and UnsafeCell

Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.

@eddyb eddyb referenced this pull request Aug 14, 2016

Closed

Rollup of 33 pull requests #35665

eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016

Rollup merge of #35392 - malbarbo:cell-from, r=brson
Implement From for Cell, RefCell and UnsafeCell

Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.

@eddyb eddyb referenced this pull request Aug 14, 2016

Merged

Rollup of 30 pull requests #35666

bors added a commit that referenced this pull request Aug 14, 2016

@bors bors merged commit 1403df7 into rust-lang:master Aug 15, 2016

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment