Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From for Cell, RefCell and UnsafeCell #35392

Merged
merged 1 commit into from Aug 15, 2016

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
T-libs relnotes
Projects
None yet
Milestone
No milestone
6 participants
@malbarbo @rust-highfive @alexcrichton @brson @bors @eddyb
@malbarbo
Copy link
Contributor

malbarbo commented Aug 5, 2016 •
edited

Considering that From is implemented for Box, Rc and Arc, it seems reasonable to implement it for Cell, RefCell and UnsafeCell.

@rust-highfive rust-highfive assigned alexcrichton Aug 5, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Aug 5, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Aug 7, 2016

Thanks for the PR! Looks good to me, and I'm tagging as T-libs to ensure the rest of @rust-lang/libs sees this as well

@alexcrichton alexcrichton added the T-libs label Aug 7, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Aug 11, 2016

Libs team said 'yup'. Thanks @malbarbo !

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 11, 2016

📌 Commit 1403df7 has been approved by brson

@brson brson added the relnotes label Aug 11, 2016

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 13, 2016

@Manishearth
Rollup merge of rust-lang#35392 - malbarbo:cell-from, r=brson 
Implement From for Cell, RefCell and UnsafeCell

Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.
7e2fa43

@Manishearth Manishearth referenced this pull request Aug 13, 2016

Closed

Rollup of 9 pull requests #35639

bors added a commit that referenced this pull request Aug 13, 2016

@bors
Auto merge of #35639 - Manishearth:rollup, r=Manishearth 
Rollup of 9 pull requests

- Successful merges: #35348, #35392, #35414, #35444, #35447, #35491, #35533, #35538, #35539
- Failed merges: #35409
ebf4522
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 13, 2016

⌛️ Testing commit 1403df7 with merge ea78bd9...

bors added a commit that referenced this pull request Aug 13, 2016

@bors
Auto merge of #35392 - malbarbo:cell-from, r=brson 
Implement From for Cell, RefCell and UnsafeCell

Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.
ea78bd9
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 13, 2016

💔 Test failed - auto-linux-64-debug-opt
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Aug 14, 2016

@bors: retry

On Sat, Aug 13, 2016 at 8:33 AM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-debug-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-debug-opt/builds/3462

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35392 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95Gk-CFg6S0f-gjsBwQpwu5s7tiAbks5qfePXgaJpZM4JeBVp
.
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Aug 14, 2016

@bors rollup

eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016

@eddyb
Rollup merge of rust-lang#35392 - malbarbo:cell-from, r=brson 
Implement From for Cell, RefCell and UnsafeCell

Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.
36335a1

@eddyb eddyb referenced this pull request Aug 14, 2016

Closed

Rollup of 33 pull requests #35665

eddyb added a commit to eddyb/rust that referenced this pull request Aug 14, 2016

@eddyb
Rollup merge of rust-lang#35392 - malbarbo:cell-from, r=brson 
Implement From for Cell, RefCell and UnsafeCell

Considering that `From` is implemented for `Box`, `Rc` and `Arc`, it seems [reasonable](https://internals.rust-lang.org/t/implementing-from-t-for-other-std-types/3744) to implement it for `Cell`, `RefCell` and `UnsafeCell`.
fa57f35

@eddyb eddyb referenced this pull request Aug 14, 2016

Merged

Rollup of 30 pull requests #35666

bors added a commit that referenced this pull request Aug 14, 2016

@bors
Auto merge of #35666 - eddyb:rollup, r=eddyb 
Rollup of 30 pull requests

- Successful merges: #34941, #35392, #35444, #35447, #35491, #35533, #35539, #35558, #35573, #35574, #35577, #35586, #35588, #35594, #35596, #35597, #35598, #35606, #35611, #35615, #35616, #35620, #35622, #35640, #35643, #35644, #35646, #35647, #35648, #35661
- Failed merges: #35395, #35415
13ff307

@bors bors merged commit 1403df7 into rust-lang:master Aug 15, 2016
1 of 2 checks passed

1 of 2 checks passed

homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.