Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield Err in char::decode_utf8 per Unicode, like String::from_utf8_lossy #35947

Merged
merged 2 commits into from Aug 25, 2016

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@SimonSapin @rust-highfive @alexcrichton @bors
@SimonSapin
Copy link
Contributor

SimonSapin commented Aug 23, 2016

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton Aug 23, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Aug 23, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@SimonSapin SimonSapin referenced this pull request Aug 23, 2016

Closed

Tracking issue: UTF-8 decoder in libcore #33906

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Aug 23, 2016

@bors: r+

Thanks!
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 23, 2016

📌 Commit 46226a7 has been approved by alexcrichton

@Manishearth Manishearth referenced this pull request Aug 25, 2016

Merged

Rollup of 6 pull requests #35979

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 25, 2016

@Manishearth
Rollup merge of rust-lang#35947 - SimonSapin:decodeutf8-error-handlin… 
…g, r=alexcrichton

Yield Err in char::decode_utf8 per Unicode, like String::from_utf8_lossy

r? @alexcrichton
a929fb6

bors added a commit that referenced this pull request Aug 25, 2016

@bors
Auto merge of #35979 - Manishearth:rollup, r=Manishearth 
Rollup of 6 pull requests

- Successful merges: #35238, #35867, #35885, #35916, #35947, #35955
- Failed merges:
05fb797

Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 25, 2016

@Manishearth
Rollup merge of rust-lang#35947 - SimonSapin:decodeutf8-error-handlin… 
…g, r=alexcrichton

Yield Err in char::decode_utf8 per Unicode, like String::from_utf8_lossy

r? @alexcrichton
5deee46

bors added a commit that referenced this pull request Aug 25, 2016

@bors
Auto merge of #35979 - Manishearth:rollup, r=Manishearth 
Rollup of 6 pull requests

- Successful merges: #35238, #35867, #35885, #35916, #35947, #35955
- Failed merges:
17a2be8

@bors bors merged commit 46226a7 into rust-lang:master Aug 25, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SimonSapin SimonSapin deleted the SimonSapin:decodeutf8-error-handling branch Sep 15, 2016

@martinhath martinhath referenced this pull request Jan 12, 2017

Closed

std::path::Path::Display allocates internally #38879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.