adding a check to bootstrap script

[ducks]

and a check to the rust config script

refs #36207

first crack at making configure detect nodejs

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[alexcrichton]

Thanks for the PR! The nodejs logic in bootstrap.py though seems to never be called? I think this'll want to perhaps live in sanity.rs or close to that where we do the probing. A manually configured nodejs = "...", however, would override whatever we end up probing for.

[ducks]

Yeah, I didn't make it as far as actually make it do something yet.

I was reading through the bootstrap readme and was probably ask for some guidance but thanks for the advance advice. :)

[brson]

I don't have a solid grasp on how all the build system pieces work these days, but I expected this detection to happin in configure, whereafter bootstrap would read it from config.mk, and in turn pass it to compiletest.

[ducks]

Dang, ok. I was a bit off. I think I focused on /src/bootstrap too much and will look at configure more.

[ducks]

So I think I made a bit of progress. I am now detecting nodejs back in ./configure.
I then pass it through config.rs when it slurps up the config.mk. It seems to pass the sanity check that I added to sanity.rs because when running make, bootstrap compiles fine. I also did some println!ing and it was showing the correct node path.

I get a bit lost after this. Where to pass it next or how to add a test to compiletest for it or if I need to? Any advice on where to look next?

Thanks in advance! :)

[alexcrichton]

Here I think you'll want to do:

if let Some(ref s) = build.config.nodejs {
    need_cmd(s.as_ref());
}

[alexcrichton]

@bors: r+ 89bc13c

Thanks!

[bors]

⌛️ Testing commit 89bc13c with merge 48dd4f4...

[bors]

💔 Test failed - auto-win-msvc-64-cargotest

[alexcrichton]

@bors: retry

On Fri, Sep 9, 2016 at 12:40 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-cargotest
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/1773

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#36256 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95K5IZjAPqNDpaBJy1ff1gOa0YK6Tks5qobYngaJpZM4J0cs7
.

[bors]

⌛️ Testing commit 89bc13c with merge 1284081...

[bors]

💔 Test failed - auto-win-msvc-64-cargotest

[alexcrichton]

@bors: retry

On Fri, Sep 9, 2016 at 3:27 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-cargotest
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/1775

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#36256 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95EKETXVThkUTgYg6MZtlDKA3edhuks5qod1kgaJpZM4J0cs7
.

[bors]

⚡️ Previous build results for auto-linux-cross-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing 1284081 to master...