More refactoring to obey platform abstraction lint #36948

brson · Oct 4, 2016

The most interesting things here are moving std/sys/common to std/sys_common, and std/num/{f32,f64}.rs to std/{f32,f64}.rs, and adding more documentation to std/lib.rs.

r? @alexcrichton

brson · Oct 4, 2016

brson reviewed Oct 4, 2016

View changes

brson · Oct 4, 2016

src/libstd/sys_common/mod.rs

-            rtabort!(concat!("assertion failed: ", stringify!($e)))
-        }
-    })
-}


This macro is no longer used anywhere.

🎺 ⚰ 🎺

brson · Oct 4, 2016

A lot of this is just general cleanup...

alexcrichton · Oct 4, 2016

src/libstd/num/f64.rs → src/libstd/f64.rs

How dare you!

alexcrichton · Oct 4, 2016

alexcrichton reviewed Oct 4, 2016

View changes

alexcrichton · Oct 4, 2016

src/libstd/lib.rs

+
+// Turn warnings into errors, but only after stage0, where it can be useful for
+// code to emit warnings during language transitions
+#![cfg_attr(not(stage0), deny(warnings))]


If you're really ambitious, I've been meaning to remove all the cfg_attr here and just leave deny(warnings)

alexcrichton · Oct 4, 2016

alexcrichton reviewed Oct 4, 2016

View changes

alexcrichton · Oct 4, 2016

src/libstd/lib.rs

@@ -425,46 +403,62 @@ pub use core::u16;
 pub use core::u32;
 #[stable(feature = "rust1", since = "1.0.0")]
 pub use core::u64;
+#[stable(feature = "rust1", since = "1.0.0")]
+pub use alloc::boxed;


I think the ordering here affects the ordering in rustdoc, right? (just confirming you want to change that too)

It does not appear so to me. rustdoc seems to be alphabetizing everything.

alexcrichton · Oct 4, 2016

alexcrichton reviewed Oct 4, 2016

View changes

alexcrichton · Oct 4, 2016

src/libstd/macros.rs

@@ -184,6 +184,10 @@ macro_rules! assert_approx_eq {
    })
 }

+macro_rules! rtabort {


aww I was hoping we could keep this contained within the sys module

I'll see if I can put it there. I don't recall why I moved it, presumably just because it didn't work with my prefered module declaration order in lib.rs.

alexcrichton · Oct 4, 2016

alexcrichton reviewed Oct 4, 2016

View changes

alexcrichton · Oct 4, 2016

src/libstd/thread/local.rs

 #[doc(hidden)]
+#[cfg(not(target_thread_local))]


I think we'll want to always compile in this module. The theory behind this is that we compile the standard library with OS-based TLS (e.g. this module) but then consumers of the standard library can use the "fast TLS". The primary motivation here is OSX 10.6 and 10.7+, where 10.6 has slow TLS only but 10.7 has fast. We could in theory compile a 10.6 standard library but everyone else would have fast TLS.

alexcrichton · Oct 4, 2016

moving std/sys/common to std/sys_common

I kinda liked having everything contained in one nice "sys" directory, but I guess not enough to go against conventions of filesystem hierarchies and module structures.

brson · Oct 4, 2016

Updated to leave os-specific TLS key in with documentation for why, move rtabort back to sys_common.

alexcrichton · Oct 4, 2016

@bors: r+

bors · Oct 4, 2016

📌 Commit ae10558 has been approved by alexcrichton

bors · Oct 6, 2016

⌛️ Testing commit ae10558 with merge d3b75bb...

bors · Oct 6, 2016

💥 Test timed out

alexcrichton · Oct 6, 2016

@bors: retry

??

bors · Oct 6, 2016

☔️ The latest upstream changes (presumably #37002) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · Oct 10, 2016

@bors: retry

bors · Oct 13, 2016

🔒 Merge conflict

alexcrichton · Oct 31, 2016

ping @brson (for an update)

brson · Nov 1, 2016

@bors r+

bors · Nov 1, 2016

📌 Commit 6135cbc has been approved by brson

bors · Nov 2, 2016

⌛️ Testing commit 6135cbc with merge fc67cad...

bors · Nov 2, 2016

💔 Test failed - auto-win-gnu-64-opt

alexcrichton · Nov 2, 2016

@bors: retry

On Wednesday, November 2, 2016, bors notifications@github.com wrote:

💔 Test failed - auto-win-gnu-64-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/6005

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#36948 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95PUMAp0IYQNuNyPDU8pI9h-DwlSBks5q6IQPgaJpZM4KNL4c
.

bors · Nov 2, 2016

⌛️ Testing commit 6135cbc with merge 0ca9967...

bors · Nov 2, 2016

benaryorg · Mar 25, 2018

Sorry to dig up this rather old commit, but did this actually drop the distinction of Windows 8k buffers and Unix 64k buffers and made everything 8k?

@benaryorg commit 8128817 goes from 64k to 8k, that might be what you're thinking of. I'm not sure where the idea of a different value on Windows comes from, unless that was the behaviour even earlier when libuv was used.

The distinction came from Windows not handling the 64k buffers well, hence they choose to set it so something less on Windows.
But seeing it being set to 8k on both of 'em, this doesn't matter now anyway.
Thanks for your effort though.

rust-highfive assigned alexcrichton Oct 4, 2016

brson force-pushed the brson:sys branch from bc4c1d4 to ae10558 Oct 4, 2016

brson referenced this pull request Oct 17, 2016
Closed
Port libstd to "no operating system" target #37133

brson force-pushed the brson:sys branch from ae10558 to 6135cbc Nov 1, 2016

bors merged commit 6135cbc into rust-lang:master Nov 2, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

		#[doc(hidden)]
		#[cfg(not(target_thread_local))]

rust-lang/rust

Join GitHub today

More refactoring to obey platform abstraction lint #36948

Conversation

brson commented Oct 4, 2016

rust-highfive assigned alexcrichton Oct 4, 2016

brson reviewed Oct 4, 2016 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

brson commented Oct 4, 2016

This comment has been minimized.

alexcrichton commented Oct 4, 2016

alexcrichton reviewed Oct 4, 2016 View changes

This comment has been minimized.

alexcrichton reviewed Oct 4, 2016 View changes

This comment has been minimized.

This comment has been minimized.

alexcrichton reviewed Oct 4, 2016 View changes

This comment has been minimized.

This comment has been minimized.

alexcrichton reviewed Oct 4, 2016 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

alexcrichton commented Oct 4, 2016

brson force-pushed the brson:sys branch from bc4c1d4 to ae10558 Oct 4, 2016

This comment has been minimized.

brson commented Oct 4, 2016

This comment has been minimized.

alexcrichton commented Oct 4, 2016

This comment has been minimized.

bors commented Oct 4, 2016

This comment has been minimized.

bors commented Oct 6, 2016

bors added a commit that referenced this pull request Oct 6, 2016

This comment has been minimized.

bors commented Oct 6, 2016

This comment has been minimized.

alexcrichton commented Oct 6, 2016

This comment has been minimized.

bors commented Oct 6, 2016

This comment has been minimized.

alexcrichton commented Oct 10, 2016

This comment has been minimized.

bors commented Oct 13, 2016

brson referenced this pull request Oct 17, 2016

This comment has been minimized.

alexcrichton commented Oct 31, 2016

brson added some commits Sep 30, 2016

brson added some commits Oct 1, 2016

brson force-pushed the brson:sys branch from ae10558 to 6135cbc Nov 1, 2016

This comment has been minimized.

brson commented Nov 1, 2016

This comment has been minimized.

bors commented Nov 1, 2016

This comment has been minimized.

bors commented Nov 2, 2016

bors added a commit that referenced this pull request Nov 2, 2016

This comment has been minimized.

bors commented Nov 2, 2016

This comment has been minimized.

alexcrichton commented Nov 2, 2016

This comment has been minimized.

bors commented Nov 2, 2016

bors added a commit that referenced this pull request Nov 2, 2016

This comment has been minimized.

bors commented Nov 2, 2016

Hide details View details bors merged commit 6135cbc into rust-lang:master Nov 2, 2016 2 checks passed

2 checks passed

This comment has been minimized.

benaryorg commented on 6d54cd4 Mar 25, 2018

This comment has been minimized.

sourcejedi replied Apr 22, 2018

This comment has been minimized.

benaryorg replied Apr 23, 2018

brson reviewed Oct 4, 2016

View changes

alexcrichton reviewed Oct 4, 2016

View changes

alexcrichton reviewed Oct 4, 2016

View changes

alexcrichton reviewed Oct 4, 2016

View changes

alexcrichton reviewed Oct 4, 2016

View changes

brson force-pushed the brson:sys branch from `bc4c1d4` to `ae10558` Oct 4, 2016

brson force-pushed the brson:sys branch from `ae10558` to `6135cbc` Nov 1, 2016

bors merged commit `6135cbc` into rust-lang:master Nov 2, 2016
2 checks passed

benaryorg commented on `6d54cd4` Mar 25, 2018