Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize RFC 1560 #37127

Merged
merged 3 commits into from Nov 21, 2016

Conversation

Reviewers
No reviews
Assignees

@nrc nrc

Labels
relnotes
Projects
None yet
Milestone
No milestone
7 participants
@jseyfried @nrc @bors @nikomatsakis @bluss @alexcrichton @brson
@jseyfried
Copy link
Contributor

jseyfried commented Oct 12, 2016 •
edited

Fixes #13598, fixes #23157, fixes #32303.
cc #35120
r? @nrc

@rust-highfive rust-highfive assigned nrc Oct 12, 2016

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Oct 12, 2016

We don't want to land this until the end of the cycle, right?

@nikomatsakis or someone else, can you start a Crater run with this please?
@jseyfried

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jseyfried commented Oct 12, 2016

We don't want to land this until the end of the cycle, right?

Right -- I think the implementation is ready to be stabilized now but there's little harm in waiting.

@bluss bluss added relnotes S-waiting-on-crater labels Oct 12, 2016

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 13, 2016

☔️ The latest upstream changes (presumably #37118) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried jseyfried force-pushed the jseyfried:stabilize_RFC_1560 branch 3 times, most recently from f8bba59 to dab9dd4 Oct 13, 2016

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Oct 17, 2016

Started crater run from commit d34318d to dab9dd4. Sorry for delay.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 19, 2016

☔️ The latest upstream changes (presumably #37269) made this pull request unmergeable. Please resolve the merge conflicts.

@bluss bluss removed the S-waiting-on-crater label Oct 19, 2016

@nikomatsakis
@bluss

This comment has been minimized.

Sign in to view
Copy link
Contributor

bluss commented Oct 24, 2016 •
edited

  • borealis → unlucky timing and got a now-yanked version of its dep html5ever, causing the error. So it's not a regression.
  • climatempo → same as borealis

The rest are timeouts. No regressions!

@jseyfried jseyfried force-pushed the jseyfried:stabilize_RFC_1560 branch from dab9dd4 to 98efd9c Oct 25, 2016

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 27, 2016

☔️ The latest upstream changes (presumably #36695) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov petrochenkov referenced this pull request Oct 27, 2016

Closed

Wildcard imports from `super` omit non-public constants and statics. #37434

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Nov 10, 2016

The cycle ended recently, and with no regressions on crater, is this good to go? @jseyfried want to rebase and @nrc want to r+?

@jseyfried jseyfried force-pushed the jseyfried:stabilize_RFC_1560 branch 2 times, most recently from de42e12 to 2459bd2 Nov 10, 2016

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Nov 11, 2016

r = me

@jseyfried jseyfried force-pushed the jseyfried:stabilize_RFC_1560 branch from 2459bd2 to 9785ec9 Nov 11, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Nov 11, 2016

@bors r=nrc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Nov 11, 2016

📌 Commit 9785ec9 has been approved by nrc

@jseyfried jseyfried force-pushed the jseyfried:stabilize_RFC_1560 branch 2 times, most recently from e2365df to 76b9fdf Nov 11, 2016

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Nov 17, 2016

☔️ The latest upstream changes (presumably #37732) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried jseyfried force-pushed the jseyfried:stabilize_RFC_1560 branch from 76b9fdf to 649bcd4 Nov 21, 2016

@jseyfried

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jseyfried commented Nov 21, 2016

@bors r=nrc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Nov 21, 2016

📌 Commit 649bcd4 has been approved by nrc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Nov 21, 2016

⌛️ Testing commit 649bcd4 with merge 59b87b3...

bors added a commit that referenced this pull request Nov 21, 2016

@bors
Auto merge of #37127 - jseyfried:stabilize_RFC_1560, r=nrc 
Stabilize RFC 1560

Fixes #13598, fixes #23157, fixes #32303.
cc #35120
r? @nrc
Loading status checks…
59b87b3
@bors

@bors bors merged commit 649bcd4 into rust-lang:master Nov 21, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Test successful
Details

@bors bors referenced this pull request Nov 21, 2016

Merged

Update the bootstrap compiler #37800

@jseyfried jseyfried referenced this pull request Nov 26, 2016

Closed

"A non-empty glob must import something with the glob's visibility" regression from stable/beta to nightly? #37995

@jseyfried jseyfried referenced this pull request Dec 6, 2016

Closed

`use super::*` importing private members from parent module #38176

@jseyfried jseyfried deleted the jseyfried:stabilize_RFC_1560 branch Dec 8, 2016

This was referenced Dec 26, 2016

Closed
Closed

@jseyfried jseyfried referenced this pull request Jan 21, 2017

Closed

Rust beta/nightly has a false positive #[warn(unused_imports)] that's not in stable #39225

@rpjohnst rpjohnst referenced this pull request Sep 7, 2017

Merged

RFC: Clarify and streamline paths and visibility #2126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.