Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptidy/features: fix checking of lang features #37196
Conversation
rust-highfive
assigned
brson
Oct 15, 2016
ollie27
reviewed
Oct 15, 2016
| @@ -286,7 +286,6 @@ pub mod builtin { | |||
| /// // fn concat_idents!(new, fun, name) { } // not usable in this way! | |||
| /// # } | |||
| /// ``` | |||
| #[unstable(feature = "concat_idents", issue = "29599")] | |||
This comment has been minimized.
This comment has been minimized.
ollie27
Oct 15, 2016
Contributor
This was added in #34404 so the macro is marked unstable in the docs. If the feature name is conflicting then it should just be renamed here.
This comment has been minimized.
This comment has been minimized.
tamird
force-pushed the
tamird:fix-tidy-features
branch
from
59e9f57
to
5f1aa61
Oct 15, 2016
This comment has been minimized.
This comment has been minimized.
|
@brson ping? |
This comment has been minimized.
This comment has been minimized.
|
@tamird Hi! Sorry for not seeing this earlier. This looks great. Do you mind adding an assert that some lang features are found, so that this doesn't regress again in the future? |
tamird
added some commits
Oct 14, 2016
tamird
force-pushed the
tamird:fix-tidy-features
branch
from
5f1aa61
to
bef1911
Oct 28, 2016
This comment has been minimized.
This comment has been minimized.
|
Yep! Done. |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Oct 28, 2016
This comment has been minimized.
This comment has been minimized.
bors
merged commit bef1911
into
rust-lang:master
Oct 28, 2016
tamird
deleted the
tamird:fix-tidy-features
branch
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tamird commentedOct 15, 2016
•
edited
r? @brson
See the commit messages - the actual "fixes" here are strawmen; I'm happy to adjust them if you have suggestions.