Disable jemalloc on aarch64/powerpc #37392

alexcrichton · Oct 25, 2016

Sounds like jemalloc is broken on systems which differ in page size than the
host it was compiled on (unless an option was passed). This unfortunately
reduces the portability of binaries created and can often make Rust segfault by
default. For now let's patch over this by disabling jemalloc until we can figure
out a better solution.

Closes #36994
Closes #37320
cc jemalloc/jemalloc#467

rust-highfive · Oct 25, 2016

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · Oct 25, 2016

r? @brson

xen0n · Oct 25, 2016

Multiple page sizes are also present on MIPS, both the 32- and 64-bit variants. Would be a good idea to include those too. :-)

alexcrichton · Oct 25, 2016

@xen0n ah, sounds good to protect against as well! I've disabled it there as well.

cuviper · Oct 26, 2016

cuviper reviewed Oct 26, 2016

View changes

cuviper · Oct 26, 2016

src/librustc_back/target/mips64_unknown_linux_gnuabi64.rs

@@ -25,6 +25,10 @@ pub fn target() -> TargetResult {
            cpu: "mips64r2".to_string(),
            features: "+mips64r2".to_string(),
            max_atomic_width: Some(64),
+
+            // see #36994
+            exe_allocation_crate: "alloc_system".to_string();


Travis failed because all these MIPS additions should end in commas, not semicolons.

brson · Oct 27, 2016

@bors r+

bors · Oct 27, 2016

📌 Commit de80670 has been approved by brson

sfackler · Oct 27, 2016

omg jemalloc

bors · Oct 29, 2016

⌛️ Testing commit de80670 with merge 62bdf88...

bors · Oct 30, 2016

💔 Test failed - auto-linux-64-opt

alexcrichton · Oct 30, 2016

@bors: retry

On Sat, Oct 29, 2016 at 8:28 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/10825

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#37392 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95PIffOMf5PiEF3ArjsytuI7F0F2gks5q4-SZgaJpZM4Kff3U
.

bors · Oct 30, 2016

⌛️ Testing commit de80670 with merge aef5ca5...

bors · Oct 30, 2016

rust-highfive assigned pnkfelix Oct 25, 2016

rust-highfive assigned brson and unassigned pnkfelix Oct 25, 2016

This was referenced Oct 25, 2016

Closed

Segfault running aarch64-unknown-linux-gnu binaries on Fedora #36994

Closed

segfault on ppc64le when compiling master using nightly-2016-10-19 #37320

alexcrichton force-pushed the alexcrichton:more-disable-jemalloc branch from c0ca239 to 0f6fde2 Oct 25, 2016

alexcrichton force-pushed the alexcrichton:more-disable-jemalloc branch from 0f6fde2 to de80670 Oct 27, 2016

bors merged commit de80670 into rust-lang:master Oct 30, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

bluss added the relnotes label Oct 30, 2016

alexcrichton deleted the alexcrichton:more-disable-jemalloc branch Nov 6, 2016

infinity0 referenced this pull request Dec 28, 2016
Closed
1.14.0 tests fail (1 run-pass, 1 compile-fail) on arm64 #38612

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

Disable jemalloc tests on platforms where it is disabled (closes rust…
…-lang#38612) See also rust-lang#37392

6a683e9

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

Disable jemalloc tests on platforms where it is disabled (closes rust…
…-lang#38612) See also rust-lang#37392

986bc0f

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

Disable jemalloc on s390x as well (closes rust-lang#38596)
See also rust-lang#37320 and rust-lang#37392

60a1c21

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

Disable jemalloc tests on platforms where it is disabled (closes rust…
…-lang#38612) See also rust-lang#37392

6aa7710

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

Disable jemalloc on s390x as well (closes rust-lang#38596)
See also rust-lang#37320 and rust-lang#37392

b5a8a8a

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

Disable jemalloc tests on platforms where it is disabled (closes rust…
…-lang#38612) See also rust-lang#37392

6ffa107

infinity0 added a commit to infinity0/rust that referenced this pull request Jan 12, 2017

Disable jemalloc on s390x as well (closes rust-lang#38596)
See also rust-lang#37320 and rust-lang#37392

417953f

infinity0 added a commit to infinity0/rust that referenced this pull request Jan 12, 2017

Disable jemalloc tests on platforms where it is disabled (closes rust…
…-lang#38612) See also rust-lang#37392

cadebc7

rust-lang/rust

Join GitHub today

Disable jemalloc on aarch64/powerpc #37392

Conversation

alexcrichton commented Oct 25, 2016

rust-highfive assigned pnkfelix Oct 25, 2016

This comment has been minimized.

rust-highfive commented Oct 25, 2016

This comment has been minimized.

alexcrichton commented Oct 25, 2016

rust-highfive assigned brson and unassigned pnkfelix Oct 25, 2016

This was referenced Oct 25, 2016

Segfault running aarch64-unknown-linux-gnu binaries on Fedora #36994

segfault on ppc64le when compiling master using nightly-2016-10-19 #37320

This comment has been minimized.

xen0n commented Oct 25, 2016

alexcrichton force-pushed the alexcrichton:more-disable-jemalloc branch from c0ca239 to 0f6fde2 Oct 25, 2016

This comment has been minimized.

alexcrichton commented Oct 25, 2016

cuviper reviewed Oct 26, 2016 View changes

This comment has been minimized.

cuviper Oct 26, 2016

alexcrichton force-pushed the alexcrichton:more-disable-jemalloc branch from 0f6fde2 to de80670 Oct 27, 2016

This comment has been minimized.

brson commented Oct 27, 2016

This comment has been minimized.

bors commented Oct 27, 2016

This comment has been minimized.

sfackler commented Oct 27, 2016

This comment has been minimized.

bors commented Oct 29, 2016

bors added a commit that referenced this pull request Oct 29, 2016

This comment has been minimized.

bors commented Oct 30, 2016

This comment has been minimized.

alexcrichton commented Oct 30, 2016

This comment has been minimized.

bors commented Oct 30, 2016

bors added a commit that referenced this pull request Oct 30, 2016

This comment has been minimized.

bors commented Oct 30, 2016

Hide details View details bors merged commit de80670 into rust-lang:master Oct 30, 2016 2 checks passed

2 checks passed

bluss added the relnotes label Oct 30, 2016

alexcrichton deleted the alexcrichton:more-disable-jemalloc branch Nov 6, 2016

infinity0 referenced this pull request Dec 28, 2016

1.14.0 tests fail (1 run-pass, 1 compile-fail) on arm64 #38612

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

infinity0 added a commit to infinity0/rust that referenced this pull request Dec 29, 2016

infinity0 added a commit to infinity0/rust that referenced this pull request Jan 12, 2017

infinity0 added a commit to infinity0/rust that referenced this pull request Jan 12, 2017

alexcrichton force-pushed the alexcrichton:more-disable-jemalloc branch from `c0ca239` to `0f6fde2` Oct 25, 2016

cuviper reviewed Oct 26, 2016

View changes

alexcrichton force-pushed the alexcrichton:more-disable-jemalloc branch from `0f6fde2` to `de80670` Oct 27, 2016

bors merged commit `de80670` into rust-lang:master Oct 30, 2016
2 checks passed