Redox Support Preview #37702

jackpot51 · Nov 11, 2016

Important - This is only a preview of a working `sys::redox`.

Compiling the Redox default distribution with this libstd results in a fully functioning distribution. As such, all further changes would be cosmetic or implementing features that have not been used by the default distribution (of which there are only a small number).

I do not expect this to be merged, but would like to discuss how it may be improved and get feedback.

There are a few unimplemented!() - cloexec for example. I have documented them below. These would be resolved before desiring a merge.

There are also issues with how the Redox syscall library is called - currently I am using a re-export in libc but that probably would not be desired.

rust-highfive · Nov 11, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jackpot51 · Nov 11, 2016

@alexcrichton @brson @eddyb I am mentioning you here because you have expressed interest in a Redox libstd port

Previous discussion here: https://internals.rust-lang.org/t/redox-support-in-liblibc-and-libstd/3954/17

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libstd/sys_common/mod.rs

@@ -34,7 +34,6 @@ pub mod condvar;
 pub mod io;
 pub mod memchr;
 pub mod mutex;
-pub mod net;


Because Redox does networking using files, and does not support the traditional Berkeley Socket API, we must specify an alternative net module, which is defined in sys::redox::net and imported down below

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libstd/sys/redox/condvar.rs

+    #[inline]
+    pub fn wait_timeout(&self, _mutex: &Mutex, _dur: Duration) -> bool {
+        ::sys_common::util::dumb_print(format_args!("condvar wait_timeout\n"));
+        unimplemented!();


This will be implemented shortly with additional flags to futex

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libstd/sys/redox/fd.rs

+
+    pub fn set_cloexec(&self) -> io::Result<()> {
+        ::sys_common::util::dumb_print(format_args!("{}: set cloexec\n", self.fd));
+        unimplemented!();


This will be implemented shortly with an fcntl call

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libstd/sys/redox/fd.rs

+
+    pub fn set_nonblocking(&self, _nonblocking: bool) -> io::Result<()> {
+        ::sys_common::util::dumb_print(format_args!("{}: set nonblocking\n", self.fd));
+        unimplemented!();


This will be implemented shortly with an fcntl call

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libstd/sys/redox/fs.rs

+
+pub fn rename(_old: &Path, _new: &Path) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("Rename\n"));
+    unimplemented!();


This will require a rename syscall

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libstd/sys/redox/fs.rs

+
+pub fn set_perm(_p: &Path, _perm: FilePermissions) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("Set perm\n"));
+    unimplemented!();


This will require a chmod syscall

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libstd/sys/redox/fs.rs

+
+pub fn symlink(_src: &Path, _dst: &Path) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("Symlink\n"));
+    unimplemented!();


Symlinks are not supported on Redox at the moment

In that case Err of some sort indicating that the operation is not supported should be returned (just like other OSes do when underlying filesystem does not support the operation).

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libstd/sys/redox/fs.rs

+
+pub fn link(_src: &Path, _dst: &Path) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("Link\n"));
+    unimplemented!();


Hard links are not supported on Redox at the moment

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libstd/sys/redox/pipe.rs

+             _p2: AnonPipe,
+             _v2: &mut Vec<u8>) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("read2\n"));
+    unimplemented!();


Due to using set_nonblocking, which is not supported until fcntl is added, this is not implemented yet

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libpanic_abort/lib.rs

@@ -28,7 +28,7 @@
 #![panic_runtime]
 #![feature(panic_runtime)]
 #![cfg_attr(unix, feature(libc))]
-#![cfg_attr(windows, feature(core_intrinsics))]
+#![cfg_attr(any(target_os = "redox", windows), feature(core_intrinsics))]


Redox has no libc function for abort, so using the intrinsic is required

jackpot51 · Nov 11, 2016

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 · Nov 11, 2016

src/libpanic_unwind/lib.rs

@@ -69,6 +69,7 @@ mod imp;

 // i686-pc-windows-gnu and all others
 #[cfg(any(all(unix, not(target_os = "emscripten")),
+          target_os = "redox",


Redox could potentially use libunwind for backtraces. Right now, panic_abort is preferred.

jackpot51 · Dec 2, 2016

@alexcrichton Take, for instance, terminal auto completion. With Prefix the way it is in this patch, the autocompleter can correctly fill in paths that start with / like /bin/cat, relative paths like cat, as well as scheme-absolute paths like file:/bin/cat.

Without this patch, filling in file:/bin/cat will look for a folder named file: in the current directory.

Since scheme-absolute paths are not often used in this manner, I would be ok with putting off the decision until later - but it will introduce potential problems in some applications

alexcrichton · Dec 2, 2016

Well, I suppose it was just an idea. If it's require to have a custom prefix for redox, I don't know how to solve that problem in a good way.

brson · Dec 12, 2016

I think we're at an impasse for now on the prefix issue. Can we just remove prefixes from this patch to get the bulk of the work landed and circle back to the tough design question?

I'll go post a thread to irlo about expanding Prefix to raise awareness and see if anybody has bright ideas.

jackpot51 · Dec 12, 2016

@brson Sure

jackpot51 · Dec 12, 2016

@brson @alexcrichton The prefix handling has been removed. This must be readded in the future to avoid leaving in a potential security problem, but I would like to see a merge of Redox support before then as you have described.

brson · Dec 12, 2016

@bors r+

Thanks for your enduring patience.

bors · Dec 12, 2016

📌 Commit c61baa0 has been approved by brson

jackpot51 · Dec 12, 2016

Thanks @brson. I am going to work on adding the x86_64-unknown-redox target to rustc now.

jackpot51 · Dec 14, 2016

@brson, this job failed due to an issue fixed by #38340.

brson · Dec 14, 2016

@bors r+

bors · Dec 14, 2016

📌 Commit 3e15dc1 has been approved by brson

eddyb · Dec 15, 2016

@bors r=brson

bors · Dec 15, 2016

📌 Commit 3e15dc1 has been approved by brson

jackpot51 · Dec 15, 2016

thanks @eddyb

bors · Dec 15, 2016

⌛️ Testing commit 3e15dc1 with merge cfa668f...

bors · Dec 15, 2016

ticki · Dec 15, 2016

woohoo!

RalfJung · Aug 6, 2018

@jackpot51
I am looking at Mutex::init here right now and wondering why it is not a NOP. Seems like The Redox Mutex is completely safe to use after just doing Mutex::new. Why does init write a 0?

You are probably right, it could be a noop... so long as a mutex is never recycled

I don't think recycling is legal. POSIX docs say you must not initialize an already initialized mutex.

Sounds like it could be a no-op then

rust-highfive assigned aturon Nov 11, 2016

Rollback prefix

Loading status checks…

056ebcc

Fix accidental removal of import

Loading status checks…

c61baa0

jackpot51 added some commits Dec 12, 2016

Merge branch 'master' into redox

Loading status checks…

7e7775c

Fix tidy checks

Loading status checks…

daaa231

Merge branch 'master' into redox

Loading status checks…

3e15dc1

jackpot51 referenced this pull request Dec 14, 2016
Closed
Redox x86_64 target support #38366

jackpot51 force-pushed the redox-os:redox branch from cf87de9 to 3e15dc1 Dec 15, 2016

bors merged commit 3e15dc1 into rust-lang:master Dec 15, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

jackpot51 deleted the redox-os:redox branch Dec 15, 2016

ids1024 referenced this pull request Aug 18, 2017
Merged
Redox: correct is_absolute() and has_root() #43983

rust-lang/rust

Join GitHub today

Redox Support Preview #37702

Conversation

jackpot51 commented Nov 11, 2016 • edited

Important - This is only a preview of a working sys::redox.

jackpot51 added some commits Oct 28, 2016

rust-highfive assigned aturon Nov 11, 2016

This comment has been minimized.

rust-highfive commented Nov 11, 2016

This comment has been minimized.

jackpot51 commented Nov 11, 2016

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

jackpot51 Nov 11, 2016 • edited

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

This comment has been minimized.

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

jackpot51 Nov 11, 2016 • edited

jackpot51 reviewed Nov 11, 2016 View changes

This comment has been minimized.

This comment has been minimized.

jackpot51 commented Dec 2, 2016 • edited

This comment has been minimized.

alexcrichton commented Dec 2, 2016

This comment has been minimized.

brson commented Dec 12, 2016

This comment has been minimized.

jackpot51 commented Dec 12, 2016

This comment has been minimized.

jackpot51 commented Dec 12, 2016

This comment has been minimized.

brson commented Dec 12, 2016

This comment has been minimized.

bors commented Dec 12, 2016

This comment has been minimized.

jackpot51 commented Dec 12, 2016

jackpot51 added some commits Dec 12, 2016

This comment has been minimized.

jackpot51 commented Dec 14, 2016 • edited

This comment has been minimized.

brson commented Dec 14, 2016

This comment has been minimized.

bors commented Dec 14, 2016

jackpot51 referenced this pull request Dec 14, 2016

jackpot51 force-pushed the redox-os:redox branch from cf87de9 to 3e15dc1 Dec 15, 2016

This comment has been minimized.

eddyb commented Dec 15, 2016

This comment has been minimized.

bors commented Dec 15, 2016

This comment has been minimized.

jackpot51 commented Dec 15, 2016

This comment has been minimized.

bors commented Dec 15, 2016

bors added a commit that referenced this pull request Dec 15, 2016

This comment has been minimized.

bors commented Dec 15, 2016

Hide details View details bors merged commit 3e15dc1 into rust-lang:master Dec 15, 2016 2 checks passed

2 checks passed

This comment has been minimized.

ticki commented Dec 15, 2016

jackpot51 deleted the redox-os:redox branch Dec 15, 2016

ids1024 referenced this pull request Aug 18, 2017

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Aug 23, 2017

jackpot51 commented Nov 11, 2016 •

edited

Important - This is only a preview of a working `sys::redox`.

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 Nov 11, 2016 •

edited

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 Nov 11, 2016 •

edited

jackpot51 reviewed Nov 11, 2016

View changes

jackpot51 commented Dec 2, 2016 •

edited

jackpot51 commented Dec 14, 2016 •

edited

jackpot51 force-pushed the redox-os:redox branch from `cf87de9` to `3e15dc1` Dec 15, 2016

bors merged commit `3e15dc1` into rust-lang:master Dec 15, 2016
2 checks passed

RalfJung commented on `b1b35dd` Aug 6, 2018