Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn unused type aliases, reimplemented #38051

Merged
merged 4 commits into from Dec 19, 2016
Merged

Conversation

@sanxiyn
Copy link
Member

sanxiyn commented Nov 28, 2016

Reimplementation of #37631. Fix #37455.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Nov 28, 2016

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb

This comment has been minimized.

Copy link
Member

eddyb commented Nov 28, 2016

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 28, 2016

📌 Commit 6f979b5 has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 29, 2016

☔️ The latest upstream changes (presumably #37918) made this pull request unmergeable. Please resolve the merge conflicts.

@sanxiyn sanxiyn force-pushed the sanxiyn:unused-type-alias-3 branch from 6f979b5 to 72a4f4b Nov 30, 2016
@sanxiyn sanxiyn force-pushed the sanxiyn:unused-type-alias-3 branch from 72a4f4b to cfa55ff Dec 8, 2016
@sanxiyn

This comment has been minimized.

Copy link
Member Author

sanxiyn commented Dec 8, 2016

@bors r=eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 8, 2016

📌 Commit cfa55ff has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 8, 2016

⌛️ Testing commit cfa55ff with merge d07335c...

bors added a commit that referenced this pull request Dec 8, 2016
 Warn unused type aliases, reimplemented

Reimplementation of #37631. Fix #37455.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 8, 2016

💔 Test failed - auto-win-msvc-32-opt

sanxiyn added 2 commits Nov 28, 2016
This code was introduced in #27565 to mark types in paths alive. It is now unnecessary since #37676.
@sanxiyn sanxiyn force-pushed the sanxiyn:unused-type-alias-3 branch from cfa55ff to b714a7b Dec 15, 2016
@sanxiyn

This comment has been minimized.

Copy link
Member Author

sanxiyn commented Dec 15, 2016

@bors r=eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 15, 2016

📌 Commit b714a7b has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 15, 2016

⌛️ Testing commit b714a7b with merge d9c973e...

bors added a commit that referenced this pull request Dec 15, 2016
 Warn unused type aliases, reimplemented

Reimplementation of #37631. Fix #37455.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 15, 2016

💔 Test failed - auto-win-msvc-32-opt

@sanxiyn sanxiyn force-pushed the sanxiyn:unused-type-alias-3 branch from b714a7b to c6eba2b Dec 15, 2016
@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Dec 15, 2016

@bors r=eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 15, 2016

📌 Commit c6eba2b has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 16, 2016

⌛️ Testing commit c6eba2b with merge ac5b251...

bors added a commit that referenced this pull request Dec 16, 2016
 Warn unused type aliases, reimplemented

Reimplementation of #37631. Fix #37455.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 16, 2016

💔 Test failed - auto-win-msvc-32-opt

@arielb1

This comment has been minimized.

Copy link
Contributor

arielb1 commented Dec 16, 2016

error: unused import: `c_void`
  --> C:\bot\slave\auto-win-msvc-32-opt\build\src\librustc_trans\back\msvc\registry.rs:15:12
   |
15 | use libc::{c_void, c_long};
   |            ^^^^^^
   |
note: lint level defined here
  --> C:\bot\slave\auto-win-msvc-32-opt\build\src\librustc_trans\lib.rs:24:31
   |
24 | #![cfg_attr(not(stage0), deny(warnings))]
   |                               ^^^^^^^^
@sanxiyn sanxiyn force-pushed the sanxiyn:unused-type-alias-3 branch from c6eba2b to 7ab8c75 Dec 17, 2016
@sanxiyn

This comment has been minimized.

Copy link
Member Author

sanxiyn commented Dec 17, 2016

@bors r=eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 17, 2016

📌 Commit 7ab8c75 has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 17, 2016

⌛️ Testing commit 7ab8c75 with merge e293b1d...

bors added a commit that referenced this pull request Dec 17, 2016
 Warn unused type aliases, reimplemented

Reimplementation of #37631. Fix #37455.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 17, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@sanxiyn sanxiyn force-pushed the sanxiyn:unused-type-alias-3 branch from 7ab8c75 to c187cdc Dec 18, 2016
@sanxiyn

This comment has been minimized.

Copy link
Member Author

sanxiyn commented Dec 18, 2016

I assume cargotest breakage is one fixed by rust-lang/cargo#3299. Updating hash to that.

@sanxiyn sanxiyn force-pushed the sanxiyn:unused-type-alias-3 branch from c187cdc to f71f31a Dec 18, 2016
@eddyb

This comment has been minimized.

Copy link
Member

eddyb commented Dec 18, 2016

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 18, 2016

📌 Commit f71f31a has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 18, 2016

⌛️ Testing commit f71f31a with merge 71c06a5...

bors added a commit that referenced this pull request Dec 18, 2016
 Warn unused type aliases, reimplemented

Reimplementation of #37631. Fix #37455.
@bors bors merged commit f71f31a into rust-lang:master Dec 19, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@sanxiyn sanxiyn deleted the sanxiyn:unused-type-alias-3 branch Dec 19, 2016
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 19, 2016
Recently the Cargo revision running on cargotest was updated in rust-lang#38051, and the
updated version of Cargo pulls in the openssl-sys 0.9 crate instead of the old
openssl-sys 0.7 crate. The 0.9 release of openssl-sys has slightly different
requirements and logic for detecting OpenSSL, namely it requires `pkg-config` to
be present on Linux typically.

This commit fixes this problem by installing pkg-config in the cargotest
container that's running on the bots. This in turn should hopefully fix the
build script and allow it to find the already-installed local OpenSSL libraries.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 20, 2016
travis: Fix the cargotest bot

Recently the Cargo revision running on cargotest was updated in rust-lang#38051, and the
updated version of Cargo pulls in the openssl-sys 0.9 crate instead of the old
openssl-sys 0.7 crate. The 0.9 release of openssl-sys has slightly different
requirements and logic for detecting OpenSSL, namely it requires `pkg-config` to
be present on Linux typically.

This commit fixes this problem by installing pkg-config in the cargotest
container that's running on the bots. This in turn should hopefully fix the
build script and allow it to find the already-installed local OpenSSL libraries.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 20, 2016
travis: Fix the cargotest bot

Recently the Cargo revision running on cargotest was updated in rust-lang#38051, and the
updated version of Cargo pulls in the openssl-sys 0.9 crate instead of the old
openssl-sys 0.7 crate. The 0.9 release of openssl-sys has slightly different
requirements and logic for detecting OpenSSL, namely it requires `pkg-config` to
be present on Linux typically.

This commit fixes this problem by installing pkg-config in the cargotest
container that's running on the bots. This in turn should hopefully fix the
build script and allow it to find the already-installed local OpenSSL libraries.
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Mar 20, 2017
Version 1.16.0 (2017-03-16)
===========================

Language
--------

* Lifetimes in statics and consts default to `'static`. [RFC 1623]
* [The compiler's `dead_code` lint now accounts for type aliases][38051].
* [Uninhabitable enums (those without any variants) no longer permit wildcard
  match patterns][38069]
* [Clean up semantics of `self` in an import list][38313]
* [`Self` may appear in `impl` headers][38920]
* [`Self` may appear in struct expressions][39282]

Compiler
--------

* [`rustc` now supports `--emit=metadata`, which causes rustc to emit
  a `.rmeta` file containing only crate metadata][38571]. This can be
  used by tools like the Rust Language Service to perform
  metadata-only builds.
* [Levenshtein based typo suggestions now work in most places, while
  previously they worked only for fields and sometimes for local
  variables][38927]. Together with the overhaul of "no
  resolution"/"unexpected resolution" errors (#[38154]) they result in
  large and systematic improvement in resolution diagnostics.
* [Fix `transmute::<T, U>` where `T` requires a bigger alignment than
  `U`][38670]
* [rustc: use -Xlinker when specifying an rpath with ',' in it][38798]
* [`rustc` no longer attempts to provide "consider using an explicit
  lifetime" suggestions][37057]. They were inaccurate.

Stabilized APIs
---------------

* [`VecDeque::truncate`]
* [`VecDeque::resize`]
* [`String::insert_str`]
* [`Duration::checked_add`]
* [`Duration::checked_sub`]
* [`Duration::checked_div`]
* [`Duration::checked_mul`]
* [`str::replacen`]
* [`str::repeat`]
* [`SocketAddr::is_ipv4`]
* [`SocketAddr::is_ipv6`]
* [`IpAddr::is_ipv4`]
* [`IpAddr::is_ipv6`]
* [`Vec::dedup_by`]
* [`Vec::dedup_by_key`]
* [`Result::unwrap_or_default`]
* [`<*const T>::wrapping_offset`]
* [`<*mut T>::wrapping_offset`]
* `CommandExt::creation_flags`
* [`File::set_permissions`]
* [`String::split_off`]

Libraries
---------

* [`[T]::binary_search` and `[T]::binary_search_by_key` now take
  their argument by `Borrow` parameter][37761]
* [All public types in std implement `Debug`][38006]
* [`IpAddr` implements `From<Ipv4Addr>` and `From<Ipv6Addr>`][38327]
* [`Ipv6Addr` implements `From<[u16; 8]>`][38131]
* [Ctrl-Z returns from `Stdin.read()` when reading from the console on
  Windows][38274]
* [std: Fix partial writes in `LineWriter`][38062]
* [std: Clamp max read/write sizes on Unix][38062]
* [Use more specific panic message for `&str` slicing errors][38066]
* [`TcpListener::set_only_v6` is deprecated][38304]. This
  functionality cannot be achieved in std currently.
* [`writeln!`, like `println!`, now accepts a form with no string
  or formatting arguments, to just print a newline][38469]
* [Implement `iter::Sum` and `iter::Product` for `Result`][38580]
* [Reduce the size of static data in `std_unicode::tables`][38781]
* [`char::EscapeDebug`, `EscapeDefault`, `EscapeUnicode`,
  `CaseMappingIter`, `ToLowercase`, `ToUppercase`, implement
  `Display`][38909]
* [`Duration` implements `Sum`][38712]
* [`String` implements `ToSocketAddrs`][39048]

Cargo
-----

* [The `cargo check` command does a type check of a project without
  building it][cargo/3296]
* [crates.io will display CI badges from Travis and AppVeyor, if
  specified in Cargo.toml][cargo/3546]
* [crates.io will display categories listed in Cargo.toml][cargo/3301]
* [Compilation profiles accept integer values for `debug`, in addition
  to `true` and `false`. These are passed to `rustc` as the value to
  `-C debuginfo`][cargo/3534]
* [Implement `cargo --version --verbose`][cargo/3604]
* [All builds now output 'dep-info' build dependencies compatible with
  make and ninja][cargo/3557]
* [Build all workspace members with `build --all`][cargo/3511]
* [Document all workspace members with `doc --all`][cargo/3515]
* [Path deps outside workspace are not members][cargo/3443]

Misc
----

* [`rustdoc` has a `--sysroot` argument that, like `rustc`, specifies
  the path to the Rust implementation][38589]
* [The `armv7-linux-androideabi` target no longer enables NEON
  extensions, per Google's ABI guide][38413]
* [The stock standard library can be compiled for Redox OS][38401]
* [Rust has initial SPARC support][38726]. Tier 3. No builds
  available.
* [Rust has experimental support for Nvidia PTX][38559]. Tier 3. No
  builds available.
* [Fix backtraces on i686-pc-windows-gnu by disabling FPO][39379]

Compatibility Notes
-------------------

* [Uninhabitable enums (those without any variants) no longer permit wildcard
  match patterns][38069]
* In this release, references to uninhabited types can not be
  pattern-matched. This was accidentally allowed in 1.15.
* [The compiler's `dead_code` lint now accounts for type aliases][38051].
* [Ctrl-Z returns from `Stdin.read()` when reading from the console on
  Windows][38274]
* [Clean up semantics of `self` in an import list][38313]

[37057]: rust-lang/rust#37057
[37761]: rust-lang/rust#37761
[38006]: rust-lang/rust#38006
[38051]: rust-lang/rust#38051
[38062]: rust-lang/rust#38062
[38062]: rust-lang/rust#38622
[38066]: rust-lang/rust#38066
[38069]: rust-lang/rust#38069
[38131]: rust-lang/rust#38131
[38154]: rust-lang/rust#38154
[38274]: rust-lang/rust#38274
[38304]: rust-lang/rust#38304
[38313]: rust-lang/rust#38313
[38314]: rust-lang/rust#38314
[38327]: rust-lang/rust#38327
[38401]: rust-lang/rust#38401
[38413]: rust-lang/rust#38413
[38469]: rust-lang/rust#38469
[38559]: rust-lang/rust#38559
[38571]: rust-lang/rust#38571
[38580]: rust-lang/rust#38580
[38589]: rust-lang/rust#38589
[38670]: rust-lang/rust#38670
[38712]: rust-lang/rust#38712
[38726]: rust-lang/rust#38726
[38781]: rust-lang/rust#38781
[38798]: rust-lang/rust#38798
[38909]: rust-lang/rust#38909
[38920]: rust-lang/rust#38920
[38927]: rust-lang/rust#38927
[39048]: rust-lang/rust#39048
[39282]: rust-lang/rust#39282
[39379]: rust-lang/rust#39379
[`<*const T>::wrapping_offset`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.wrapping_offset
[`<*mut T>::wrapping_offset`]: https://doc.rust-lang.org/std/primitive.pointer.html#method.wrapping_offset
[`Duration::checked_add`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_add
[`Duration::checked_div`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_div
[`Duration::checked_mul`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_mul
[`Duration::checked_sub`]: https://doc.rust-lang.org/std/time/struct.Duration.html#method.checked_sub
[`File::set_permissions`]: https://doc.rust-lang.org/std/fs/struct.File.html#method.set_permissions
[`IpAddr::is_ipv4`]: https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.is_ipv4
[`IpAddr::is_ipv6`]: https://doc.rust-lang.org/std/net/enum.IpAddr.html#method.is_ipv6
[`Result::unwrap_or_default`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.unwrap_or_default
[`SocketAddr::is_ipv4`]: https://doc.rust-lang.org/std/net/enum.SocketAddr.html#method.is_ipv4
[`SocketAddr::is_ipv6`]: https://doc.rust-lang.org/std/net/enum.SocketAddr.html#method.is_ipv6
[`String::insert_str`]: https://doc.rust-lang.org/std/string/struct.String.html#method.insert_str
[`String::split_off`]: https://doc.rust-lang.org/std/string/struct.String.html#method.split_off
[`Vec::dedup_by_key`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.dedup_by_key
[`Vec::dedup_by`]: https://doc.rust-lang.org/std/vec/struct.Vec.html#method.dedup_by
[`VecDeque::resize`]:  https://doc.rust-lang.org/std/collections/vec_deque/struct.VecDeque.html#method.resize
[`VecDeque::truncate`]: https://doc.rust-lang.org/std/collections/vec_deque/struct.VecDeque.html#method.truncate
[`str::repeat`]: https://doc.rust-lang.org/std/primitive.str.html#method.repeat
[`str::replacen`]: https://doc.rust-lang.org/std/primitive.str.html#method.replacen
[cargo/3296]: rust-lang/cargo#3296
[cargo/3301]: rust-lang/cargo#3301
[cargo/3443]: rust-lang/cargo#3443
[cargo/3511]: rust-lang/cargo#3511
[cargo/3515]: rust-lang/cargo#3515
[cargo/3534]: rust-lang/cargo#3534
[cargo/3546]: rust-lang/cargo#3546
[cargo/3557]: rust-lang/cargo#3557
[cargo/3604]: rust-lang/cargo#3604
[RFC 1623]: https://github.com/rust-lang/rfcs/blob/master/text/1623-static.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.