Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upresolve: change most backwards incompatible ambiguity errors to `legacy_imports` warnings #38271
Conversation
rust-highfive
assigned
nrc
Dec 9, 2016
jseyfried
referenced this pull request
Dec 9, 2016
Closed
`legacy_imports` future-compatibility warnings #38260
jseyfried
force-pushed the
jseyfried:rfc_1560_warning_cycle
branch
from
162e61d
to
1993a07
Dec 10, 2016
jseyfried
force-pushed the
jseyfried:rfc_1560_warning_cycle
branch
from
1993a07
to
cfabce2
Dec 15, 2016
This comment has been minimized.
This comment has been minimized.
|
ping @nrc / @nikomatsakis, would be great to get this in before beta! |
This comment has been minimized.
This comment has been minimized.
|
Nominating for beta to ensure we don't forget about this if it misses the beta branch. Note that this should only go into 1.15.0 beta, not the current (as of this writing) 1.14.0 beta. |
alexcrichton
added
the
beta-nominated
label
Dec 15, 2016
alexcrichton
referenced this pull request
Dec 15, 2016
Closed
Glob resolution error in nanomsg-sys 0.6.0 in rust 1.13 beta #38389
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 20, 2016
bors
referenced this pull request
Dec 20, 2016
Merged
Improvements to `BTreeSet` documentation. #38208
This comment has been minimized.
This comment has been minimized.
bors
merged commit cfabce2
into
rust-lang:master
Dec 20, 2016
bors
referenced this pull request
Dec 20, 2016
Closed
Miscellaneous cleanup/refactoring in `resolve` and `syntax::ext` #38171
jseyfried
deleted the
jseyfried:rfc_1560_warning_cycle
branch
Dec 20, 2016
bors
referenced this pull request
Dec 20, 2016
Merged
Use `DefId`s instead of `NodeId`s for `pub(restricted)` visibilities #38490
bors
added a commit
that referenced
this pull request
Dec 20, 2016
This comment has been minimized.
This comment has been minimized.
|
Marking as beta-accepted. Patch is kind of medium-ish, but this is a serious regression, and mostly the patch is converting errors into lints. cc @rust-lang/compiler |
nikomatsakis
added
the
beta-accepted
label
Dec 30, 2016
brson
removed
the
beta-nominated
label
Dec 30, 2016
jseyfried
referenced this pull request
Jan 10, 2017
Merged
resolve: clean up the semantics of `self` in an import list #38313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jseyfried commentedDec 9, 2016
Fixes #38176.
r? @nrc or @nikomatsakis