Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Attempt to fix travis builds #38336
Conversation
rust-highfive
assigned
brson
Dec 13, 2016
This comment has been minimized.
This comment has been minimized.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
changed the title
Attempt to fix travis builds
WIP: Attempt to fix travis builds
Dec 13, 2016
alexcrichton
assigned
alexcrichton
and unassigned
brson
Dec 13, 2016
This comment has been minimized.
This comment has been minimized.
|
It seems it worked! |
This comment has been minimized.
This comment has been minimized.
|
Well who'da thunk. Will reopen with a better description and such. |
alexcrichton
closed this
Dec 13, 2016
alexcrichton
deleted the
alexcrichton:fix-travis
branch
Dec 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedDec 13, 2016
This is just a shot in the dark, but after reading https://blog.phusion.nl/2015/01/20/docker-and-the-pid-1-zombie-reaping-problem/ and https://engineeringblog.yelp.com/2016/01/dumb-init-an-init-for-docker.html today I got paranoid and started wondering if this is what's causing problems.
Let's see if this fixes anything by taking Yelp's "dumb-init" init program and see if it fixes the issues we're seeing. If this works I'll resubmit with the PR, updating all other images, and with a better description.