Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk: Fix compile with makefiles #38506

Merged
merged 1 commit into from Dec 21, 2016

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
beta-accepted
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @brson @bors @nikomatsakis
@alexcrichton
Copy link
Member

alexcrichton commented Dec 21, 2016

A tweak was made to dependencies in #38451 but the makefiles weren't updated to
accompany this. Instead of trying to integerate the build_helper crate into
the makefiles (which currently isn't present) this commit takes the approach of
just duplicating the required logic, which should be small enough for now.
@alexcrichton
mk: Fix compile with makefiles 
A tweak was made to dependencies in #38451 but the makefiles weren't updated to
accompany this. Instead of trying to integerate the `build_helper` crate into
the makefiles (which currently isn't present) this commit takes the approach of
just duplicating the required logic, which should be small enough for now.
Loading status checks…
839b696

@rust-highfive rust-highfive assigned nikomatsakis Dec 21, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Dec 21, 2016

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Dec 21, 2016

@bors r+ p=1
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 21, 2016

📌 Commit 839b696 has been approved by brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 21, 2016

⌛️ Testing commit 839b696 with merge 92d4600...

bors added a commit that referenced this pull request Dec 21, 2016

@bors
Auto merge of #38506 - alexcrichton:fix-makefiles, r=brson 
mk: Fix compile with makefiles

A tweak was made to dependencies in #38451 but the makefiles weren't updated to
accompany this. Instead of trying to integerate the `build_helper` crate into
the makefiles (which currently isn't present) this commit takes the approach of
just duplicating the required logic, which should be small enough for now.
Loading status checks…
92d4600
@bors

@bors bors merged commit 839b696 into rust-lang:master Dec 21, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:fix-makefiles branch Dec 27, 2016

@brson brson added the beta-nominated label Jan 19, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jan 19, 2017

Nominated per https://internals.rust-lang.org/t/rust-1-15-release-status/4590/11

@alexcrichton alexcrichton added the beta-accepted label Jan 19, 2017

@brson brson referenced this pull request Jan 19, 2017

Merged

Beta next #39189

@alexcrichton alexcrichton removed the beta-nominated label Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.