Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable field reordering #38523
Conversation
rust-highfive
assigned
nikomatsakis
Dec 21, 2016
This comment has been minimized.
This comment has been minimized.
|
Out of curiosity, was the breakage due to bugs in the compiler or in servo? |
This comment has been minimized.
This comment has been minimized.
|
Servo, but leading to us discussing how to roll out these sorts of changes and raising the question "what about other people?" The longterm plan for the change isn't yet decided. |
This comment has been minimized.
This comment has been minimized.
|
Cool, makes sense. This was always the result I feared of us delaying making the change for however many years its been since that RFC. |
camlorn
force-pushed the
camlorn:disable_field_reordering
branch
from
943b78e
to
b6b630a
Dec 22, 2016
camlorn
referenced this pull request
Dec 23, 2016
Closed
Begin exercising rustc's right to reorder struct fields for optimal padding #28951
This comment has been minimized.
This comment has been minimized.
|
@bors r+ p=1 |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 23, 2016
This comment has been minimized.
This comment has been minimized.
bors
merged commit b6b630a
into
rust-lang:master
Dec 24, 2016
nikomatsakis
added
beta-accepted
beta-nominated
T-compiler
labels
Dec 24, 2016
This comment has been minimized.
This comment has been minimized.
|
Nominated for beta (and marked as accepted). |
camlorn
deleted the
camlorn:disable_field_reordering
branch
Dec 24, 2016
brson
removed
the
beta-nominated
label
Dec 30, 2016
alexcrichton
referenced this pull request
Dec 30, 2016
Closed
Hang in utp-0.6.3 test suite in Rust 1.15 #38720
sanxiyn
referenced this pull request
Jan 1, 2017
Closed
Shrink `token::Lit`'s hash count from usize to u16. #38043
camlorn
restored the
camlorn:disable_field_reordering
branch
Feb 2, 2017
Mark-Simulacrum
referenced this pull request
Jun 7, 2018
Closed
Missing tokens in custom derive input generated by macro #51331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
camlorn commentedDec 21, 2016
This was decided via IRC and needs a backport to beta. Basically, #37429 broke servo, and probably needs an announcement and opt-in flag. I didn't run all tests locally but think I've already reverted all the ones that need to be reverted.
r? @nikomatsakis