Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable field reordering #38523

Merged
merged 1 commit into from Dec 24, 2016
Merged

Disable field reordering #38523

merged 1 commit into from Dec 24, 2016

Conversation

@camlorn
Copy link
Contributor

camlorn commented Dec 21, 2016

This was decided via IRC and needs a backport to beta. Basically, #37429 broke servo, and probably needs an announcement and opt-in flag. I didn't run all tests locally but think I've already reverted all the ones that need to be reverted.

r? @nikomatsakis

@sfackler
Copy link
Member

sfackler commented Dec 22, 2016

Out of curiosity, was the breakage due to bugs in the compiler or in servo?

@camlorn
Copy link
Contributor Author

camlorn commented Dec 22, 2016

Servo, but leading to us discussing how to roll out these sorts of changes and raising the question "what about other people?" The longterm plan for the change isn't yet decided.

@sfackler
Copy link
Member

sfackler commented Dec 22, 2016

Cool, makes sense. This was always the result I feared of us delaying making the change for however many years its been since that RFC.

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Dec 23, 2016

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Dec 23, 2016

📌 Commit b6b630a has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Dec 23, 2016

Testing commit b6b630a with merge 4d07320...

bors added a commit that referenced this pull request Dec 23, 2016
Disable field reordering

This was decided via IRC and needs a backport to beta.  Basically, #37429 broke servo, and probably needs an announcement and opt-in flag.  I didn't run all tests locally but think I've already reverted all the ones that need to be reverted.

r? @nikomatsakis
@bors bors merged commit b6b630a into rust-lang:master Dec 24, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Dec 24, 2016

Nominated for beta (and marked as accepted).

cc @rust-lang/compiler

@camlorn camlorn deleted the camlorn:disable_field_reordering branch Dec 24, 2016
@brson brson removed the beta-nominated label Dec 30, 2016
@camlorn camlorn restored the camlorn:disable_field_reordering branch Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.