Disable field reordering #38523
Merged
Disable field reordering #38523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, was the breakage due to bugs in the compiler or in servo? |
|
Servo, but leading to us discussing how to roll out these sorts of changes and raising the question "what about other people?" The longterm plan for the change isn't yet decided. |
|
Cool, makes sense. This was always the result I feared of us delaying making the change for however many years its been since that RFC. |
ahicks92
force-pushed
the
disable_field_reordering
branch
from
943b78e
to
b6b630a
Compare
|
@bors r+ p=1 |
|
📌 Commit b6b630a has been approved by |
bors
added a commit
that referenced
this pull request
Dec 23, 2016
Disable field reordering This was decided via IRC and needs a backport to beta. Basically, #37429 broke servo, and probably needs an announcement and opt-in flag. I didn't run all tests locally but think I've already reverted all the ones that need to be reverted. r? @nikomatsakis
nikomatsakis
added
beta-accepted
|
Nominated for beta (and marked as accepted). cc @rust-lang/compiler |
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was decided via IRC and needs a backport to beta. Basically, #37429 broke servo, and probably needs an announcement and opt-in flag. I didn't run all tests locally but think I've already reverted all the ones that need to be reverted.
r? @nikomatsakis