Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fs tests on Windows systems with non-english locales. #38536

Merged
merged 1 commit into from Dec 26, 2016

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@retep998 @rust-highfive @petrochenkov @bors @daschl @est31 @brson
@retep998
Copy link
Member

retep998 commented Dec 22, 2016 •
edited

Fixes #34628

r? @alexcrichton

@rust-highfive rust-highfive assigned brson Dec 22, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Dec 22, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Dec 22, 2016

Does this fix #34628?
(That issue becomes more important because rustbuild doesn't allow manually skipping tests currently.)
@retep998
Fix fs tests on Windows systems with non-english locales.
Verified
This commit was signed with a verified signature.
@retep998 retep998 Peter Atashian
GPG key ID: DE04D9E27559BC8A Learn about signing commits
Loading status checks…
23cfcdd

@retep998 retep998 force-pushed the retep998:flauschige-kaninchen branch from 5f6d3ac to 23cfcdd Dec 22, 2016

@retep998

This comment has been minimized.

Sign in to view
Copy link
Member Author

retep998 commented Dec 22, 2016

@petrochenkov It does now.
@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Dec 23, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 23, 2016

📌 Commit 23cfcdd has been approved by petrochenkov
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 26, 2016

⌛️ Testing commit 23cfcdd with merge 8493dbe...

bors added a commit that referenced this pull request Dec 26, 2016

@bors
Auto merge of #38536 - retep998:flauschige-kaninchen, r=petrochenkov 
Fix fs tests on Windows systems with non-english locales.

Fixes #34628

r? @alexcrichton
Loading status checks…
8493dbe
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 26, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 8493dbe to master...

@bors bors merged commit 23cfcdd into rust-lang:master Dec 26, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@daschl

This comment has been minimized.

Sign in to view
Copy link

daschl commented Dec 26, 2016

@retep998 how did that branch name came to be? 😂
@est31

This comment has been minimized.

Sign in to view
Copy link
Contributor

est31 commented Dec 26, 2016

@daschl I've stumbled across this error on a german locale, and the 🐇 has fixed it :)

@brson brson referenced this pull request Dec 27, 2016

Closed

Enable building complete release artifacts on Travis / Appveyor #38531

33 of 38 tasks complete
@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Dec 27, 2016

Can confirm, with chcp 65001 all make check tests now pass on a totally non-English (Windows itself, locale, username, env vars) system.

@Mark-Simulacrum Mark-Simulacrum referenced this pull request Jun 7, 2018

Closed

Missing tokens in custom derive input generated by macro #51331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.