Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten targets are Unix targets #38598

Merged
merged 2 commits into from Dec 26, 2016

Conversation

Projects
None yet
8 participants
@brson
Copy link
Contributor

brson commented Dec 25, 2016

I suspect this will fix the errors compiling libc https://buildbot.rust-lang.org/builders/auto-linux-rustbuild-cross-opt/builds/689/steps/compile/logs/stdio that are occurring on every PR.

Emscripten is basically a posix emulation layer for the web and I consider it a Unix.

cc @alexcrichton

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 25, 2016

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Dec 25, 2016

I don't know how the error got onto master. It seems like bors would have caught that.

@brson brson assigned alexcrichton and unassigned arielb1 Dec 25, 2016

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Dec 25, 2016

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2016

📌 Commit 31bda23 has been approved by sfackler

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Dec 25, 2016

Travis failed with some pretty relevant errors.

@tomaka

This comment has been minimized.

Copy link
Contributor

tomaka commented Dec 25, 2016

Is there a possibility that it breaks code that does #[cfg(unix)] and #[cfg(emscripten)]?

Move target_family to TargetOptions, not Target
Just fixing a compile error
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Dec 25, 2016

@bors: r+ p=1

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 25, 2016

📌 Commit f262eea has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 26, 2016

⌛️ Testing commit f262eea with merge 5752eae...

bors added a commit that referenced this pull request Dec 26, 2016

Auto merge of #38598 - brson:em, r=alexcrichton
Emscripten targets are Unix targets

I suspect this will fix the errors compiling libc https://buildbot.rust-lang.org/builders/auto-linux-rustbuild-cross-opt/builds/689/steps/compile/logs/stdio that are occurring on every PR.

Emscripten is basically a posix emulation layer for the web and I consider it a Unix.

cc @alexcrichton
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Dec 26, 2016

I don't know how the error got onto master. It seems like bors would have caught that.

Turns out we're not gating on the relevant builder in homu, we just haven't regressed it until now. Hurray!

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Dec 26, 2016

This passed on Travis and AppVeyor, merging manually

@alexcrichton alexcrichton merged commit f262eea into rust-lang:master Dec 26, 2016

1 of 2 checks passed

homu Testing commit f262eea with merge 5752eae...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.