Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEmscripten targets are Unix targets #38598
Conversation
rust-highfive
assigned
arielb1
Dec 25, 2016
This comment has been minimized.
This comment has been minimized.
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
I don't know how the error got onto master. It seems like bors would have caught that. |
brson
assigned
alexcrichton
and unassigned
arielb1
Dec 25, 2016
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Travis failed with some pretty relevant errors. |
This comment has been minimized.
This comment has been minimized.
|
Is there a possibility that it breaks code that does |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ p=1 |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Dec 26, 2016
This comment has been minimized.
This comment has been minimized.
Turns out we're not gating on the relevant builder in homu, we just haven't regressed it until now. Hurray! |
This comment has been minimized.
This comment has been minimized.
alexcrichton
merged commit f262eea
into
rust-lang:master
Dec 26, 2016
Mark-Simulacrum
referenced this pull request
Jun 7, 2018
Closed
Missing tokens in custom derive input generated by macro #51331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brson commentedDec 25, 2016
I suspect this will fix the errors compiling libc https://buildbot.rust-lang.org/builders/auto-linux-rustbuild-cross-opt/builds/689/steps/compile/logs/stdio that are occurring on every PR.
Emscripten is basically a posix emulation layer for the web and I consider it a Unix.
cc @alexcrichton