Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Attempt to fix Android flakiness #38619

Merged
merged 1 commit into from Dec 29, 2016

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alexcrichton @rust-highfive @brson @bors
@alexcrichton
Copy link
Member

alexcrichton commented Dec 26, 2016

There's been some flaky runs on Travis where the Android emulator is having
problems staying alive... presumably? For example:

This commit spawns the emulator in the same way as buildbot with nohup to hope
that it goes into the background successfully, followed by a wait-for-device
command. I'm not actually sure if this'll fix the problems we're seeing, but I
figure it can't hurt to test out.
@alexcrichton
travis: Attempt to fix Android flakiness 
There's been some flaky runs on Travis where the Android emulator is having
problems staying alive... presumably? For example:

* https://travis-ci.org/rust-lang/rust/jobs/186736745

This commit spawns the emulator in the same way as buildbot with `nohup` to hope
that it goes into the background successfully, followed by a `wait-for-device`
command. I'm not actually sure if this'll fix the problems we're seeing, but I
figure it can't hurt to test out.
Loading status checks…
35420b0

@rust-highfive rust-highfive assigned brson Dec 26, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Dec 26, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

This was referenced Dec 26, 2016

Merged
Merged
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Dec 28, 2016

@bors r+ p=2
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 28, 2016

📌 Commit 35420b0 has been approved by brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 28, 2016

⌛️ Testing commit 35420b0 with merge 6fe064c...

bors added a commit that referenced this pull request Dec 28, 2016

@bors
Auto merge of #38619 - alexcrichton:less-android-flaky, r=brson 
travis: Attempt to fix Android flakiness

There's been some flaky runs on Travis where the Android emulator is having
problems staying alive... presumably? For example:

* https://travis-ci.org/rust-lang/rust/jobs/186736745

This commit spawns the emulator in the same way as buildbot with `nohup` to hope
that it goes into the background successfully, followed by a `wait-for-device`
command. I'm not actually sure if this'll fix the problems we're seeing, but I
figure it can't hurt to test out.
Loading status checks…
6fe064c
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 28, 2016

💔 Test failed - status-travis
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 28, 2016

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 28, 2016

⌛️ Testing commit 35420b0 with merge bc4af67...

bors added a commit that referenced this pull request Dec 28, 2016

@bors
Auto merge of #38619 - alexcrichton:less-android-flaky, r=brson 
travis: Attempt to fix Android flakiness

There's been some flaky runs on Travis where the Android emulator is having
problems staying alive... presumably? For example:

* https://travis-ci.org/rust-lang/rust/jobs/186736745

This commit spawns the emulator in the same way as buildbot with `nohup` to hope
that it goes into the background successfully, followed by a `wait-for-device`
command. I'm not actually sure if this'll fix the problems we're seeing, but I
figure it can't hurt to test out.
Loading status checks…
bc4af67
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 29, 2016

💔 Test failed - status-travis
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 29, 2016

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 29, 2016

⌛️ Testing commit 35420b0 with merge 1d9965b...

bors added a commit that referenced this pull request Dec 29, 2016

@bors
Auto merge of #38619 - alexcrichton:less-android-flaky, r=brson 
travis: Attempt to fix Android flakiness

There's been some flaky runs on Travis where the Android emulator is having
problems staying alive... presumably? For example:

* https://travis-ci.org/rust-lang/rust/jobs/186736745

This commit spawns the emulator in the same way as buildbot with `nohup` to hope
that it goes into the background successfully, followed by a `wait-for-device`
command. I'm not actually sure if this'll fix the problems we're seeing, but I
figure it can't hurt to test out.
Loading status checks…
1d9965b
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 29, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 1d9965b to master...

@bors bors merged commit 35420b0 into rust-lang:master Dec 29, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:less-android-flaky branch Dec 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.