Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiletest: Don't limit all suites on Android #38647

Merged
merged 1 commit into from Dec 30, 2016

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alexcrichton @rust-highfive @brson @bors
@alexcrichton
Copy link
Member

alexcrichton commented Dec 28, 2016

On Android we only have one test thread for supposed problems with concurrency
and the remote debugger. Not all of our suites require one concurrency, however,
and suites like compile-fail or pretty can be much faster if they're
parallelized on Travis.

This commit only sets the test threads to one on Android for suites which
actually run code, and other suites aren't tampered with.
@alexcrichton
compiletest: Don't limit all suites on Android 
On Android we only have one test thread for supposed problems with concurrency
and the remote debugger. Not all of our suites require one concurrency, however,
and suites like compile-fail or pretty can be much faster if they're
parallelized on Travis.

This commit only sets the test threads to one on Android for suites which
actually run code, and other suites aren't tampered with.
Loading status checks…
f26e52e

@rust-highfive rust-highfive assigned brson Dec 28, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Dec 28, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Dec 29, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 29, 2016

📌 Commit f26e52e has been approved by brson

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016

@alexcrichton
Rollup merge of rust-lang#38647 - alexcrichton:faster-android, r=brson 
compiletest: Don't limit all suites on Android

On Android we only have one test thread for supposed problems with concurrency
and the remote debugger. Not all of our suites require one concurrency, however,
and suites like compile-fail or pretty can be much faster if they're
parallelized on Travis.

This commit only sets the test threads to one on Android for suites which
actually run code, and other suites aren't tampered with.
332a4cc

@alexcrichton alexcrichton referenced this pull request Dec 30, 2016

Merged

Rollup of 25 pull requests #38697

bors added a commit that referenced this pull request Dec 30, 2016

@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
Loading status checks…
4a68076

bors added a commit that referenced this pull request Dec 30, 2016

@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
Loading status checks…
4536280

bors added a commit that referenced this pull request Dec 30, 2016

@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
Loading status checks…
c4908ce

bors added a commit that referenced this pull request Dec 30, 2016

@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
Loading status checks…
7f2d2af

@bors bors merged commit f26e52e into rust-lang:master Dec 30, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexcrichton alexcrichton deleted the alexcrichton:faster-android branch Dec 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.