Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Move pretty test suites to host-only #38665

Merged
merged 1 commit into from Dec 30, 2016

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alexcrichton @rust-highfive @brson @bors
@alexcrichton
Copy link
Member

alexcrichton commented Dec 28, 2016

In an ongoing effort to optimize the runtime of the Android cross builder this
commit updates the pretty test suites to run only for host platforms, not for
target platforms as well. This means we'll still keep running all the suites but
we'll only run them for configured hosts, not for configured targets. This
notably means that we won't be running these suites on Android or musl targets,
for example.
@alexcrichton
rustbuild: Move pretty test suites to host-only 
In an ongoing effort to optimize the runtime of the Android cross builder this
commit updates the pretty test suites to run only for host platforms, not for
target platforms as well. This means we'll still keep running all the suites but
we'll only run them for configured hosts, not for configured targets. This
notably means that we won't be running these suites on Android or musl targets,
for example.
Loading status checks…
fc3e49b

@rust-highfive rust-highfive assigned brson Dec 28, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Dec 28, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Dec 28, 2016

Note that I consider this orthogonal to #38420 where I'd like to trim the number of pretty suites we run. In either case I think it's fine to only run the suites for host targets, not for all targets.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Dec 29, 2016

This is fine if its what you want r+, but I'd also be happy completely removing them from the main suite and punting them to the cargotest bots.

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 29, 2016

📌 Commit fc3e49b has been approved by brson

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2016

@alexcrichton
Rollup merge of rust-lang#38665 - alexcrichton:pretty-only-host, r=brson 
rustbuild: Move pretty test suites to host-only

In an ongoing effort to optimize the runtime of the Android cross builder this
commit updates the pretty test suites to run only for host platforms, not for
target platforms as well. This means we'll still keep running all the suites but
we'll only run them for configured hosts, not for configured targets. This
notably means that we won't be running these suites on Android or musl targets,
for example.
2dc1a0a

@alexcrichton alexcrichton referenced this pull request Dec 30, 2016

Merged

Rollup of 25 pull requests #38697

bors added a commit that referenced this pull request Dec 30, 2016

@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
Loading status checks…
4a68076

bors added a commit that referenced this pull request Dec 30, 2016

@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
Loading status checks…
4536280

bors added a commit that referenced this pull request Dec 30, 2016

@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
Loading status checks…
c4908ce

bors added a commit that referenced this pull request Dec 30, 2016

@bors
Auto merge of #38697 - alexcrichton:rollup, r=alexcrichton 
Rollup of 25 pull requests

- Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695
- Failed merges: #38657, #38680
Loading status checks…
7f2d2af

@bors bors merged commit fc3e49b into rust-lang:master Dec 30, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Dec 30, 2016

⌛️ Testing commit fc3e49b with merge 7f2d2af...

@alexcrichton alexcrichton deleted the alexcrichton:pretty-only-host branch Dec 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.