Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upsparc64-linux support #38726
Conversation
jakllsch
and others
added some commits
Dec 3, 2016
rust-highfive
assigned
alexcrichton
Dec 31, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
@japaric If you rather want to debug on a real machine than on qemu, let me know. If you like, please join us in #sparc on Freenode. |
This comment has been minimized.
This comment has been minimized.
jrtc27
commented
Dec 31, 2016
•
|
At a glance, the C ABI seems wrong; small structs should be passed in and returned in registers. |
This comment has been minimized.
This comment has been minimized.
|
@japaric Yes, backtrace of |
This comment has been minimized.
This comment has been minimized.
|
@jrtc27 It's very possible |
This comment has been minimized.
This comment has been minimized.
|
This seems good to me, thanks @japaric! I'm perpetually worried about all this cabi business though. It seems no one really knows what they're doing around the cabi modules and I'm reading "hello world works" as "someone's going to waste hours of their life later fixing an abi-related bug" |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jan 1, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors retry Network failure. |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jan 1, 2017
This comment has been minimized.
This comment has been minimized.
|
|
japaric commentedDec 31, 2016
This is built on top of #38656 and depends on rust-lang/libc#483
Hello world works.
The libc-test test suite passes.
panic!doesn't fully work:Backtraces don't work either, probably related to the previous point:
r? @alexcrichton
@jakllsch Does panicking / backtraces work on sparc64-netbsd?
cc @glaubitz