Fix regression with duplicate #[macro_export] macro_rules!
#38793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
added
beta-nominated
|
Thanks @jseyfried ! |
nrc
approved these changes
Jan 4, 2017
| // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
There was a problem hiding this comment.
Could you add a comment explaining what is being tested please?
jseyfried
force-pushed
the
fix_macro_export_duplicates
branch
from
4d43052
to
78afcc9
Compare
jseyfried
force-pushed
the
fix_macro_export_duplicates
branch
from
78afcc9
to
927408d
Compare
|
@bors r=nrc |
|
📌 Commit 927408d has been approved by |
nikomatsakis
added
the
beta-accepted
|
Regression. Small patch. Low impact. Accepted for beta. cc @rust-lang/compiler |
|
@bors: p=1 (this is approved, we'll want to backport) |
|
⌛ Testing commit 927408d with merge 485e2a4... |
|
💔 Test failed - status-travis |
|
@bors: retry
* osx linker segfaulted
…On Wed, Jan 4, 2017 at 4:11 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189017797>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38793 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95DeLRutVEzo6BE2mPRhn4bBSDjmlks5rPDUhgaJpZM4LZTie>
.
|
|
⌛ Testing commit 927408d with merge f7f5950... |
|
💔 Test failed - status-travis |
|
@bors: retry
* sccache wedged?
…On Wed, Jan 4, 2017 at 6:47 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189053714>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38793 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95I4CVi6vdAXnT6FSQu0TZIHR6NQDks5rPFnIgaJpZM4LZTie>
.
|
|
⌛ Testing commit 927408d with merge c711172... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network failure
…On Thu, Jan 5, 2017 at 9:16 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189252660>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38793 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95HEKyHO3HIBUGqSj6RSKh4rnLQV0ks5rPSWGgaJpZM4LZTie>
.
|
|
⌛ Testing commit 927408d with merge 4b0378d... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network failure
…On Thu, Jan 5, 2017 at 9:29 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189256149>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38793 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95EIwi0tOjilLM881652hkdklJJNhks5rPShtgaJpZM4LZTie>
.
|
|
💔 Test failed - status-travis |
|
@bors: retry
* osx linker segfaulted
…On Thu, Jan 5, 2017 at 11:56 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189268798>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38793 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95EBB4BPMaFQojIBbv77oTLHiZRTFks5rPUrXgaJpZM4LZTie>
.
|
|
⌛ Testing commit 927408d with merge 0fc0e17... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network error
…On Thu, Jan 5, 2017 at 4:12 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189366514>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38793 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95KbRZnzENMYcDPydpeBrlhPIoELjks5rPYbVgaJpZM4LZTie>
.
|
|
⌛ Testing commit 927408d with merge c4065eb... |
|
💔 Test failed - status-travis |
|
@bors: retry
* osx linker segfaulted
…On Thu, Jan 5, 2017 at 7:39 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/189389301>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38793 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95PddDCMyu9BnjLu7O-v95pR9OAN9ks5rPbd6gaJpZM4LZTie>
.
|
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38715.
r? @nrc