Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve: don't `unused_qualifications`-check global paths #38817

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Reviewers
No reviews
Assignees

@nrc nrc

Labels
T-compiler beta-accepted
Projects
None yet
Milestone
No milestone
7 participants
@jseyfried @petrochenkov @bors @killercup @nikomatsakis @alexcrichton @nrc
@jseyfried
Copy link
Contributor

jseyfried commented Jan 4, 2017

We started unused_qualifications-checking global paths in #38014, causing #38682.
Fixes #38682.
r? @nrc

@rust-highfive rust-highfive assigned nrc Jan 4, 2017

@jseyfried

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jseyfried commented Jan 4, 2017 •
edited

The macros 1.1 system currently not provide enough span info to unused_qualifications-check only unexpanded global paths.
Improving the span info enough to fix this is doable but I'd rather we not have to backport it.

@jseyfried jseyfried referenced this pull request Jan 4, 2017

Closed

Bad unnecesary qualification lint from macro expansion in Rust 1.15 #38682

@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Jan 4, 2017

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 4, 2017

📌 Commit 7dcacf1 has been approved by petrochenkov

@jseyfried jseyfried added beta-nominated T-compiler labels Jan 4, 2017

@killercup

This comment has been minimized.

Sign in to view
Copy link
Member

killercup commented Jan 4, 2017

FYI this could also fix #38444 (which is already closed)

@nikomatsakis nikomatsakis added the beta-accepted label Jan 4, 2017

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jan 4, 2017

Accepted for beta. Small patch, regression. cc @rust-lang/compiler
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jan 4, 2017

@bors: p=1

(this is approved, we'll want to backport)
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2017

⌛️ Testing commit 7dcacf1 with merge a39fc9c...

bors added a commit that referenced this pull request Jan 5, 2017

@bors
Auto merge of #38817 - jseyfried:improve_unused_qualification_lint, r… 
…=petrochenkov

resolve: don't `unused_qualifications`-check global paths

We started `unused_qualifications`-checking global paths in #38014, causing #38682.
Fixes #38682.
r? @nrc
Loading status checks…
a39fc9c
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2017

💔 Test failed - status-travis
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jan 5, 2017

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2017

⌛️ Testing commit 7dcacf1 with merge a10ce81...

bors added a commit that referenced this pull request Jan 5, 2017

@bors
Auto merge of #38817 - jseyfried:improve_unused_qualification_lint, r… 
…=petrochenkov

resolve: don't `unused_qualifications`-check global paths

We started `unused_qualifications`-checking global paths in #38014, causing #38682.
Fixes #38682.
r? @nrc
Loading status checks…
a10ce81
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2017

💔 Test failed - status-travis
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jan 5, 2017

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2017

⌛️ Testing commit 7dcacf1 with merge cdd72e7...

bors added a commit that referenced this pull request Jan 5, 2017

@bors
Auto merge of #38817 - jseyfried:improve_unused_qualification_lint, r… 
…=petrochenkov

resolve: don't `unused_qualifications`-check global paths

We started `unused_qualifications`-checking global paths in #38014, causing #38682.
Fixes #38682.
r? @nrc
Loading status checks…
cdd72e7
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2017

💔 Test failed - status-travis
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jan 5, 2017 •
edited

@bors retry

  • odd timeouts building LLVM?
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2017

⌛️ Testing commit 7dcacf1 with merge ea2d41e...

bors added a commit that referenced this pull request Jan 5, 2017

@bors
Auto merge of #38817 - jseyfried:improve_unused_qualification_lint, r… 
…=petrochenkov

resolve: don't `unused_qualifications`-check global paths

We started `unused_qualifications`-checking global paths in #38014, causing #38682.
Fixes #38682.
r? @nrc
Loading status checks…
ea2d41e
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing ea2d41e to master...

@bors bors merged commit 7dcacf1 into rust-lang:master Jan 5, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@nikomatsakis nikomatsakis referenced this pull request Jan 6, 2017

Merged

Beta backports #38872

10 of 17 tasks complete

@jseyfried jseyfried deleted the jseyfried:improve_unused_qualification_lint branch Jan 6, 2017

@alexcrichton alexcrichton referenced this pull request Jan 7, 2017

Merged

Backport "don't `unused_qualifications`-check global paths" #38893

@alexcrichton alexcrichton removed the beta-nominated label Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.