Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #38960 to beta #39008

Merged
merged 1 commit into from Jan 12, 2017

Conversation

Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@cuviper @rust-highfive @alexcrichton @nrc @arielb1
@cuviper
Copy link
Member

cuviper commented Jan 12, 2017

This is a simple cherry-pick of commit a89475d from #38960.
@arielb1 @cuviper
Use little-endian encoding for Blake2 hashing on all architectures 
Like many hash functions, the blake2 hash is mathematically defined on
a sequence of 64-bit words. As Rust's hash interface operates on
sequences of octets, some encoding must be used to bridge that
difference.

The Blake2 RFC (RFC 7693) specifies that:
   Byte (octet) streams are interpreted as words in little-endian order,
   with the least-significant byte first.

So use that encoding consistently.

Fixes #38891.
Loading status checks…
f3639ac

@rust-highfive rust-highfive assigned nrc Jan 12, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jan 12, 2017

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)
@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jan 12, 2017

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@alexcrichton alexcrichton merged commit dc4f0e8 into rust-lang:beta Jan 12, 2017
1 check was pending

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jan 12, 2017

Thanks!

@cuviper cuviper deleted the cuviper:beta-blake-endian branch Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.