only consider value items when searching for methods, not types

[nikomatsakis]

Fixes #38919

r? @eddyb

[petrochenkov]

Fixes #38145 as well

[eddyb]

@bors r+

[bors]

📌 Commit 8848c38 has been approved by eddyb

[nikomatsakis]

@bors r-

Travis...seems unhappy. I'll investigate.

[brson]

@nikomatsakis Time is getting short to backport this.

[nikomatsakis]

@brson let's see if travis is happy, but I think it's fixed now

[nikomatsakis]

So for some reason this particular example, now that it doesn't ICE, triggers an odd path where we try to cite some code from libstd:

note: candidate #1 is defined in the trait `std::iter::Iterator`
  --> src/libcore/iter/iterator.rs:34:5
   |
34 |
   |     ^^^^^^^^^^
   = help: items from traits can only be used if the trait is implemented and in scope; the following traits define an item `Item`, perhaps you need to implement one of them:
   = help: candidate #1: `std::iter::Iterator`
   = help: candidate #2: `std::iter::IntoIterator`
   = help: candidate #3: `std::iter::ZipImpl`
   = help: candidate #4: `core::slice::SliceExt`

(See the snippet for candidate #1)

I don't quite follow what's happening there, but it seems like a pre-existing bug?

[nikomatsakis]

@bors r=eddyb p=1

• Beta backport

[bors]

📌 Commit d82d4b6 has been approved by eddyb

[nikomatsakis]

Accepting for beta backport (tiny patch, regression).

cc @rust-lang/compiler

[bors]

⌛️ Testing commit d82d4b6 with merge be1daa4...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing be1daa4 to master...