Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide uninhabitedness checks behind feature gate #39290

Merged
merged 1 commit into from Jan 28, 2017

Conversation

Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@canndrew @rust-highfive @nikomatsakis @bors @eddyb
@canndrew
Copy link
Contributor

canndrew commented Jan 25, 2017

This reverts the fix to match exhaustiveness checking so that it can be discussed. The new code is now hidden behind the never_type feature gate.

@rust-highfive rust-highfive assigned eddyb Jan 25, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jan 25, 2017

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)
@canndrew

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

canndrew commented Jan 25, 2017

cc @nikomatsakis
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Jan 25, 2017

@bors r+

Thanks @canndrew !
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jan 25, 2017

📌 Commit 2b7a23e has been approved by nikomatsakis

This was referenced Jan 26, 2017

Closed
Closed

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 27, 2017

@alexcrichton
Rollup merge of rust-lang#39290 - canndrew:hide-uninhabitedness, r=ni… 
…komatsakis

Hide uninhabitedness checks behind feature gate

This reverts the fix to match exhaustiveness checking so that it can be discussed. The new code is now hidden behind the `never_type` feature gate.
e1c274a

@alexcrichton alexcrichton referenced this pull request Jan 27, 2017

Merged

Rollup of 21 pull requests #39353

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 28, 2017

@alexcrichton
Rollup merge of rust-lang#39290 - canndrew:hide-uninhabitedness, r=ni… 
…komatsakis

Hide uninhabitedness checks behind feature gate

This reverts the fix to match exhaustiveness checking so that it can be discussed. The new code is now hidden behind the `never_type` feature gate.
0e64d49

bors added a commit that referenced this pull request Jan 28, 2017

@bors
Auto merge of #39353 - alexcrichton:rollup, r=alexcrichton 
Rollup of 21 pull requests

- Successful merges: #38617, #39284, #39285, #39290, #39302, #39305, #39306, #39307, #39311, #39313, #39314, #39321, #39325, #39332, #39335, #39344, #39345, #39346, #39348, #39350, #39351
- Failed merges:
Loading status checks…
7cc0c00

bors added a commit that referenced this pull request Jan 28, 2017

@bors
Auto merge of #39353 - alexcrichton:rollup, r=alexcrichton 
Rollup of 21 pull requests

- Successful merges: #38617, #39284, #39285, #39290, #39302, #39305, #39306, #39307, #39311, #39313, #39314, #39321, #39325, #39332, #39335, #39344, #39345, #39346, #39348, #39350, #39351
- Failed merges:
Loading status checks…
0f8a296

@bors bors merged commit 2b7a23e into rust-lang:master Jan 28, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.