Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for test suites emulated in QEMU #39400
This commit adds support to the build system to execute test suites that cannot
In general the architecture is to have a server running inside of the emulator
I believe this is ready to land in the sense that tests should pass as-is, but I think we should discuss a bit before landing this. For example I think we should answer questions like:
Curious to hear others' thoughts!
referenced this pull request
Jan 29, 2017
Yeah definitely! If I could I'd add a QEMU-emulated builder for basically every platform we support. It's not just a question of desires thought, but also:
We're running quite close to capacity and it took quite awhile to get this image going, so we probably can't add just everything yet. This is what I meant above with (5) of whether we want to add this target, or perhaps another as CI. (e.g. which we'll get the most mileage out of if we're resource constrained)
Yeah, I get the resource constraints. It's nice that there's still a little headroom.
I suggest some big-endian testing because this is a common case where code that otherwise appears platform independent may actually have portability issues. So adding any BE platform to the mix will improve coverage for all of them. In
@bors r+ Looks awesome.
Long-term it would be better if all this logic was in cargo-cross or some other tool that others can benefit from.
I would not say this automatically makes the platform tier 1. We can have coverage even without offering guarantees. I would like to rework our tier system slightly to decouple from our CI setup - just because we add tests shouldn't mean a platform is automatically in a different support tier.