New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] std: Fix IntoIter::as_mut_slice's signature #39493

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
4 participants
@alexcrichton
Member

alexcrichton commented Feb 3, 2017

This is a backport of #39466 to beta

std: Fix IntoIter::as_mut_slice's signature
This was intended to require `&mut self`, not `&self`, otherwise it's unsound!

Closes #39465
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Feb 3, 2017

Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Feb 3, 2017

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Feb 3, 2017

Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
Collaborator

rust-highfive commented Feb 3, 2017

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
@aturon

This comment has been minimized.

Show comment
Hide comment
@aturon

aturon Feb 3, 2017

Member

LGTM. I forget, for beta do we just merge directly?

Member

aturon commented Feb 3, 2017

LGTM. I forget, for beta do we just merge directly?

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Feb 3, 2017

Member

@aturon nowadays we can just r+!

Member

alexcrichton commented Feb 3, 2017

@aturon nowadays we can just r+!

@aturon

This comment has been minimized.

Show comment
Hide comment
@aturon

aturon Feb 3, 2017

Member

@bors: r+

Member

aturon commented Feb 3, 2017

@bors: r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 3, 2017

Contributor

📌 Commit 2a935f5 has been approved by aturon

Contributor

bors commented Feb 3, 2017

📌 Commit 2a935f5 has been approved by aturon

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Feb 4, 2017

Member

@bors: p=1

(PR against beta branch)

Member

alexcrichton commented Feb 4, 2017

@bors: p=1

(PR against beta branch)

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 5, 2017

Contributor

⌛️ Testing commit 2a935f5 with merge 64add42...

Contributor

bors commented Feb 5, 2017

⌛️ Testing commit 2a935f5 with merge 64add42...

bors added a commit that referenced this pull request Feb 5, 2017

Auto merge of #39493 - alexcrichton:beta-next, r=aturon
[beta] std: Fix IntoIter::as_mut_slice's signature

This is a backport of #39466 to beta
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Feb 5, 2017

Member

@bors: r-

This is gonna fail on beta, need to send another PR

Member

alexcrichton commented Feb 5, 2017

@bors: r-

This is gonna fail on beta, need to send another PR

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 5, 2017

Contributor

💔 Test failed - status-travis

Contributor

bors commented Feb 5, 2017

💔 Test failed - status-travis

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Feb 6, 2017

@bors: retry

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Feb 6, 2017

Member

@bors: r=aturon

Member

alexcrichton commented Feb 6, 2017

@bors: r=aturon

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 6, 2017

Contributor

📌 Commit 2a935f5 has been approved by aturon

Contributor

bors commented Feb 6, 2017

📌 Commit 2a935f5 has been approved by aturon

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 6, 2017

Contributor

⌛️ Testing commit 2a935f5 with merge 90423c9...

Contributor

bors commented Feb 6, 2017

⌛️ Testing commit 2a935f5 with merge 90423c9...

bors added a commit that referenced this pull request Feb 6, 2017

Auto merge of #39493 - alexcrichton:beta-next, r=aturon
[beta] std: Fix IntoIter::as_mut_slice's signature

This is a backport of #39466 to beta
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 6, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 90423c9 to beta...

Contributor

bors commented Feb 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 90423c9 to beta...

@bors bors merged commit 2a935f5 into rust-lang:beta Feb 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment