Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[beta] std: Fix IntoIter::as_mut_slice's signature #39493
Conversation
rust-highfive
assigned
aturon
Feb 3, 2017
This comment has been minimized.
This comment has been minimized.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
LGTM. I forget, for beta do we just merge directly? |
This comment has been minimized.
This comment has been minimized.
|
@aturon nowadays we can just r+! |
This comment has been minimized.
This comment has been minimized.
|
@bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors: p=1 (PR against beta branch) |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Feb 5, 2017
This comment has been minimized.
This comment has been minimized.
|
@bors: r- This is gonna fail on beta, need to send another PR |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors: retry |
This comment has been minimized.
This comment has been minimized.
|
@bors: r=aturon |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Feb 6, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 2a935f5
into
rust-lang:beta
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedFeb 3, 2017
This is a backport of #39466 to beta