Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild std for sparc64-unknown-linux-gnu #39647
Conversation
rust-highfive
assigned
alexcrichton
Feb 8, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
Can you also update src/tools/build-manifest to include this target? Otherwise looks great! |
This comment has been minimized.
This comment has been minimized.
|
@alexcrichton Like so? |
This comment has been minimized.
This comment has been minimized.
|
I believe so! @bors: r+ |
This comment has been minimized.
This comment has been minimized.
|
|
jmesmon
referenced this pull request
Feb 8, 2017
Closed
Add sparc64-linux-gnu as a cross-compile target #39547
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 9, 2017
bors
added a commit
that referenced
this pull request
Feb 9, 2017
bors
merged commit 4997178
into
rust-lang:master
Feb 9, 2017
1 check passed
This comment has been minimized.
This comment has been minimized.
sunnystormy
commented
Feb 16, 2017
•
|
Don't mean to necro this, but if I were to use the Nightly version of Rust, would I have access to this feature? Also, how soon will this make it over to Stable? Thanks! |
This comment has been minimized.
This comment has been minimized.
|
@sunnystormy you can access this right now via:
|
This comment has been minimized.
This comment has been minimized.
sunnystormy
commented
Feb 16, 2017
|
@alexcrichton Thank you, sir! Works like a charm. |
japaric commentedFeb 8, 2017
r? @alexcrichton
panicking / unwinding is broken (#39646) but with std available at least people
will be able to debug that issue on real hardware