Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] rustbuild: Pass -fPIC on 32-bit non-Windows platforms #39667

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alexcrichton @rust-highfive @brson @bors
@alexcrichton
Copy link
Member

alexcrichton commented Feb 9, 2017

This is a smaller and more targeted backport of #39523 which drives to the heart
of the issue, just passing -fPIC on 32-bit platforms. More rationale for this
commit can be found in #39523 itself.
@alexcrichton
rustbuild: Pass -fPIC on 32-bit non-Windows platforms 
This is a smaller and more targeted backport of #39523 which drives to the heart
of the issue, just passing `-fPIC` on 32-bit platforms. More rationale for this
commit can be found in #39523 itself.
Loading status checks…
1784a1a

@rust-highfive rust-highfive assigned brson Feb 9, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Feb 9, 2017

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Feb 9, 2017

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@alexcrichton alexcrichton changed the title rustbuild: Pass -fPIC on 32-bit non-Windows platforms [beta] rustbuild: Pass -fPIC on 32-bit non-Windows platforms Feb 9, 2017

@alexcrichton alexcrichton referenced this pull request Feb 9, 2017

Merged

Pass -fPIC to native compiles on 32-bit #39523

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Feb 9, 2017

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 9, 2017

📌 Commit 1784a1a has been approved by brson
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Feb 9, 2017

@bors: p=100

@alexcrichton alexcrichton referenced this pull request Feb 9, 2017

Merged

[stable] More fixes for 1.15.1 #39668

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 9, 2017

⌛️ Testing commit 1784a1a with merge 7c4cb50...

bors added a commit that referenced this pull request Feb 9, 2017

@bors
Auto merge of #39667 - alexcrichton:beta-next, r=brson 
[beta] rustbuild: Pass -fPIC on 32-bit non-Windows platforms

This is a smaller and more targeted backport of #39523 which drives to the heart
of the issue, just passing `-fPIC` on 32-bit platforms. More rationale for this
commit can be found in #39523 itself.
Loading status checks…
7c4cb50
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 7c4cb50 to beta...

@bors bors merged commit 1784a1a into rust-lang:beta Feb 9, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.