New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] rustbuild: Pass -fPIC on 32-bit non-Windows platforms #39667

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
4 participants
@alexcrichton
Member

alexcrichton commented Feb 9, 2017

This is a smaller and more targeted backport of #39523 which drives to the heart
of the issue, just passing -fPIC on 32-bit platforms. More rationale for this
commit can be found in #39523 itself.

rustbuild: Pass -fPIC on 32-bit non-Windows platforms
This is a smaller and more targeted backport of #39523 which drives to the heart
of the issue, just passing `-fPIC` on 32-bit platforms. More rationale for this
commit can be found in #39523 itself.
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Feb 9, 2017

Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Feb 9, 2017

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Feb 9, 2017

Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
Collaborator

rust-highfive commented Feb 9, 2017

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@alexcrichton alexcrichton changed the title from rustbuild: Pass -fPIC on 32-bit non-Windows platforms to [beta] rustbuild: Pass -fPIC on 32-bit non-Windows platforms Feb 9, 2017

@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Feb 9, 2017

Contributor

@bors r+

Contributor

brson commented Feb 9, 2017

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 9, 2017

Contributor

📌 Commit 1784a1a has been approved by brson

Contributor

bors commented Feb 9, 2017

📌 Commit 1784a1a has been approved by brson

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton
Member

alexcrichton commented Feb 9, 2017

@bors: p=100

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 9, 2017

Contributor

⌛️ Testing commit 1784a1a with merge 7c4cb50...

Contributor

bors commented Feb 9, 2017

⌛️ Testing commit 1784a1a with merge 7c4cb50...

bors added a commit that referenced this pull request Feb 9, 2017

Auto merge of #39667 - alexcrichton:beta-next, r=brson
[beta] rustbuild: Pass -fPIC on 32-bit non-Windows platforms

This is a smaller and more targeted backport of #39523 which drives to the heart
of the issue, just passing `-fPIC` on 32-bit platforms. More rationale for this
commit can be found in #39523 itself.
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Feb 9, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 7c4cb50 to beta...

Contributor

bors commented Feb 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 7c4cb50 to beta...

@bors bors merged commit 1784a1a into rust-lang:beta Feb 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment