Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uptravis: Add builders without assertions #39754
Conversation
rust-highfive
assigned
aturon
Feb 12, 2017
This comment has been minimized.
This comment has been minimized.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Would we prefer utilizing these for the perf infrastructure too? Or do assertions produce a relatively equivalent increase in compile time from commit to commit (and as such don't affect percentages)? |
This comment has been minimized.
This comment has been minimized.
|
Perhaps! I suspect it wouldn't matter too much though |
This comment has been minimized.
This comment has been minimized.
|
r? @brson Thanks for doing this, @alexcrichton! |
rust-highfive
assigned
brson
and unassigned
aturon
Feb 13, 2017
This comment has been minimized.
This comment has been minimized.
|
Thank you very much for doing this! It'll have a huge positive impact on both our staff and contributors on Servo. |
This comment has been minimized.
This comment has been minimized.
|
Yep, thanks everyone for this! (Sorry I'm too oldschool to just put a thumbsup emoji.) |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ It is a poor situation for us to be running 3 builders to produce builds just for servo, and I will be looking for alternatives. |
This comment has been minimized.
This comment has been minimized.
|
|
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 14, 2017
bors
added a commit
that referenced
this pull request
Feb 14, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 14, 2017
bors
added a commit
that referenced
this pull request
Feb 14, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 14, 2017
bors
added a commit
that referenced
this pull request
Feb 14, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 14, 2017
bors
added a commit
that referenced
this pull request
Feb 14, 2017
This comment has been minimized.
This comment has been minimized.
Is Servo really the only project that runs on Nigthly and wants better compile times? |
bors
added a commit
that referenced
this pull request
Feb 14, 2017
bors
added a commit
that referenced
this pull request
Feb 14, 2017
bors
merged commit 0340dde
into
rust-lang:master
Feb 15, 2017
1 check passed
alexcrichton
deleted the
alexcrichton:less-assertions
branch
Feb 15, 2017
This comment has been minimized.
This comment has been minimized.
|
For posterity, these are the builds that are uploaded on each commit now:
There are other components and such (and alternate installers) but those are probably the ones you're interested in. |
This comment has been minimized.
This comment has been minimized.
Likely not, but to make these more readily available we'd need to adapt rustup, which would require significantly more work -- and we'd also like to keep as much of the nightly ecosystem as we can with assertions on, as they do catch bugs. I'll bring up to the core team tomorrow whether to consider making these available via rustup. |
This comment has been minimized.
This comment has been minimized.
|
I got some numbers: servo/servo#15559 (comment)
|
alexcrichton commentedFeb 12, 2017
This commit adds three new builders, one OSX, one Linux, and one MSVC, which
will produce "nightlies" with LLVM assertions disabled. Currently all nightly
releases have LLVM assertions enabled to catch bugs before they reach the
beta/stable channels. The beta/stable channels, however, do not have LLVM
assertions enabled.
Unfortunately though projects like Servo are stuck on nightlies for the near
future at least and are also suffering very long compile times. The purpose of
this commit is to provide artifacts to these projects which are not distributed
through normal channels (e.g. rustup) but are provided for developers to use
locally if need be.
Logistically these builds will all be uploaded to
rustc-builds-altinstead ofthe
rustc-buildsfolder of therust-lang-cibucket. These builds will staythere forever (until cleaned out if necessary) and there are no plans to
integrate this with rustup and/or the official release process.