Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the Unstable Book #39866

Merged
merged 6 commits into from Feb 23, 2017

Conversation

Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@steveklabnik @rust-highfive @alexcrichton @bors @frewsxcv
@steveklabnik
Copy link
Member

steveklabnik commented Feb 15, 2017 •
edited

Part of #39588

This isn't done yet. To do:

  • import the nightly book contents here
  • possibly write some more chapters

This will not be done before it lands; that's part of the whole unstable thing.
@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Feb 15, 2017

@steveklabnik: no appropriate reviewer found, use r? to override

@steveklabnik steveklabnik referenced this pull request Feb 15, 2017

Closed

Tracking issue for RFC 1828: Rust Bookshelf #39588

9 of 10 tasks complete
@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member Author

steveklabnik commented Feb 16, 2017

Okay, this is good to go. I think we should merge and then write more chapters; it's a neat way for people to contribute!

I'd like to hear @rust-lang/docs 's thoughts on this.

@steveklabnik steveklabnik force-pushed the steveklabnik:unstable-book branch 2 times, most recently from 0c87a0e to cc36ae0 Feb 16, 2017

@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member Author

steveklabnik commented Feb 20, 2017

Blocked on #39976

@steveklabnik steveklabnik force-pushed the steveklabnik:unstable-book branch from cc36ae0 to d2682e2 Feb 20, 2017

@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member Author

steveklabnik commented Feb 20, 2017

This and #39855 are inter-twined since they reference each other. Let's land #39855 first.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 21, 2017

@steveklabnik r=me on the technicals w/ rustbuild and such, I'll leave it up to you to run by @rust-lang/docs on the content

@steveklabnik steveklabnik force-pushed the steveklabnik:unstable-book branch from d2682e2 to 02ce0db Feb 21, 2017

@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member Author

steveklabnik commented Feb 21, 2017 •
edited

Now that #39855 is r+'d I've rebased this on top of it, and fixed things up.

r? @frewsxcv (you only need to review the last 6 commits, that is, 7e4b7a0 and forward. the rest are from the other PR, and should disappear once it merges)

@rust-highfive rust-highfive assigned frewsxcv Feb 21, 2017

steveklabnik added some commits Feb 15, 2017

@steveklabnik
Create "The Unstable Book" 
part of #39588
a1301c3
@steveklabnik
Import basic book contents
f16c48e
@steveklabnik
write intro
aba4bf6
@steveklabnik
TRPL Nightly -> Unstable Book 
Port the chapters from TRPL's "Nightly Rust" section to the Unstable
Book, and remove it from TRPL.
6fb2545
@steveklabnik
fix some links
5f325e9
@steveklabnik
get linkcheck clean
Loading status checks…
06e311b

@steveklabnik steveklabnik force-pushed the steveklabnik:unstable-book branch from 02ce0db to 06e311b Feb 22, 2017

@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member Author

steveklabnik commented Feb 22, 2017 •
edited

Yay! the preceding one passed. I've rebased those commits out.

There seems to be no opposition to landing this, and I'd like to before it gets out of date, so

@bors: r=alexcrichton p=1

(This only bumps it up one place in the queue but still)
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2017

📌 Commit 06e311b has been approved by alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #39812
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2017

📌 Commit 06e311b has been approved by alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2017

⌛️ Testing commit 06e311b with merge 1dff7f1...

bors added a commit that referenced this pull request Feb 22, 2017

@bors
Auto merge of #39866 - steveklabnik:unstable-book, r=alexcrichton 
Create the Unstable Book

Part of #39588

This isn't done yet. To do:

- [x] import the nightly book contents here
- [ ] possibly write some more chapters

This will _not_ be done before it lands; that's part of the whole unstable thing.
Loading status checks…
1dff7f1
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2017

💔 Test failed - status-travis
@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member Author

steveklabnik commented Feb 22, 2017 •
edited

@bors: retry

spurious failure https://travis-ci.org/rust-lang/rust/jobs/204048041#L4348 etc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2017

⌛️ Testing commit 06e311b with merge 2ef7eb0...

bors added a commit that referenced this pull request Feb 22, 2017

@bors
Auto merge of #39866 - steveklabnik:unstable-book, r=alexcrichton 
Create the Unstable Book

Part of #39588

This isn't done yet. To do:

- [x] import the nightly book contents here
- [ ] possibly write some more chapters

This will _not_ be done before it lands; that's part of the whole unstable thing.
Loading status checks…
2ef7eb0
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 22, 2017

@bors: retry

appveyor somehow missed this PR?
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2017

⌛️ Testing commit 06e311b with merge 54b5f03...

bors added a commit that referenced this pull request Feb 22, 2017

@bors
Auto merge of #39866 - steveklabnik:unstable-book, r=alexcrichton 
Create the Unstable Book

Part of #39588

This isn't done yet. To do:

- [x] import the nightly book contents here
- [ ] possibly write some more chapters

This will _not_ be done before it lands; that's part of the whole unstable thing.
Loading status checks…
54b5f03
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2017

💔 Test failed - status-travis
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Feb 22, 2017

@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member Author

steveklabnik commented Feb 22, 2017

@bors: p=11

this should have landed by now due to spurious failures but it still hasn't, I am unlikely to be able to monitor it tomorrow
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 22, 2017

⌛️ Testing commit 06e311b with merge bfe4597...

bors added a commit that referenced this pull request Feb 22, 2017

@bors
Auto merge of #39866 - steveklabnik:unstable-book, r=alexcrichton 
Create the Unstable Book

Part of #39588

This isn't done yet. To do:

- [x] import the nightly book contents here
- [ ] possibly write some more chapters

This will _not_ be done before it lands; that's part of the whole unstable thing.
Loading status checks…
bfe4597
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Feb 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bfe4597 to master...

@bors bors merged commit 06e311b into rust-lang:master Feb 23, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@steveklabnik steveklabnik deleted the steveklabnik:unstable-book branch Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.