Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate sccache binaries on CI #40084
Conversation
rust-highfive
assigned
aturon
Feb 24, 2017
This comment has been minimized.
This comment has been minimized.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ p=1 |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors force |
This comment has been minimized.
This comment has been minimized.
|
@bors p=30 |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Feb 24, 2017
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
|
Actually, looks like it exceeded the maximum run time on Travis. Not sure if retrying is going to help... |
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Feb 25, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit 255a874
into
rust-lang:master
Feb 25, 2017
alexcrichton
referenced this pull request
Feb 25, 2017
Closed
Wedged sccached timing out CI builds #39003
alexcrichton
deleted the
alexcrichton:update-sccache
branch
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedFeb 24, 2017
Currently CI builds can fail spuriously during the LLVM build (#39003). I
believe this is due to sccache, and I believe that in turn was due to the fact
that the sccache server used to just be a raw mio server. Historically raw mio
servers are quite complicated to get right, but this is why we built Tokio! The
sccache server has been migrated to Tokio which I suspect would fix any latent
issues.
I have no confirmation of this (never been able to reproduce the deadlock
locally), but my hunch is that updating sccache to the master branch will fix
the timeouts during the LLVM build.
The binaries previously came from Gecko's infrastructure, but I've built new
ones by hand for Win/Mac/Linux and uploaded them to our CI bucket.