Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow types passed to [] to coerce, like .index() #40166
Conversation
rust-highfive
assigned
eddyb
Mar 1, 2017
This comment has been minimized.
This comment has been minimized.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Huh, did this change at some point? I remember it checking the expression somewhere nested so this wouldn't work. Based on what I see, this looks good. r? @nikomatsakis (in case I'm missing anything) |
rust-highfive
assigned
nikomatsakis
and unassigned
eddyb
Mar 1, 2017
aidanhs
force-pushed the
aidanhs:aphs-index-coerce
branch
from
b1c5946
to
93ce74b
Mar 1, 2017
aidanhs
force-pushed the
aidanhs:aphs-index-coerce
branch
from
93ce74b
to
c58fff2
Mar 1, 2017
This comment has been minimized.
This comment has been minimized.
|
seems ok to me, nice :) |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 2, 2017
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 2, 2017
bors
added a commit
that referenced
this pull request
Mar 2, 2017
bors
merged commit c58fff2
into
rust-lang:master
Mar 2, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
aidanhs
deleted the
aidanhs:aphs-index-coerce
branch
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
aidanhs commentedMar 1, 2017
Fixes #40085
Basically steals the relevant part of check_argument_types.