Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String docs: Add "the" #40169

Merged
merged 1 commit into from Mar 2, 2017
Merged

String docs: Add "the" #40169

merged 1 commit into from Mar 2, 2017

Conversation

MajorBreakfast
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

This works either way, but I'm happy to take this. Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 1, 2017

📌 Commit 74b6221 has been approved by steveklabnik

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 2, 2017
@GuillaumeGomez
Rollup merge of rust-lang#40169 - MajorBreakfast:patch-8, r=steveklabnik
216a0ea 
String docs: Add "the"

r? @steveklabnik
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 2, 2017
Merged
bors added a commit that referenced this pull request Mar 2, 2017
@bors
Auto merge of #40206 - GuillaumeGomez:rollup, r=GuillaumeGomez
8ae411e 
Rollup of 9 pull requests

- Successful merges: #40081, #40144, #40168, #40169, #40170, #40173, #40175, #40191, #40194
- Failed merges:
@bors bors merged commit 74b6221 into rust-lang:master Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MajorBreakfast @rust-highfive @steveklabnik @bors