Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put Cargo into the rustc workspace #40297

Merged
merged 1 commit into from Mar 11, 2017

Conversation

Reviewers

@brson brson

Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @brson @bors @nikomatsakis
@alexcrichton
Copy link
Member

alexcrichton commented Mar 6, 2017 •
edited

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the cargo submodule has been moved to a new vendor
directory to ensure it's outside the scope of src/Cargo.toml as a workspace.

Closes #40284

@rust-highfive rust-highfive assigned nikomatsakis Mar 6, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 6, 2017

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned nikomatsakis Mar 6, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Mar 6, 2017

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

This was referenced Mar 6, 2017

Merged
Closed
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Mar 6, 2017 •
edited

This likes like it's putting a submodule into src/vendor, which does not seem like a suitable place for submodules. Why src/vendor? Isn't this where the vendored sources live?
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 6, 2017

Ah yeah unfortunately src/vendor won't work b/c it's hierarchically below src/Cargo.toml, which means it still tries to be part of the workspace.

I could send a commit to Cargo with [workspace] which I believe will disable this though, if you'd prefer. I thought though at some point we were gonna try and wrangle all our third-party deps in vendor/*, although I may be misremembering.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Mar 6, 2017

If the options are putting this in src/vendor or giving cargo its own workspace I prefer the latter. We wouldn't put all the other submodules into src/vendor, or the other tools, I think - istm src/vendor is purely for incidental dependencies, not for the actual tools that are part of Rust.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 7, 2017

Unfortunately I can't give Cargo it's own workspace due to CI errors caused by existing bugs in Cargo.

That to me means the only solution is to put Cargo in some external directory for now. I hope to fix rust-lang/cargo#3192 soon though which I believe should allow us to get the "ideal" hierarchy in the future.

@brson how do you feel about vendor (not src/vendor, just vendor) in the meantime?

@alexcrichton alexcrichton force-pushed the alexcrichton:fix-submodules branch from 44d84f3 to a40e673 Mar 7, 2017

@brson

brson reviewed Mar 7, 2017
View changes

src/bootstrap/step.rs Outdated
@@ -559,7 +559,7 @@ pub fn build_rules<'a>(build: &'a Build) -> Rules {
rules.build("tool-qemu-test-client", "src/tools/qemu-test-client")
.dep(|s| s.name("libstd"))
.run(move |s| compile::tool(build, s.stage, s.target, "qemu-test-client"));
rules.build("tool-cargo", "src/tools/cargo")
rules.build("tool-cargo", "vendor/cargo")

This comment has been minimized.

Sign in to view
Copy link
@brson

brson Mar 7, 2017

Contributor

Do you really mean "vendor/" here?
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Mar 7, 2017

r=me with comment addressed

@alexcrichton alexcrichton force-pushed the alexcrichton:fix-submodules branch from a40e673 to b75116d Mar 7, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 7, 2017

@bors: r=brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 7, 2017

📌 Commit b75116d has been approved by brson
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 7, 2017

For posterity, we decided to put cargo into a top-level dir for now. That's not scalable but we'll fix the bug in Cargo soon which prevents Cargo from going into a "proper" location.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 9, 2017

🔒 Merge conflict
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 9, 2017

@bors: retry

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 9, 2017

@frewsxcv
Rollup merge of rust-lang#40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes rust-lang#40284
b9d8ce1

@frewsxcv frewsxcv referenced this pull request Mar 9, 2017

Closed

Rollup of 11 pull requests #40397

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 9, 2017

@bors: p=1

We're not getting nightlies because of this
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 10, 2017

🔒 Merge conflict

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes rust-lang#40284
7b14732

@arielb1 arielb1 referenced this pull request Mar 10, 2017

Closed

Rollup of 16 pull requests #40414

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes rust-lang#40284
7f59aed

@arielb1 arielb1 referenced this pull request Mar 10, 2017

Closed

Rollup of 16 pull requests #40415

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 10, 2017

@bors: retry

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017

@alexcrichton
Rollup merge of rust-lang#40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes rust-lang#40284
2f6d1de

bors added a commit that referenced this pull request Mar 10, 2017

@bors
Auto merge of #40420 - alexcrichton:rollup, r=alexcrichton 
Rollup of 35 pull requests

- Successful merges: #39202, #39648, #39770, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40277, #40278, #40287, #40297, #40308, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40386, #40389, #40400, #40404
- Failed merges: #39987, #40220, #40261, #40329
Loading status checks…
4a77ed5

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes rust-lang#40284
699ec59

@arielb1 arielb1 referenced this pull request Mar 10, 2017

Closed

Rollup of 24 pull requests #40427

bors added a commit that referenced this pull request Mar 10, 2017

@bors
Auto merge of #40427 - arielb1:rollup, r=arielb1 
Rollup of 24 pull requests

- Successful merges: #39202, #39820, #40092, #40146, #40199, #40225, #40239, #40259, #40278, #40287, #40297, #40319, #40324, #40345, #40372, #40373, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423
- Failed merges: #40426
Loading status checks…
f311749

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017

Ariel Ben-Yehuda
Rollup merge of rust-lang#40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes rust-lang#40284
36e263d

@arielb1 arielb1 referenced this pull request Mar 10, 2017

Closed

Rollup of 29 pull requests #40429

bors added a commit that referenced this pull request Mar 10, 2017

@bors
Auto merge of #40429 - arielb1:rollup, r=arielb1 
Rollup of 29 pull requests

- Successful merges: #39202, #39820, #40092, #40146, #40199, #40225, #40239, #40259, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40340, #40344, #40345, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423
- Failed merges:
Loading status checks…
1a7726e

bors added a commit that referenced this pull request Mar 10, 2017

@bors
Auto merge of #40429 - arielb1:rollup, r=arielb1 
Rollup of 29 pull requests

- Successful merges: #39202, #39820, #40092, #40146, #40199, #40225, #40239, #40259, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40340, #40344, #40345, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423
- Failed merges:
Loading status checks…
93b05f3
@alexcrichton
Don't put Cargo into the rustc workspace 
This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to the top
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.
Loading status checks…
c65996e

@alexcrichton alexcrichton force-pushed the alexcrichton:fix-submodules branch from 7688222 to c65996e Mar 10, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 10, 2017

@bors: r=brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 10, 2017

📌 Commit c65996e has been approved by brson

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017

@alexcrichton
Rollup merge of rust-lang#40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes rust-lang#40284
1844a76

@alexcrichton alexcrichton referenced this pull request Mar 10, 2017

Merged

Rollup of 38 pull requests #40432

bors added a commit that referenced this pull request Mar 10, 2017

@bors
Auto merge of #40432 - alexcrichton:rollup, r=alexcrichton 
Rollup of 38 pull requests

- Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424
- Failed merges: #40220, #40329, #40426
Loading status checks…
b099afb

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017

@alexcrichton
Rollup merge of rust-lang#40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes rust-lang#40284
ac1bbf7

bors added a commit that referenced this pull request Mar 11, 2017

@bors
Auto merge of #40432 - alexcrichton:rollup, r=alexcrichton 
Rollup of 38 pull requests

- Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424
- Failed merges: #40220, #40329, #40426
Loading status checks…
764c006

bors added a commit that referenced this pull request Mar 11, 2017

@bors
Auto merge of #40432 - alexcrichton:rollup, r=alexcrichton 
Rollup of 38 pull requests

- Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424
- Failed merges: #40220, #40329, #40426
Loading status checks…
dd5e3cd
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 11, 2017

⌛️ Testing commit c65996e with merge ee972fd...

bors added a commit that referenced this pull request Mar 11, 2017

@bors
Auto merge of #40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes #40284
Loading status checks…
ee972fd
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 11, 2017

@bors: retry

bors added a commit that referenced this pull request Mar 11, 2017

@bors
Auto merge of #40432 - alexcrichton:rollup, r=alexcrichton 
Rollup of 38 pull requests

- Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424
- Failed merges: #40220, #40329, #40426
Loading status checks…
6466f85
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 11, 2017

⌛️ Testing commit c65996e with merge 3070712...

bors added a commit that referenced this pull request Mar 11, 2017

@bors
Auto merge of #40297 - alexcrichton:fix-submodules, r=brson 
Don't put Cargo into the rustc workspace

This causes problems when first cloning and bootstrapping the repository
unfortunately, so let's ensure that Cargo sticks around in its own workspace.
Because Cargo is a submodule it's not available by default on the inital clone
of the rust-lang/rust repository. Normally it's the responsibility of the
rustbuild to take care of this, but unfortunately to build rustbuild itself we
need to resolve the workspace conflicts.

To deal with this we'll just have to ensure that all submodules are in their own
workspace, which sort of makes sense anyway as updates to dependencies as
bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any
case this commit removes Cargo from the global workspace which should resolve
the issues that we've been seeing.

To actually perform this the `cargo` submodule has been moved to a new `vendor`
directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.

Closes #40284
Loading status checks…
3070712
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 11, 2017

@bors: retry

bors added a commit that referenced this pull request Mar 11, 2017

@bors
Auto merge of #40432 - alexcrichton:rollup, r=alexcrichton 
Rollup of 38 pull requests

- Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424
- Failed merges: #40220, #40329, #40426
Loading status checks…
1727b23
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 11, 2017

⌛️ Testing commit c65996e with merge 1727b23...

@bors bors merged commit c65996e into rust-lang:master Mar 11, 2017
1 of 2 checks passed

1 of 2 checks passed

homu Testing commit c65996e with merge 1727b23...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexcrichton alexcrichton deleted the alexcrichton:fix-submodules branch Mar 11, 2017

@Ran4 Ran4 referenced this pull request Mar 11, 2018

Closed

Build breaks due to missing rustorm/dao/Cargo.toml #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.