Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcc used for dist-x86-linux builds #40617

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@TimNN @alexcrichton @bors @ishitatsuyuki @cuviper
@TimNN
Copy link
Contributor

TimNN commented Mar 17, 2017

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).

@rust-highfive rust-highfive assigned alexcrichton Mar 17, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 17, 2017

r=me when it's green
@TimNN

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

TimNN commented Mar 18, 2017

The build was killed during openssl install, that didn't reproduce locally so I have restarted the travis build.
@TimNN

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

TimNN commented Mar 18, 2017

The build timed out again.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 19, 2017

That looks like it got plenty far enough though to verify this works, want to send it to bors?

@TimNN TimNN force-pushed the TimNN:dist-update-gcc branch from f9b31bf to 09d12d0 Mar 19, 2017

@TimNN

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

TimNN commented Mar 19, 2017

@alexcrichton: Sure, I removed the test commit.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 19, 2017

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 19, 2017

📌 Commit 09d12d0 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 19, 2017

@frewsxcv
Rollup merge of rust-lang#40617 - TimNN:dist-update-gcc, r=alexcrichton 
Update gcc used for dist-x86-linux builds

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
Loading status checks…
eab49b8

@frewsxcv frewsxcv referenced this pull request Mar 19, 2017

Closed

Rollup of 8 pull requests #40656

bors added a commit that referenced this pull request Mar 19, 2017

@bors
Auto merge of #40656 - frewsxcv:rollup, r=frewsxcv 
Rollup of 8 pull requests

- Successful merges: #40241, #40281, #40523, #40532, #40566, #40587, #40617, #40620
- Failed merges:
Loading status checks…
cf61542
@ishitatsuyuki

This comment has been minimized.

Sign in to view
Copy link
Member

ishitatsuyuki commented Mar 20, 2017

The base, CentOS 5 is about to expire; why not just upgrade to a decent distro?

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 20, 2017

@frewsxcv
Rollup merge of rust-lang#40617 - TimNN:dist-update-gcc, r=alexcrichton 
Update gcc used for dist-x86-linux builds

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
Loading status checks…
da08827

@frewsxcv frewsxcv referenced this pull request Mar 20, 2017

Closed

Rollup of 6 pull requests #40669

bors added a commit that referenced this pull request Mar 20, 2017

@bors
Auto merge of #40669 - frewsxcv:rollup, r=frewsxcv 
Rollup of 6 pull requests

- Successful merges: #40377, #40509, #40518, #40523, #40617, #40667
- Failed merges:
Loading status checks…
1d90ca6
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 21, 2017

🔒 Merge conflict

@TimNN TimNN force-pushed the TimNN:dist-update-gcc branch from 09d12d0 to 88d5645 Mar 21, 2017

@TimNN

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

TimNN commented Mar 21, 2017

rebased
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 21, 2017

@bors: r+

(feel free to @bors: r=alexcrichton whenever you rebase)
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit 88d5645 has been approved by `alexcrichton``
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit 88d5645 has been approved by alexcrichton
@TimNN

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

TimNN commented Mar 21, 2017

@alexcrichton: I don't think I have bors rights, so bors: r=alexcrichton wouldn't work, right?
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 21, 2017

Whoa sorry I had no idea!

Now you've got r+ :)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Mar 21, 2017

or rather, after I deploy that
@TimNN

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

TimNN commented Mar 21, 2017

@alexcrichton: Thanks!
@cuviper

This comment has been minimized.

Sign in to view
Copy link
Member

cuviper commented Mar 21, 2017

The base, CentOS 5 is about to expire; why not just upgrade to a decent distro?

Let's leave out subjective assessments of what's "decent" please. It matters to keep the base OS old for maximum ABI compatibility, so when we do move, the next logical choice would be CentOS 6.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 22, 2017

@frewsxcv
Rollup merge of rust-lang#40617 - TimNN:dist-update-gcc, r=alexcrichton 
Update gcc used for dist-x86-linux builds

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
Loading status checks…
c5f3bf1

@frewsxcv frewsxcv referenced this pull request Mar 22, 2017

Closed

Rollup of 8 pull requests #40726

bors added a commit that referenced this pull request Mar 22, 2017

@bors
Auto merge of #40726 - frewsxcv:rollup, r=frewsxcv 
Rollup of 8 pull requests

- Successful merges: #40509, #40515, #40523, #40617, #40619, #40689, #40690, #40692
- Failed merges:
Loading status checks…
21dc6b8

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 23, 2017

@frewsxcv
Rollup merge of rust-lang#40617 - TimNN:dist-update-gcc, r=alexcrichton 
Update gcc used for dist-x86-linux builds

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
Loading status checks…
a419ce9

@frewsxcv frewsxcv referenced this pull request Mar 23, 2017

Merged

Rollup of 6 pull requests #40752

bors added a commit that referenced this pull request Mar 23, 2017

@bors
Auto merge of #40752 - frewsxcv:rollup, r=frewsxcv 
Rollup of 6 pull requests

- Successful merges: #39891, #40518, #40542, #40617, #40678, #40696
- Failed merges:
Loading status checks…
7c7753d

@bors bors merged commit 88d5645 into rust-lang:master Mar 23, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@TimNN TimNN deleted the TimNN:dist-update-gcc branch Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.