Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updist-x86-linux: switch to CentOS 6 #40848
Conversation
rust-highfive
assigned
brson
Mar 27, 2017
This comment has been minimized.
This comment has been minimized.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
@ishitatsuyuki: To have travis test this, you can temporarily add Also, all the now unused shell scripts should probably be deleted. |
ishitatsuyuki
force-pushed the
ishitatsuyuki:x86-distro-upgrade
branch
from
d1f45ec
to
d0e1f63
Mar 27, 2017
TimNN
reviewed
Mar 27, 2017
| @@ -86,7 +46,7 @@ ENV RUST_CONFIGURE_ARGS \ | |||
| --host=$HOSTS \ | |||
| --enable-extended \ | |||
| --enable-sanitizers | |||
| ENV SCRIPT python2.7 ../x.py dist --host $HOSTS --target $HOSTS | |||
| ENV SCRIPT scl enable python27 devtoolset-6 python2.7 ../x.py dist --host $HOSTS --target $HOSTS | |||
This comment has been minimized.
This comment has been minimized.
TimNN
Mar 27, 2017
Contributor
I'm not completely sure, but as I understand this scl enable sets up the environment to use the specified tools? In that case this may not work correctly since the ./configure script is ran outside of that environment, I think.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
cmake3 seems to be available in EPEL, will add it tomorrow. |
This comment has been minimized.
This comment has been minimized.
|
What is the motivation for doing this? Do we have active problems we need fixing with the centos 5 image? I'd ideally prefer to have strong motivation for raising our glibc requirement as that can have wide ramifications. |
alexcrichton
closed this
Mar 27, 2017
alexcrichton
reopened this
Mar 27, 2017
This comment has been minimized.
This comment has been minimized.
|
(oops didn't mean to close) |
This comment has been minimized.
This comment has been minimized.
|
My personal reason is distro expiry. You don't need to maintain binary compatibility for those unsupported distros, since it's possible to build from source. (I don't think a sysadmin can live without SNI now) This doesn't break Ubuntu 12.04, so there's no concern of breaking the shitty Travis infrastructure. GCC 6 doesn't seem to perform super well than 4, but anyway I guess newer toolchains are better. |
This comment has been minimized.
This comment has been minimized.
This is not a reason to require a new glibc version out of the blue, is there a technical reason for this upgrade? |
This comment has been minimized.
This comment has been minimized.
|
This is a distro upgrade alongside with new backported toolchains (made possible with SCL in CentOS 6). We no longer need to hack from source for another LLVM requirement bump. CentOS 5 is about to expire. Debian 6 already expired. There's not so many concern of breakage, and we never need to support those EOL distros. (I have already mentioned that they can build things from source) If I'm correct, this will land 3 months later in stable. I believe it's an enough margin to upgrade. |
ishitatsuyuki
added some commits
Mar 27, 2017
ishitatsuyuki
force-pushed the
ishitatsuyuki:x86-distro-upgrade
branch
from
eaa723c
to
880c86a
Mar 27, 2017
This comment has been minimized.
This comment has been minimized.
Why? |
This comment has been minimized.
This comment has been minimized.
|
@sfackler whoever will run nightly(rustup) on CentOS 5? Anyway, I have already mentioned that they can compile everything by themselves. End of life is what devs can forget, we don't need to show effort to support them. |
This comment has been minimized.
This comment has been minimized.
|
Seems we need a multilib compiler. |
This comment has been minimized.
This comment has been minimized.
|
Abandoning due to no SCL for multilib. I choose continuing with existing infra. |
ishitatsuyuki
closed this
Mar 28, 2017
This comment has been minimized.
This comment has been minimized.
Note that building rustc from source still requires bootstrap binaries for stage0. If rust-lang.org's binaries stop supporting older glibc, then such users can't directly build from source either. They would have to go through the cross-compile steps from a system that does have the newer glibc to run stage0. |
ishitatsuyuki commentedMar 27, 2017
•
edited
This brings the modern toolchain into the build system and hopefully speeds up the things.
CentOS 5 (and Ubuntu 12.04) is about EOL, so let's switch a week before they expires.
glibc version watch:
DO NOT MERGE - Remove the testing commit before proceeding