Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Stabilize the `#![windows_subsystem]` attribute #40870

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@alexcrichton @rust-highfive @liigo @nrc @aturon @bors @frewsxcv
@alexcrichton
Copy link
Member

alexcrichton commented Mar 27, 2017

This commit stabilizes the #![windows_subsystem] attribute which is a
conservative exposure of the /SUBSYSTEM linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes #37499

@rust-highfive rust-highfive assigned nrc Mar 27, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Mar 27, 2017

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 27, 2017

Note that documentation, not currently present, was implemented in rust-lang-nursery/reference#16 and is being pulled in as part of #40864
@liigo

This comment has been minimized.

Sign in to view
Copy link
Contributor

liigo commented Mar 27, 2017

Should wait for open issue #37553 ?
@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Mar 28, 2017

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned nrc Mar 28, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 30, 2017

@nrc but I sent the PR :(

@liigo that would be a backwards compatible extension to the current attribute, so I don't see why it would block this.
@aturon

This comment has been minimized.

Sign in to view
Copy link
Member

aturon commented Mar 30, 2017

@bors: r+ rollup
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Mar 30, 2017

📌 Commit 20888b1 has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 30, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
acdbd21

@frewsxcv frewsxcv referenced this pull request Mar 30, 2017

Closed

Rollup of 7 pull requests #40930

bors added a commit that referenced this pull request Mar 30, 2017

@bors
Auto merge of #40930 - frewsxcv:rollup, r=frewsxcv 
Rollup of 7 pull requests

- Successful merges: #40524, #40541, #40694, #40842, #40870, #40904, #40925
- Failed merges:
Loading status checks…
2057bc4

bors added a commit that referenced this pull request Mar 30, 2017

@bors
Auto merge of #40930 - frewsxcv:rollup, r=frewsxcv 
Rollup of 7 pull requests

- Successful merges: #40524, #40541, #40694, #40842, #40870, #40904, #40925
- Failed merges:
Loading status checks…
ebcb2f0
@frewsxcv

This comment has been minimized.

Sign in to view
Copy link
Member

frewsxcv commented Mar 30, 2017

@bors r-

Any chance you could remove the relevant section from the Unstable Book?

If #40694 lands before this, you'll get a tidy error for this PR as is.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Mar 31, 2017

Certainly, I'll tackle that soon.
@alexcrichton
rustc: Stabilize the `#![windows_subsystem]` attribute 
This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes #37499
Loading status checks…
34cf288

@alexcrichton alexcrichton force-pushed the alexcrichton:stabilize-windows-subsystem branch from 20888b1 to 34cf288 Apr 1, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 1, 2017

@bors: r=aturon
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 1, 2017

📌 Commit 34cf288 has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 1, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
78fb328

@frewsxcv frewsxcv referenced this pull request Apr 1, 2017

Closed

Rollup of 5 pull requests #41002

bors added a commit that referenced this pull request Apr 1, 2017

@bors
Auto merge of #41002 - frewsxcv:rollup, r=frewsxcv 
Rollup of 5 pull requests

- Successful merges: #40870, #40908, #40909, #40927, #40992
- Failed merges:
Loading status checks…
6081e81

bors added a commit that referenced this pull request Apr 2, 2017

@bors
Auto merge of #41002 - frewsxcv:rollup, r=frewsxcv 
Rollup of 5 pull requests

- Successful merges: #40870, #40908, #40909, #40927, #40992
- Failed merges:
Loading status checks…
7bd187a

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
aaade9a

@frewsxcv frewsxcv referenced this pull request Apr 2, 2017

Closed

Rollup of 8 pull requests #41010

bors added a commit that referenced this pull request Apr 2, 2017

@bors
Auto merge of #41010 - frewsxcv:rollup, r=frewsxcv 
Rollup of 8 pull requests

- Successful merges: #40541, #40870, #40927, #40949, #40988, #40992, #40997, #41007
- Failed merges:
Loading status checks…
8340dde

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
69dfab8

@frewsxcv frewsxcv referenced this pull request Apr 2, 2017

Closed

Rollup of 6 pull requests #41017

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
a46a744

@frewsxcv frewsxcv referenced this pull request Apr 3, 2017

Closed

Rollup of 9 pull requests #41034

bors added a commit that referenced this pull request Apr 3, 2017

@bors
Auto merge of #41034 - frewsxcv:rollup, r=frewsxcv 
Rollup of 9 pull requests

- Successful merges: #40870, #40949, #40988, #40992, #40997, #40999, #41007, #41014, #41028
- Failed merges:
Loading status checks…
575a033

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
9fd0a18

@frewsxcv frewsxcv referenced this pull request Apr 3, 2017

Closed

Rollup of 13 pull requests #41040

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
3b1f3f0

@frewsxcv frewsxcv referenced this pull request Apr 3, 2017

Closed

Rollup of 12 pull requests #41041

bors added a commit that referenced this pull request Apr 3, 2017

@bors
Auto merge of #41041 - frewsxcv:rollup, r=frewsxcv 
Rollup of 12 pull requests

- Successful merges: #40608, #40870, #40927, #40949, #40977, #40988, #40992, #40997, #40999, #41007, #41014, #41035
- Failed merges:
Loading status checks…
cf3abc3

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
8aa3494

@frewsxcv frewsxcv referenced this pull request Apr 4, 2017

Closed

Rollup of 18 pull requests #41067

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
ae3ad90

@frewsxcv frewsxcv referenced this pull request Apr 4, 2017

Closed

Rollup of 17 pull requests #41068

bors added a commit that referenced this pull request Apr 4, 2017

@bors
Auto merge of #41068 - frewsxcv:rollup, r=frewsxcv 
Rollup of 17 pull requests

- Successful merges: #40097, #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:
Loading status checks…
8bfeee1

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
ef01347

@frewsxcv frewsxcv referenced this pull request Apr 4, 2017

Closed

Rollup of 16 pull requests #41070

bors added a commit that referenced this pull request Apr 4, 2017

@bors
Auto merge of #41070 - frewsxcv:rollup, r=frewsxcv 
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:
Loading status checks…
80f586b

bors added a commit that referenced this pull request Apr 4, 2017

@bors
Auto merge of #41070 - frewsxcv:rollup, r=frewsxcv 
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:
Loading status checks…
dacf247

bors added a commit that referenced this pull request Apr 4, 2017

@bors
Auto merge of #41070 - frewsxcv:rollup, r=frewsxcv 
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:
Loading status checks…
080c864

bors added a commit that referenced this pull request Apr 5, 2017

@bors
Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton 
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:
Loading status checks…
0a1c1ea

bors added a commit that referenced this pull request Apr 5, 2017

@bors
Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton 
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:
Loading status checks…
5993edd

bors added a commit that referenced this pull request Apr 5, 2017

@bors
Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton 
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:
Loading status checks…
adc3223

bors added a commit that referenced this pull request Apr 5, 2017

@bors
Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton 
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:
Loading status checks…
efd09b5

bors added a commit that referenced this pull request Apr 5, 2017

@bors
Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton 
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:
Loading status checks…
7d4704e

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
14a7dd4

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017

@frewsxcv
Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs… 
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499
Loading status checks…
0239880

@frewsxcv frewsxcv referenced this pull request Apr 5, 2017

Merged

Rollup of 19 pull requests #41086

bors added a commit that referenced this pull request Apr 5, 2017

@bors
Auto merge of #41086 - frewsxcv:rollup, r=frewsxcv 
Rollup of 19 pull requests

- Successful merges: #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049, #41062, #41066, #41076, #41085
- Failed merges:
Loading status checks…
46f71a0

@bors bors merged commit 34cf288 into rust-lang:master Apr 5, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexcrichton alexcrichton deleted the alexcrichton:stabilize-windows-subsystem branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.