Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Stabilize the `#![windows_subsystem]` attribute #40870

Merged
merged 1 commit into from Apr 5, 2017

Conversation

@alexcrichton
Copy link
Member

commented Mar 27, 2017

This commit stabilizes the #![windows_subsystem] attribute which is a
conservative exposure of the /SUBSYSTEM linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes #37499

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Mar 27, 2017

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member Author

commented Mar 27, 2017

Note that documentation, not currently present, was implemented in rust-lang-nursery/reference#16 and is being pulled in as part of #40864

@liigo

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2017

Should wait for open issue #37553 ?

@nrc

This comment has been minimized.

Copy link
Member

commented Mar 28, 2017

@rust-highfive rust-highfive assigned alexcrichton and unassigned nrc Mar 28, 2017

@alexcrichton

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2017

@nrc but I sent the PR :(

@liigo that would be a backwards compatible extension to the current attribute, so I don't see why it would block this.

@aturon

This comment has been minimized.

Copy link
Member

commented Mar 30, 2017

@bors: r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2017

📌 Commit 20888b1 has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 30, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

bors added a commit that referenced this pull request Mar 30, 2017

Auto merge of #40930 - frewsxcv:rollup, r=frewsxcv
Rollup of 7 pull requests

- Successful merges: #40524, #40541, #40694, #40842, #40870, #40904, #40925
- Failed merges:

bors added a commit that referenced this pull request Mar 30, 2017

Auto merge of #40930 - frewsxcv:rollup, r=frewsxcv
Rollup of 7 pull requests

- Successful merges: #40524, #40541, #40694, #40842, #40870, #40904, #40925
- Failed merges:
@frewsxcv

This comment has been minimized.

Copy link
Member

commented Mar 30, 2017

@bors r-

Any chance you could remove the relevant section from the Unstable Book?

If #40694 lands before this, you'll get a tidy error for this PR as is.

@alexcrichton

This comment has been minimized.

Copy link
Member Author

commented Mar 31, 2017

Certainly, I'll tackle that soon.

rustc: Stabilize the `#![windows_subsystem]` attribute
This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes #37499

@alexcrichton alexcrichton force-pushed the alexcrichton:stabilize-windows-subsystem branch from 20888b1 to 34cf288 Apr 1, 2017

@alexcrichton

This comment has been minimized.

Copy link
Member Author

commented Apr 1, 2017

@bors: r=aturon

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2017

📌 Commit 34cf288 has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 1, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

bors added a commit that referenced this pull request Apr 1, 2017

Auto merge of #41002 - frewsxcv:rollup, r=frewsxcv
Rollup of 5 pull requests

- Successful merges: #40870, #40908, #40909, #40927, #40992
- Failed merges:

bors added a commit that referenced this pull request Apr 2, 2017

Auto merge of #41002 - frewsxcv:rollup, r=frewsxcv
Rollup of 5 pull requests

- Successful merges: #40870, #40908, #40909, #40927, #40992
- Failed merges:

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

bors added a commit that referenced this pull request Apr 2, 2017

Auto merge of #41010 - frewsxcv:rollup, r=frewsxcv
Rollup of 8 pull requests

- Successful merges: #40541, #40870, #40927, #40949, #40988, #40992, #40997, #41007
- Failed merges:

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 2, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

bors added a commit that referenced this pull request Apr 3, 2017

Auto merge of #41034 - frewsxcv:rollup, r=frewsxcv
Rollup of 9 pull requests

- Successful merges: #40870, #40949, #40988, #40992, #40997, #40999, #41007, #41014, #41028
- Failed merges:

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 3, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

bors added a commit that referenced this pull request Apr 3, 2017

Auto merge of #41041 - frewsxcv:rollup, r=frewsxcv
Rollup of 12 pull requests

- Successful merges: #40608, #40870, #40927, #40949, #40977, #40988, #40992, #40997, #40999, #41007, #41014, #41035
- Failed merges:

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

bors added a commit that referenced this pull request Apr 4, 2017

Auto merge of #41068 - frewsxcv:rollup, r=frewsxcv
Rollup of 17 pull requests

- Successful merges: #40097, #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 4, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

bors added a commit that referenced this pull request Apr 4, 2017

Auto merge of #41070 - frewsxcv:rollup, r=frewsxcv
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:

bors added a commit that referenced this pull request Apr 4, 2017

Auto merge of #41070 - frewsxcv:rollup, r=frewsxcv
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:

bors added a commit that referenced this pull request Apr 4, 2017

Auto merge of #41070 - frewsxcv:rollup, r=frewsxcv
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:

bors added a commit that referenced this pull request Apr 5, 2017

Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:

bors added a commit that referenced this pull request Apr 5, 2017

Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:

bors added a commit that referenced this pull request Apr 5, 2017

Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:

bors added a commit that referenced this pull request Apr 5, 2017

Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:

bors added a commit that referenced this pull request Apr 5, 2017

Auto merge of #41070 - frewsxcv:rollup, r=alexcrichton
Rollup of 16 pull requests

- Successful merges: #40541, #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049
- Failed merges:

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 5, 2017

Rollup merge of rust-lang#40870 - alexcrichton:stabilize-windows-subs…
…ystem, r=aturon

rustc: Stabilize the `#![windows_subsystem]` attribute

This commit stabilizes the `#![windows_subsystem]` attribute which is a
conservative exposure of the `/SUBSYSTEM` linker flag on Widnows platforms. This
is useful for creating applications as well as console programs.

Closes rust-lang#37499

bors added a commit that referenced this pull request Apr 5, 2017

Auto merge of #41086 - frewsxcv:rollup, r=frewsxcv
Rollup of 19 pull requests

- Successful merges: #40608, #40870, #40949, #40977, #40981, #40988, #40992, #40997, #40999, #41007, #41014, #41019, #41035, #41043, #41049, #41062, #41066, #41076, #41085
- Failed merges:

@bors bors merged commit 34cf288 into rust-lang:master Apr 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexcrichton alexcrichton deleted the alexcrichton:stabilize-windows-subsystem branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.