Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes for 1.17 #41548

Merged
merged 1 commit into from May 10, 2017

Conversation

Reviewers

@kennytm kennytm

@kevinmehall kevinmehall

@SimonSapin SimonSapin

@arielb1 arielb1

@KiChjang KiChjang

@Mark-Simulacrum Mark-Simulacrum

Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-author beta-accepted
Projects
None yet
Milestone
No milestone
@brson
Copy link
Contributor

brson commented Apr 26, 2017

Rendered.

cc @steveklabnik

@rust-highfive rust-highfive assigned alexcrichton Apr 26, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Apr 26, 2017

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)
@KiChjang

KiChjang reviewed Apr 26, 2017
View changes

RELEASES.md Outdated
names][39761]. [RFC 1682]
* [`Self` may be included in the `where` clause of `impls`][38864]. [RFC 1647]
* [When coercing to an unsized type lifetimes must be equal][40319]. That is,
there is no subtypeing between `T` and `U` when `T: Unsize<U>`. For example,

This comment has been minimized.

Sign in to view
Copy link
@KiChjang

KiChjang Apr 26, 2017

Member

Typo: subtyping
@Mark-Simulacrum

Mark-Simulacrum reviewed Apr 26, 2017
View changes

RELEASES.md
* [`Cell::swap`]
* [`Cell::replace`]
* [`Cell::into_inner`]
* [`Cell::take`]

This comment has been minimized.

Sign in to view
Copy link
@Mark-Simulacrum

Mark-Simulacrum Apr 26, 2017

Member

I don't see Cell::swap, Cell::replace, Cell::into_inner, and Cell::take at all in the stable documentation. That's suspicious to me, since it feels like it was then stabilized within less than a cycle; perhaps unintentionally? I'm not sure. I don't know what the procedure around minor library stabilizations is, either. The other stabilized APIs are in the stable documentation, which is why I bring this up.

This comment has been minimized.

Sign in to view
Copy link
@kennytm

kennytm Apr 26, 2017 •
edited

Member

@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
@brson

brson Apr 26, 2017

Author Contributor

@Mark-Simulacrum afaict that is the case. These were stabilized within a single cycle.
@SimonSapin

SimonSapin reviewed Apr 26, 2017
View changes

RELEASES.md Outdated
existing code generally ignores the type of dead-code unless a type-hint is
provided; this can cause surprising inference interactions particularly around
defaulting. The new code uniformly ignores the result type of dead-code.
* [Tuple-structs with private fields are no longer visible][38932]

This comment has been minimized.

Sign in to view
Copy link
@SimonSapin

SimonSapin Apr 26, 2017

Contributor

Based on the linked PR it looks like only the constructors of such structs are private, the types are still public (assuming pub struct …)

This comment has been minimized.

Sign in to view
Copy link
@brson

brson Apr 26, 2017

Author Contributor

Yes, good catch.
@kevinmehall

kevinmehall reviewed Apr 26, 2017
View changes

RELEASES.md Outdated
* [Implement `PartialEq<[A]>` for `VecDeque<A>`][38661]
* [`HashMap` resizes adaptively][38368] to guard against DOS attacks
and poor hash functions.
* [Backtraces have nicer formatting][38165], skipping runtime-internal stack

This comment has been minimized.

Sign in to view
Copy link
@kevinmehall

kevinmehall Apr 26, 2017

Contributor

Wasn't the "skipping runtime-internal stack frames" part reverted?

This comment has been minimized.

Sign in to view
Copy link
@brson

brson Apr 26, 2017

Author Contributor

Seems like it.
@kevinmehall

kevinmehall reviewed Apr 26, 2017
View changes

RELEASES.md Outdated
* [Optimize vtable loads][39995]
* [Turn off vectorization for Emscripten targets][39990]
* [Provide suggestions for unknown macros imported with `use`][39953]
* [Fix ICES in path resolution][39939]

This comment has been minimized.

Sign in to view
Copy link
@kevinmehall

kevinmehall Apr 26, 2017

Contributor

ICES -> ICEs

@alexcrichton alexcrichton added beta-accepted beta-nominated labels Apr 26, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 26, 2017

r=me when this is good to go
@arielb1

arielb1 reviewed Apr 26, 2017
View changes

RELEASES.md Outdated
* [rustdoc: fix doctests with non-feature crate attributes][38161]
* [Make transmuting from fn item types to pointer-sized types a hard
error][34198]
* [Higher-ranked lifetimes may not appear solely in associated types][33685].

This comment has been minimized.

Sign in to view
Copy link
@arielb1

arielb1 Apr 26, 2017

Contributor

That's the same as #32330.

@aidanhs aidanhs added the S-waiting-on-author label Apr 26, 2017

@brson brson force-pushed the brson:relnotes branch from f41f151 to 6115993 Apr 26, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Apr 26, 2017

Updated.
@CryZe

This comment has been minimized.

Sign in to view
Copy link
Contributor

CryZe commented Apr 27, 2017

{Arc/Rc}::ptr_eq got stabilized with 1.17 too: https://doc.rust-lang.org/beta/std/rc/struct.Rc.html#method.ptr_eq
@brson
Update release notes for 1.17
Loading status checks…
8e97693

@brson brson force-pushed the brson:relnotes branch from 6115993 to 8e97693 Apr 27, 2017

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Apr 27, 2017

Thanks @CryZe. Updated.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented May 4, 2017

@brson was this waiting on anything else? Or is this ready to go?
@carols10cents

This comment has been minimized.

Sign in to view
Copy link
Member

carols10cents commented May 8, 2017

Hm one of the travis jobs is marked as cancelled after 45 min 32 sec? Is that a timeout? I'm retrying it within travis...
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented May 9, 2017

Nah this is done.

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 9, 2017

📌 Commit 8e97693 has been approved by brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 9, 2017

⌛️ Testing commit 8e97693 with merge db1c9eb...

bors added a commit that referenced this pull request May 9, 2017

@bors
Auto merge of #41548 - brson:relnotes, r=brson 
Update release notes for 1.17

[Rendered](https://github.com/brson/rust/blob/relnotes/RELEASES.md).

cc @steveklabnik
Loading status checks…
db1c9eb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 10, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing db1c9eb to master...

@bors bors merged commit 8e97693 into rust-lang:master May 10, 2017
3 checks passed

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details

@brson brson referenced this pull request May 10, 2017

Merged

[beta] backports #41899

@alexcrichton alexcrichton removed the beta-nominated label May 10, 2017

bors added a commit that referenced this pull request May 11, 2017

@bors
Auto merge of #41899 - brson:backports, r=alexcrichton 
[beta] backports

- #41666
- #41578
- #41548
- #41529

r? @alexcrichton
Loading status checks…
4978d58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.