Don't ever warn about #[used] items being dead code. #41637

Merged
merged 1 commit into from Apr 30, 2017

Conversation

Projects
None yet
5 participants
@eddyb
Member

eddyb commented Apr 29, 2017

Fixes #41628 by whitelisting #[used] items in rustc::middle::dead.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Apr 29, 2017

Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Apr 29, 2017

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

This comment has been minimized.

Show comment
Hide comment
@petrochenkov

petrochenkov Apr 29, 2017

Contributor

I bet someone recently read the @japaric's blog post :)
@bors r+

Contributor

petrochenkov commented Apr 29, 2017

I bet someone recently read the @japaric's blog post :)
@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Apr 29, 2017

Contributor

📌 Commit c054b2a has been approved by petrochenkov

Contributor

bors commented Apr 29, 2017

📌 Commit c054b2a has been approved by petrochenkov

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb

eddyb Apr 29, 2017

Member

@petrochenkov Close, but, more like "@whitequark poked me on IRC".

Member

eddyb commented Apr 29, 2017

@petrochenkov Close, but, more like "@whitequark poked me on IRC".

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 29, 2017

Rollup merge of #41637 - eddyb:used-not-dead, r=petrochenkov
Don't ever warn about #[used] items being dead code.

Fixes #41628 by whitelisting `#[used]` items in `rustc::middle::dead`.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 30, 2017

Rollup merge of #41637 - eddyb:used-not-dead, r=petrochenkov
Don't ever warn about #[used] items being dead code.

Fixes #41628 by whitelisting `#[used]` items in `rustc::middle::dead`.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 30, 2017

Rollup merge of #41637 - eddyb:used-not-dead, r=petrochenkov
Don't ever warn about #[used] items being dead code.

Fixes #41628 by whitelisting `#[used]` items in `rustc::middle::dead`.

bors added a commit that referenced this pull request Apr 30, 2017

Auto merge of #41643 - frewsxcv:rollup, r=frewsxcv
Rollup of 6 pull requests

- Successful merges: #41449, #41509, #41608, #41613, #41636, #41637
- Failed merges:

@bors bors merged commit c054b2a into rust-lang:master Apr 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eddyb eddyb deleted the eddyb:used-not-dead branch Apr 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment