Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uplibrustc: Make `use` statements crate-relative by default #4174
Conversation
This comment has been minimized.
This comment has been minimized.
brson
commented on src/librustc/middle/resolve.rs in e934c3b
Dec 13, 2012
|
Is this a bug or a user-visible error? It should be using the session to report the error. |
This comment has been minimized.
This comment has been minimized.
|
This is a user-visible error. It will error out when Failed bubbles to the top. |
This comment has been minimized.
This comment has been minimized.
brson
commented on src/librustc/middle/resolve.rs in e934c3b
Dec 13, 2012
|
There should probably be a compile-fail test for using |
This comment has been minimized.
This comment has been minimized.
|
This doesn't make either |
This comment has been minimized.
This comment has been minimized.
|
r+ |
pcwalton
closed this
Dec 13, 2012
isaacaggrey
referenced this pull request
Jan 2, 2013
Closed
Rewrite core::int, etc. to use item macros. Remove #[merge] hack #4219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pcwalton commentedDec 13, 2012
r? @brson