New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Forbid `-Z` flags on stable/beta channels #41751

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
7 participants
@alexcrichton
Member

alexcrichton commented May 4, 2017

First deprecated in rustc 1.8.0 the intention was to never allow -Z flags make
their way to the stable channel (or unstable options). After a year of warnings
we've seen one of the main use cases, -Z no-trans, stabilized as cargo check. Otherwise while other use cases remain the sentiment is that now's the
time to start forbidding -Z by default on stable/beta.

Closes #31847

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive May 4, 2017

Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented May 4, 2017

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm May 4, 2017

Member

so... what about #41743 ("Firefox requires -Zdebug-macros")?

Member

kennytm commented May 4, 2017

so... what about #41743 ("Firefox requires -Zdebug-macros")?

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton May 4, 2017

Member

That's a feature that should be stabilized in time, not block this.

Member

alexcrichton commented May 4, 2017

That's a feature that should be stabilized in time, not block this.

@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum May 4, 2017

Member

Travis failed legitimately, I think. I'm somewhat concerned that we'd break Firefox's debugging process by landing this, though, especially with no current clear path forward for debug-macros.

[00:05:47] error: unused import: `early_warn`
[00:05:47]     --> /checkout/src/librustc/session/config.rs:1664:32
[00:05:47]      |
[00:05:47] 1664 |     use session::{early_error, early_warn};
[00:05:47]      |                                ^^^^^^^^^^
[00:05:47]      |
[00:05:47]      = note: #[deny(unused_imports)] implied by #[deny(warnings)]
[00:05:47] note: lint level defined here
[00:05:47]     --> /checkout/src/librustc/lib.rs:24:9
[00:05:47]      |
[00:05:47] 24   | #![deny(warnings)]
[00:05:47]      |         ^^^^^^^^
[00:05:47] 
[00:05:48] error: aborting due to previous error
Member

Mark-Simulacrum commented May 4, 2017

Travis failed legitimately, I think. I'm somewhat concerned that we'd break Firefox's debugging process by landing this, though, especially with no current clear path forward for debug-macros.

[00:05:47] error: unused import: `early_warn`
[00:05:47]     --> /checkout/src/librustc/session/config.rs:1664:32
[00:05:47]      |
[00:05:47] 1664 |     use session::{early_error, early_warn};
[00:05:47]      |                                ^^^^^^^^^^
[00:05:47]      |
[00:05:47]      = note: #[deny(unused_imports)] implied by #[deny(warnings)]
[00:05:47] note: lint level defined here
[00:05:47]     --> /checkout/src/librustc/lib.rs:24:9
[00:05:47]      |
[00:05:47] 24   | #![deny(warnings)]
[00:05:47]      |         ^^^^^^^^
[00:05:47] 
[00:05:48] error: aborting due to previous error
rustc: Forbid `-Z` flags on stable/beta channels
First deprecated in rustc 1.8.0 the intention was to never allow `-Z` flags make
their way to the stable channel (or unstable options). After a year of warnings
we've seen one of the main use cases, `-Z no-trans`, stabilized as `cargo
check`. Otherwise while other use cases remain the sentiment is that now's the
time to start forbidding `-Z` by default on stable/beta.

Closes #31847
@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton May 4, 2017

Member

@Mark-Simulacrum we've been printing for over a year that this will become a warning, debugging with these features will continue to work on nightly, as is intended.

Member

alexcrichton commented May 4, 2017

@Mark-Simulacrum we've been printing for over a year that this will become a warning, debugging with these features will continue to work on nightly, as is intended.

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb

eddyb May 4, 2017

Member

@bors r+

Member

eddyb commented May 4, 2017

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 4, 2017

Contributor

📌 Commit ccbcc72 has been approved by eddyb

Contributor

bors commented May 4, 2017

📌 Commit ccbcc72 has been approved by eddyb

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 4, 2017

Rollup merge of #41751 - alexcrichton:unstable-flags, r=eddyb
rustc: Forbid `-Z` flags on stable/beta channels

First deprecated in rustc 1.8.0 the intention was to never allow `-Z` flags make
their way to the stable channel (or unstable options). After a year of warnings
we've seen one of the main use cases, `-Z no-trans`, stabilized as `cargo
check`. Otherwise while other use cases remain the sentiment is that now's the
time to start forbidding `-Z` by default on stable/beta.

Closes #31847

bors added a commit that referenced this pull request May 4, 2017

Auto merge of #41759 - frewsxcv:rollup, r=frewsxcv
Rollup of 8 pull requests

- Successful merges: #40454, #41512, #41582, #41741, #41746, #41749, #41751, #41754
- Failed merges:

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 5, 2017

Rollup merge of #41751 - alexcrichton:unstable-flags, r=eddyb
rustc: Forbid `-Z` flags on stable/beta channels

First deprecated in rustc 1.8.0 the intention was to never allow `-Z` flags make
their way to the stable channel (or unstable options). After a year of warnings
we've seen one of the main use cases, `-Z no-trans`, stabilized as `cargo
check`. Otherwise while other use cases remain the sentiment is that now's the
time to start forbidding `-Z` by default on stable/beta.

Closes #31847
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 5, 2017

Contributor

⌛️ Testing commit ccbcc72 with merge 50b9858...

Contributor

bors commented May 5, 2017

⌛️ Testing commit ccbcc72 with merge 50b9858...

bors added a commit that referenced this pull request May 5, 2017

Auto merge of #41751 - alexcrichton:unstable-flags, r=eddyb
rustc: Forbid `-Z` flags on stable/beta channels

First deprecated in rustc 1.8.0 the intention was to never allow `-Z` flags make
their way to the stable channel (or unstable options). After a year of warnings
we've seen one of the main use cases, `-Z no-trans`, stabilized as `cargo
check`. Otherwise while other use cases remain the sentiment is that now's the
time to start forbidding `-Z` by default on stable/beta.

Closes #31847
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 5, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 50b9858 to master...

Contributor

bors commented May 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 50b9858 to master...

@bors bors merged commit ccbcc72 into rust-lang:master May 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 9, 2017

Rollup merge of #41830 - jonhoo:update-cargo, r=alexcrichton
Bump cargo for rust-lang/cargo#4000

rust-lang/cargo#4000 recently landed, which fixes warnings about using `-Z` when `CARGO_INCREMENTAL` is set while running stable/beta builds. As #41751 has now landed, these warnings will turn to errors in the next release, so getting the cargo fix in place is necessary unless we want people confused about why they can no longer compile anything on stable/beta.

bors added a commit that referenced this pull request May 9, 2017

Auto merge of #41830 - jonhoo:update-cargo, r=alexcrichton
Bump cargo for rust-lang/cargo#4000

rust-lang/cargo#4000 recently landed, which fixes warnings about using `-Z` when `CARGO_INCREMENTAL` is set while running stable/beta builds. As #41751 has now landed, these warnings will turn to errors in the next release, so getting the cargo fix in place is necessary unless we want people confused about why they can no longer compile anything on stable/beta.

bors added a commit that referenced this pull request May 9, 2017

Auto merge of #41830 - jonhoo:update-cargo, r=alexcrichton
Bump cargo for rust-lang/cargo#4000

rust-lang/cargo#4000 recently landed, which fixes warnings about using `-Z` when `CARGO_INCREMENTAL` is set while running stable/beta builds. As #41751 has now landed, these warnings will turn to errors in the next release, so getting the cargo fix in place is necessary unless we want people confused about why they can no longer compile anything on stable/beta.
@jsgf

This comment has been minimized.

Show comment
Hide comment

@est31 est31 referenced this pull request Jun 5, 2017

Merged

1.18.0 announcement #173

@alexcrichton alexcrichton deleted the alexcrichton:unstable-flags branch Jun 14, 2017

SimonSapin added a commit to servo/skia that referenced this pull request Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment