Updated releases notes for 1.18 #41953

XAMPPRocky · May 12, 2017

This is my first time making the release notes so please give it an extra once over!

rust-highfive · May 12, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

est31 · May 12, 2017

est31 reviewed May 12, 2017

View changes

est31 · May 12, 2017

RELEASES.md

+Cargo
+-----
+
+- [Added Pijul support][cargo/3842] Pijul is a version control system in Rust.


Its just partial support, not for dependencies, but only for cargo new.

@est31 Updated to reflect that.

aturon · May 12, 2017

cc @rust-lang/libs @rust-lang/compiler

eddyb · May 12, 2017

eddyb reviewed May 12, 2017

View changes

eddyb · May 12, 2017

RELEASES.md

+- [rustc can now emit mir with `--emit mir`][39891]
+- [Improved LLVM IR for trivial functions][40367]
+- [Added explanation for E0090(Wrong number of lifetimes are supplied)][40723]
+- [Rustc is now faster][41469]


This could be more specific, e.g. "Compilation time speedup opportunities found through profiling" but I have no strong preference.

I've updated the wording.

WiSaGaN · May 12, 2017

WiSaGaN reviewed May 12, 2017

View changes

WiSaGaN · May 12, 2017

RELEASES.md

+- [rustc can now emit mir with `--emit mir`][39891]
+- [Improved LLVM IR for trivial functions][40367]
+- [Added explanation for E0090(Wrong number of lifetimes are supplied)][40723]
+- [Rustc is now faster][41469]


According to performance graph, the compilation time was reduced around 15% to 20% across the board if I am not mistaken. This is pretty significant improvement. We might as well let user know the actual number.

I wanted to give a overall number, but I didn't know where to get it. Thanks!

alexcrichton · May 12, 2017

alexcrichton reviewed May 12, 2017

View changes

alexcrichton · May 12, 2017

RELEASES.md

+  You can now create new cargo projects with Pijul using `cargo new --vcs pijul`
+- [Now always emits build script warnings for crates that fail to build][cargo/3847]
+- [Added Android build support][cargo/3885]
+- [Added `--all-$KIND` flags][cargo/3901] now you can build all programs


Oh this ended up actually being --tests, --bins, etc, (not --all-$KIND)

alexcrichton · May 12, 2017

alexcrichton reviewed May 12, 2017

View changes

alexcrichton · May 12, 2017

RELEASES.md

+- [Added `--all-$KIND` flags][cargo/3901] now you can build all programs
+  of a certain type, for example `cargo build --all-bins` will build all
+  binaries.
+- [Test files are now allowed be named `test.rs`][cargo/3947]


This is mostly a very minor bugfix, it may not be worth mentioning.

alexcrichton · May 12, 2017

More library features can be found in #41904 I believe

alexcrichton · May 12, 2017

alexcrichton reviewed May 12, 2017

View changes

alexcrichton · May 12, 2017

RELEASES.md

+  the zeroes are placed after the prefix and before the digits.
+- [Optimized insertion sort in slice][40807] insertion sort in some cases
+  2.50%~ faster and in one case now 12.50% faster.
+- [`ThreadId` now implements `Hash` and `Debug`][41008]


This is an unstable feature I believe, so we may not wish to mention it in the release notes just yet

brson · May 12, 2017

Thanks @Aaronepower !

Note that the release notes are still waiting on a library stabilization pr for 1.18.

XAMPPRocky · May 12, 2017

@brson I've just added the stabilised APIs section.

leonardo-m · May 12, 2017

The "Rustc is now faster" in the "Compiler" section is not a good idea because I've later revealed a regression (probably in the 2017-05-03 Nightly) that has negated those compilation performance improvements.

XAMPPRocky · May 12, 2017

@leonardo-m Is there an issue about this?

leonardo-m · May 12, 2017

There is no issue, because my code is not public. But the problem should be visible with public crates too, if it's a real one.

eddyb · May 12, 2017

cc @arielb1

XAMPPRocky · May 12, 2017

@leonardo-m But as @WiSaGaN points out there has been a very clear performance improvement.

Mark-Simulacrum · May 12, 2017

I think we can objectively say that the compiler is 15-20% faster based on the tests in perf.rlo; however, this may not apply to all cases (as usual) -- if there's code that doesn't show this improvement, or shows the opposite, that's also possible. However, I think it's reasonable to say that for some workloads we did improve by 15-20%. Without having access to anything beyond "compilation got slower for me, negating those benefits" I'm afraid we can't produce anything actionable :/

ollie27 · May 12, 2017

ollie27 reviewed May 12, 2017

View changes

ollie27 · May 12, 2017

RELEASES.md

+- [No longer caching stdio on Windows][40516]
+- [Changed how the `0` works in format!][40241] Padding zeroes are now always
+  placed after the sign if it exists and before the digits. With the `#` flag
+  the zeroes are placed after the prefix and before the digits.


I think this should be mentioned in the Compatibility Notes as it's a breaking change.

cuviper · May 13, 2017

cuviper reviewed May 13, 2017

View changes

cuviper · May 13, 2017

RELEASES.md

+Compiler
+--------
+
+- [LLVM backend upgraded to 4.0][40123]


I'm pretty sure LLVM 4 landed just after beta branched, so it will be in 1.19.

aidanhs · May 18, 2017

This PR is currently blocked on the merge of #41904 to finalise what's been stabilised (I think tryfrom has been removed from there since these notes were last updated).

brson · May 22, 2017

It looks like struct layout optimization is in for 1.18. Can you confirm @camlorn ?

sfackler · May 22, 2017

#41904 has landed - just gotta backport to beta.

XAMPPRocky · May 24, 2017

@brson It is, I didn't include it initially as the options are behind the unstable flag.

brson · May 25, 2017

@Aaronepower hm, I don't see in that patch an indication that it's behind a flag (just the optimization fuel).

Library stabilization backports are in.

Let's get this updated and landed and hopefully backported soon.

brson · May 25, 2017

Here's one for the compatibility notes: #41805

mbrubeck · May 30, 2017

mbrubeck reviewed May 30, 2017

View changes

mbrubeck · May 30, 2017

RELEASES.md

+  always placed after the sign if it exists and before the digits. With the `#`
+  flag the zeroes are placed after the prefix and before the digits.
+- [Due to the struct field optimisation][40377], using `transmute` on structs
+  that have no `repr` attribute or `#[repr(Rust)]` will longer work.


Perhaps an added note here: "(This has always been undefined behavior, but is now more likely to break in practice.)"

will longer work ↦ will no longer work

kennytm · May 30, 2017

kennytm reviewed May 30, 2017

View changes

kennytm · May 30, 2017

RELEASES.md

+- [`HashMap::retain`]
+- [`HashSet::retain`]
+- [`PeekMut::pop`]
+- [`TcpSteam::peek`]


typo. TcpStream::peek

kennytm · May 30, 2017

RELEASES.md

+  always placed after the sign if it exists and before the digits. With the `#`
+  flag the zeroes are placed after the prefix and before the digits.
+- [Due to the struct field optimisation][40377], using `transmute` on structs
+  that have no `repr` attribute or `#[repr(Rust)]` will longer work.


will longer work ↦ will no longer work

budziq · May 31, 2017

budziq reviewed May 31, 2017

View changes

budziq · May 31, 2017

RELEASES.md

+  receiving the wrong priority parsing things like `&for<'a> Tr<'a> + Send` as
+  `&(for<'a> Tr<'a> + Send)` instead of `(&for<'a> Tr<'a>) + Send`
+- [Overlapping inherent `impl`s are now a hard error][40728]
+- [`PartialOrd` and `Ord` must to agree on the ordering.][41270]


typo must to agree -> must agree

brson · May 31, 2017

#42068 is going to get a last-minute backport.

brson · May 31, 2017

@bors r- probably we should try to land that backport, then land this, then backport the relnotes.

bors · May 31, 2017

⌛️ Trying commit 9c3e733 with merge a8b46ce...

brson · May 31, 2017

@Aaronepower there's a few new comments to address here.

brson · May 31, 2017

I'm not sure what bors is doing with this PR atm. Status says "pending (try)", and I just r-ed.

Mark-Simulacrum · May 31, 2017

@bors retry

bors · May 31, 2017

⌛️ Trying commit 9c3e733 with merge a65604c...

bors · May 31, 2017

💔 Test failed - status-travis

Mark-Simulacrum · May 31, 2017

Manually canceled the try build to get it out of bors head.

brson · May 31, 2017

I addressed remaining nits and added RFC links.

brson · May 31, 2017

I took the liberty of squashing. Hope you don't mind @Aaronepower.

Rendered.

ollie27 · May 31, 2017

Looks like TcpSteam::peek still isn't fixed.

brson · Jun 1, 2017

Fixed TcpSteam::peek

brson · Jun 2, 2017

@bors r+

bors · Jun 2, 2017

📌 Commit 02c0d3c has been approved by brson

bors · Jun 3, 2017

⌛️ Testing commit 02c0d3c with merge 14526a3...

bors · Jun 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 14526a3 to master...

rust-highfive assigned aturon May 12, 2017

shepmaster added the S-waiting-on-review label May 12, 2017

aidanhs added S-waiting-on-author and removed S-waiting-on-review labels May 18, 2017

brson added the beta-nominated label May 25, 2017

brson referenced this pull request May 30, 2017
Closed
[beta] Updated releases notes for 1.18 #42316

brson added the beta-accepted label May 30, 2017

bors added a commit that referenced this pull request May 31, 2017

Auto merge of #41953 - Aaronepower:patch-1, r=<try>
Updated releases notes for 1.18 This is my first time making the release notes so please give it an extra once over!

Loading status checks…

a8b46ce

bors added a commit that referenced this pull request May 31, 2017

Auto merge of #41953 - Aaronepower:patch-1, r=<try>
Updated releases notes for 1.18 This is my first time making the release notes so please give it an extra once over!

Loading status checks…

a65604c

brson referenced this pull request May 31, 2017
Merged
[beta] Updated releases notes for 1.18 #42338

Updated releases notes for 1.18

Loading status checks…

02c0d3c

brson removed the beta-nominated label Jun 1, 2017

bors added a commit that referenced this pull request Jun 3, 2017

Auto merge of #42338 - brson:beta-next, r=brson
[beta] Updated releases notes for 1.18 - #41953

Loading status checks…

db91aaf

bors added a commit that referenced this pull request Jun 3, 2017

Auto merge of #41953 - Aaronepower:patch-1, r=brson
Updated releases notes for 1.18 This is my first time making the release notes so please give it an extra once over!

Loading status checks…

14526a3

bors merged commit 02c0d3c into rust-lang:master Jun 3, 2017
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

homu Test successful
Details

rust-lang/rust

Join GitHub today

Updated releases notes for 1.18 #41953

Conversation

XAMPPRocky commented May 12, 2017

rust-highfive assigned aturon May 12, 2017

This comment has been minimized.

rust-highfive commented May 12, 2017

est31 reviewed May 12, 2017 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

aturon commented May 12, 2017

eddyb reviewed May 12, 2017 View changes

This comment has been minimized.

This comment has been minimized.

WiSaGaN reviewed May 12, 2017 View changes

This comment has been minimized.

This comment has been minimized.

shepmaster added the S-waiting-on-review label May 12, 2017

alexcrichton reviewed May 12, 2017 View changes

This comment has been minimized.

alexcrichton reviewed May 12, 2017 View changes

This comment has been minimized.

This comment has been minimized.

alexcrichton commented May 12, 2017

alexcrichton reviewed May 12, 2017 View changes

This comment has been minimized.

This comment has been minimized.

brson commented May 12, 2017

This comment has been minimized.

XAMPPRocky commented May 12, 2017

This comment has been minimized.

leonardo-m commented May 12, 2017

This comment has been minimized.

XAMPPRocky commented May 12, 2017

This comment has been minimized.

leonardo-m commented May 12, 2017

This comment has been minimized.

eddyb commented May 12, 2017

This comment has been minimized.

XAMPPRocky commented May 12, 2017

This comment has been minimized.

Mark-Simulacrum commented May 12, 2017

ollie27 reviewed May 12, 2017 View changes

This comment has been minimized.

cuviper reviewed May 13, 2017 View changes

This comment has been minimized.

This comment has been minimized.

aidanhs commented May 18, 2017

aidanhs added S-waiting-on-author and removed S-waiting-on-review labels May 18, 2017

This comment has been minimized.

brson commented May 22, 2017

This comment has been minimized.

sfackler commented May 22, 2017

This comment has been minimized.

XAMPPRocky commented May 24, 2017

This comment has been minimized.

brson commented May 25, 2017

brson added the beta-nominated label May 25, 2017

This comment has been minimized.

brson commented May 25, 2017

brson referenced this pull request May 30, 2017

brson added the beta-accepted label May 30, 2017

mbrubeck reviewed May 30, 2017 View changes

This comment has been minimized.

This comment has been minimized.

kennytm reviewed May 30, 2017 View changes

This comment has been minimized.

This comment has been minimized.

budziq reviewed May 31, 2017 View changes

This comment has been minimized.

This comment has been minimized.

brson commented May 31, 2017

This comment has been minimized.

brson commented May 31, 2017

This comment has been minimized.

bors commented May 31, 2017

bors added a commit that referenced this pull request May 31, 2017

This comment has been minimized.

est31 reviewed May 12, 2017

View changes

eddyb reviewed May 12, 2017

View changes

WiSaGaN reviewed May 12, 2017

View changes

alexcrichton reviewed May 12, 2017

View changes

alexcrichton reviewed May 12, 2017

View changes

alexcrichton reviewed May 12, 2017

View changes

ollie27 reviewed May 12, 2017

View changes

cuviper reviewed May 13, 2017

View changes

mbrubeck reviewed May 30, 2017

View changes

kennytm reviewed May 30, 2017

View changes

budziq reviewed May 31, 2017

View changes

bors merged commit `02c0d3c` into rust-lang:master Jun 3, 2017
1 of 2 checks passed