Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta backport various arielb1 patches #42053

Merged
merged 2 commits into from May 23, 2017

Conversation

Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-author
Projects
None yet
Milestone
No milestone
9 participants
@nikomatsakis @rust-highfive @eddyb @bors @Mark-Simulacrum @alexcrichton @pnkfelix @aidanhs @arielb1
@nikomatsakis
Copy link
Contributor

nikomatsakis commented May 17, 2017 •
edited

Backport of the following PRs:

cc @arielb1 @rust-lang/compiler

@rust-highfive rust-highfive assigned pnkfelix May 17, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented May 17, 2017

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)
@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented May 17, 2017

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

This was referenced May 17, 2017

Merged
Merged
Merged
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented May 17, 2017

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 17, 2017

📌 Commit 49138b4 has been approved by eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 17, 2017

⌛️ Testing commit 49138b4 with merge fb9ba8d...

bors added a commit that referenced this pull request May 17, 2017

@bors
Auto merge of #42053 - nikomatsakis:beta, r=eddyb 
Beta backport various arielb1 patches

Backport of the following PRs:

- #41920
- #41651
- #41828

cc @arielb1 @rust-lang/compiler
Loading status checks…
fb9ba8d
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 17, 2017

💔 Test failed - status-travis
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented May 17, 2017

@bors retry

  • Build just stopped
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented May 17, 2017

@bors: r-

Looks like a legitimate error?

[00:48:58] test [run-pass] run-pass/issue-41696.rs has been running for over 60 seconds
...
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

@aidanhs aidanhs added S-waiting-on-bors S-waiting-on-author and removed S-waiting-on-bors labels May 18, 2017

@michaelwoerister michaelwoerister referenced this pull request May 18, 2017

Closed

Rust 1.18 ICE regression: assertion failed: !unsize (nightly regression #41604) #41944

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented May 19, 2017

@arielb1 any idea why the backport [doesn't fix the problem for #41696](#42053 (comment)? is it maybe specific to what version of LLVM the beta is using or something?

arielb1 added some commits Apr 27, 2017

@arielb1 @nikomatsakis
refactor the handling of lvalue ops 
Fixes #41604.
4809658
@arielb1 @nikomatsakis
try to fix lvalue ops for real 
Hopefully this is the last PR needed.

Fixes #41726.
Fixes #41742.
Fixes #41774.
Loading status checks…
0afe53e

@nikomatsakis nikomatsakis force-pushed the nikomatsakis:beta branch from 49138b4 to 0afe53e May 22, 2017

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented May 22, 2017

Removed #41920
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented May 22, 2017

@bors r=eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 22, 2017

📌 Commit 0afe53e has been approved by eddyb
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

nikomatsakis commented May 22, 2017

@bors p=1
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 22, 2017

⌛️ Testing commit 0afe53e with merge 191cde0...

bors added a commit that referenced this pull request May 22, 2017

@bors
Auto merge of #42053 - nikomatsakis:beta, r=eddyb 
Beta backport various arielb1 patches

Backport of the following PRs:

- #41651
- #41828

cc @arielb1 @rust-lang/compiler
Loading status checks…
191cde0
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 191cde0 to beta...

@bors bors merged commit 0afe53e into rust-lang:beta May 23, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.