Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] backports #42161

Merged
merged 3 commits into from May 23, 2017

Conversation

Projects
None yet
7 participants
@brson
Copy link
Contributor

brson commented May 23, 2017

Bumps the version so we get a new beta.

@sfackler libs backports here

@nikomatsakis there are several other nominated PRs that don't cherry-pick cleanly: https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3Abeta-nominated+is%3Aclosed. Can you take a look or recruit someone else to?

r? @alexcrichton

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 23, 2017

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented May 23, 2017

@bors: r+ p=1

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 23, 2017

📌 Commit 61063b0 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 23, 2017

⌛️ Testing commit 61063b0 with merge 71e7c7e...

bors added a commit that referenced this pull request May 23, 2017

Auto merge of #42161 - brson:beta-next, r=alexcrichton
[beta] backports

- #42006
- #41904

Bumps the version so we get a new beta.

@sfackler libs backports here

@nikomatsakis there are several other nominated PRs that don't cherry-pick cleanly: https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3Abeta-nominated+is%3Aclosed. Can you take a look or recruit someone else to?

r? @alexcrichton
@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 23, 2017

💔 Test failed - status-travis

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented May 23, 2017

@bors: retry

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented May 23, 2017

@bors p=20 (above rollup because beta branches soonish)

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented May 23, 2017

No, bors, I really did mean p=20, not rollup...

@bors p=20

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented May 23, 2017

@bors p=20

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented May 23, 2017

@bors -rollup

I think this is the syntax I might've seen @steveklabnik use.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented May 23, 2017

@bors rollup- p=20

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 23, 2017

⌛️ Testing commit 61063b0 with merge 139d12f...

bors added a commit that referenced this pull request May 23, 2017

Auto merge of #42161 - brson:beta-next, r=alexcrichton
[beta] backports

- #42006
- #41904

Bumps the version so we get a new beta.

@sfackler libs backports here

@nikomatsakis there are several other nominated PRs that don't cherry-pick cleanly: https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3Abeta-nominated+is%3Aclosed. Can you take a look or recruit someone else to?

r? @alexcrichton
@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 23, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 139d12f to beta...

@bors bors merged commit 61063b0 into rust-lang:beta May 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.