Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] box large variants in MIR #42197

Merged
merged 2 commits into from May 26, 2017

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
8 participants
@arielb1 @rust-highfive @nikomatsakis @bors @aidanhs @brson @alexcrichton @Mark-Simulacrum
@arielb1
Copy link
Contributor

arielb1 commented May 24, 2017 •
edited

Beta backport of #41926.

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
@arielb1
box large variants in MIR 
Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
Loading status checks…
74fe27f

@rust-highfive rust-highfive assigned nikomatsakis May 24, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented May 24, 2017

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)
@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented May 24, 2017

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented May 24, 2017

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 24, 2017

📌 Commit 74fe27f has been approved by nikomatsakis
@aidanhs

This comment has been minimized.

Sign in to view
Copy link
Member

aidanhs commented May 24, 2017

(not a legit PR build failure, it just failed to clone (#42117) on the OSX builder which wouldn't do anything anyway. Nothing to to retry since bors hasn't had a look yet)

@aidanhs aidanhs added the S-waiting-on-bors label May 24, 2017

@aidanhs

This comment has been minimized.

Sign in to view
Copy link
Member

aidanhs commented May 24, 2017

(realised I have the power to retry jobs, so I did so and all is green)
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented May 25, 2017

@bors p=1
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 25, 2017

⌛️ Testing commit 74fe27f with merge f40fad5...

bors added a commit that referenced this pull request May 25, 2017

@bors
Auto merge of #42197 - arielb1:box-mir-beta, r=nikomatsakis 
[beta] box large variants in MIR

Beta backport of #41926.

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
Loading status checks…
f40fad5
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 25, 2017

💔 Test failed - status-travis
@alexcrichton
Update OpenSSL download location
Loading status checks…
ea239f2
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented May 25, 2017

@bors: r=nikomatsakis
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 25, 2017

📌 Commit ea239f2 has been approved by nikomatsakis
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 25, 2017

⌛️ Testing commit ea239f2 with merge cf77445...

bors added a commit that referenced this pull request May 25, 2017

@bors
Auto merge of #42197 - arielb1:box-mir-beta, r=nikomatsakis 
[beta] box large variants in MIR

Beta backport of #41926.

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
Loading status checks…
cf77445

@alexcrichton alexcrichton referenced this pull request May 25, 2017

Merged

Update OpenSSL download location #42220

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 25, 2017

💔 Test failed - status-appveyor
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented May 25, 2017

@bors: retry

  • ar.exe error fixed on master
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 25, 2017

⌛️ Testing commit ea239f2 with merge e9f90f7...

bors added a commit that referenced this pull request May 25, 2017

@bors
Auto merge of #42197 - arielb1:box-mir-beta, r=nikomatsakis 
[beta] box large variants in MIR

Beta backport of #41926.

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
Loading status checks…
e9f90f7
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 25, 2017

💔 Test failed - status-travis
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented May 25, 2017

@bors retry
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 26, 2017

⌛️ Testing commit ea239f2 with merge 4644612...

bors added a commit that referenced this pull request May 26, 2017

@bors
Auto merge of #42197 - arielb1:box-mir-beta, r=nikomatsakis 
[beta] box large variants in MIR

Beta backport of #41926.

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
Loading status checks…
4644612
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 4644612 to beta...

@bors bors merged commit ea239f2 into rust-lang:beta May 26, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.