Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[beta] Backport union stabilization PRs #42328
Conversation
petrochenkov
added some commits
May 18, 2017
rust-highfive
assigned
brson
May 31, 2017
This comment has been minimized.
This comment has been minimized.
petrochenkov
referenced this pull request
May 31, 2017
Closed
[beta] Stabilize unions with `Copy` fields and no destructor #42321
This comment has been minimized.
This comment has been minimized.
|
I think this should be put into the release notes, no? |
This comment has been minimized.
This comment has been minimized.
|
I'm going to update the relnotes and backport as part of this pr. |
This comment has been minimized.
This comment has been minimized.
|
This isn't backporting the reference docs, and it probably should. |
This comment has been minimized.
This comment has been minimized.
|
There's no beta branch of the reference to backport the reference docs to. I'm feeling a bit uncomfortable about this. |
This comment has been minimized.
This comment has been minimized.
|
I'll copy my comment from #42068: "I don't strongly object, but I'm surprised we would backport this. I feel like we try to keep backports to regressions or important bug fixes, and only rarely backport stabilizations -- the exception would be if some feature is hotly demanded. But otoh this seems pretty darn low risk, so no real objection." |
This comment has been minimized.
This comment has been minimized.
|
I'm going to look into backporting the reference directly from reference/master and see if it makes sense on beta. |
This comment has been minimized.
This comment has been minimized.
|
Here's the reference diff: rust-lang-nursery/reference@6b0de90...master |
This comment has been minimized.
This comment has been minimized.
|
Let's not do it. Feels risky to me. |
brson
closed this
May 31, 2017
This comment has been minimized.
This comment has been minimized.
lilianmoraru
commented
Jul 8, 2017
|
So, this did not land? |
petrochenkov commentedMay 31, 2017
Supersedes #42321
cc @aturon
r? @brson