Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Backport union stabilization PRs #42328

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
6 participants
@petrochenkov
Copy link
Contributor

petrochenkov commented May 31, 2017

Supersedes #42321

cc @aturon
r? @brson

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 31, 2017

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
@est31

This comment has been minimized.

Copy link
Contributor

est31 commented May 31, 2017

I think this should be put into the release notes, no?

@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 31, 2017

I'm going to update the relnotes and backport as part of this pr.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 31, 2017

This isn't backporting the reference docs, and it probably should.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 31, 2017

There's no beta branch of the reference to backport the reference docs to.

I'm feeling a bit uncomfortable about this.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented May 31, 2017

I'll copy my comment from #42068:

"I don't strongly object, but I'm surprised we would backport this. I feel like we try to keep backports to regressions or important bug fixes, and only rarely backport stabilizations -- the exception would be if some feature is hotly demanded. But otoh this seems pretty darn low risk, so no real objection."

@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 31, 2017

I'm going to look into backporting the reference directly from reference/master and see if it makes sense on beta.

@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 31, 2017

@brson

This comment has been minimized.

Copy link
Contributor

brson commented May 31, 2017

Let's not do it. Feels risky to me.

@brson brson closed this May 31, 2017

@lilianmoraru

This comment has been minimized.

Copy link

lilianmoraru commented Jul 8, 2017

So, this did not land?
The release notes say that it landed: https://github.com/rust-lang/rust/pull/42503/files#diff-5cafcf46bfb947f8e58fa5c16d39018cR13

@petrochenkov petrochenkov deleted the petrochenkov:beta branch Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.