Skip to content

save-analysis: signatures for everything! #42471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 13, 2017
Merged

save-analysis: signatures for everything! #42471

merged 9 commits into from
Jun 13, 2017

Conversation

nrc
Copy link
Member

@nrc nrc commented Jun 6, 2017

No description provided.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc nrc force-pushed the save-sig-2 branch 2 times, most recently from 4b84628 to a9cfd5f Compare June 6, 2017 04:19
@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2017
@nrc
Copy link
Member Author

nrc commented Jun 7, 2017

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned arielb1 Jun 7, 2017
@eddyb
Copy link
Member

eddyb commented Jun 7, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 7, 2017

📌 Commit a9cfd5f has been approved by eddyb

@nrc nrc mentioned this pull request Jun 7, 2017
Merged
@bors
Copy link
Collaborator

bors commented Jun 8, 2017

☔ The latest upstream changes (presumably #42447) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc nrc added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2017
@nrc
Copy link
Member Author

nrc commented Jun 8, 2017

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Jun 8, 2017

📌 Commit 29d4436 has been approved by eddyb

@eddyb
Copy link
Member

eddyb commented Jun 8, 2017

@bors r- Please rebase first (you have a merge commit)

@nrc
Copy link
Member Author

nrc commented Jun 8, 2017

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Jun 8, 2017

📌 Commit 2758c7b has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jun 9, 2017

⌛ Testing commit 2758c7b with merge 3ecb3ad...

@bors
Copy link
Collaborator

bors commented Jun 9, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

Legitimate failure.

[00:00:11] error: failed to parse lock file at: /checkout/src/Cargo.lock

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2017
nrc added 3 commits June 12, 2017 14:14
@nrc
Add a sig module to save-analysis
600237f 
Generates signatures for use in Rustdoc and similar tools.
@nrc
Update rls-data
0058fdd
@nrc
Use the new signature stuff
a2a999f 
And fix a couple of bugs
@nrc
Copy link
Member Author

nrc commented Jun 12, 2017

@bors: r=eddyb

@bors
Copy link
Collaborator

bors commented Jun 12, 2017

📌 Commit 34bd80a has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jun 12, 2017

⌛ Testing commit 34bd80a with merge 0683264...

@nrc nrc added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 12, 2017
@bors
Copy link
Collaborator

bors commented Jun 12, 2017

💔 Test failed - status-travis

@carols10cents carols10cents added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 12, 2017
@carols10cents
Copy link
Member

Looks like a legit failure to me?

[00:58:45] error[E0512]: transmute called with differently sized types: rls_data::Analysis (2176 bits) to data::Analysis (1984 bits)
[00:58:45]    --> /checkout/src/tools/rls/src/build.rs:588:57
[00:58:45]     |
[00:58:45] 588 |                                                         ::std::mem::transmute(a.clone())
[00:58:45]     |                                                         ^^^^^^^^^^^^^^^^^^^^^ transmuting between 2176 bits and 1984 bits

@Nashenas88
Copy link
Contributor

Crate version mismatch! I've found the cargo-tree project very useful for narrowing this one down.

@nrc
Copy link
Member Author

nrc commented Jun 12, 2017

@bors: r=eddyb

@bors
Copy link
Collaborator

bors commented Jun 12, 2017

📌 Commit 7669fec has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Jun 13, 2017

⌛ Testing commit 7669fec with merge e2602be...

@bors
Copy link
Collaborator

bors commented Jun 13, 2017

💔 Test failed - status-travis

@nrc
Copy link
Member Author

nrc commented Jun 13, 2017

@bors: r=eddyb

@bors
Copy link
Collaborator

bors commented Jun 13, 2017

📌 Commit ffd83fd has been approved by eddyb

@nrc nrc added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2017
@bors
Copy link
Collaborator

bors commented Jun 13, 2017

⌛ Testing commit ffd83fd with merge e7fffa2...

bors added a commit that referenced this pull request Jun 13, 2017
@bors
Auto merge of #42471 - nrc:save-sig-2, r=eddyb
e7fffa2 
save-analysis: signatures for everything!
@bors
Copy link
Collaborator

bors commented Jun 13, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing e7fffa2 to master...

@bors bors merged commit ffd83fd into rust-lang:master Jun 13, 2017
@bors bors mentioned this pull request Jun 13, 2017
Merged
@nrc nrc deleted the save-sig-2 branch June 13, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eddyb eddyb eddyb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nrc @rust-highfive @eddyb @bors @Mark-Simulacrum @carols10cents @Nashenas88 @19h @arielb1