Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save-analysis: signatures for everything! #42471

Merged
merged 9 commits into from Jun 13, 2017

Conversation

Reviewers

@eddyb eddyb

Assignees

@eddyb eddyb

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
9 participants
@nrc @rust-highfive @eddyb @bors @Mark-Simulacrum @carols10cents @Nashenas88 @KenanSulayman @arielb1
@nrc
Copy link
Member

nrc commented Jun 6, 2017

No description provided.

@rust-highfive rust-highfive assigned arielb1 Jun 6, 2017

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jun 6, 2017

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc nrc force-pushed the nrc:save-sig-2 branch 2 times, most recently from 4b84628 to a9cfd5f Jun 6, 2017

@arielb1 arielb1 added the S-waiting-on-review label Jun 6, 2017

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member Author

nrc commented Jun 7, 2017

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned arielb1 Jun 7, 2017

@eddyb

eddyb approved these changes Jun 7, 2017
View changes

@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Jun 7, 2017

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 7, 2017

📌 Commit a9cfd5f has been approved by eddyb

@nrc nrc referenced this pull request Jun 7, 2017

Merged

Add Borrow and Ownership structs and fields #5

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 8, 2017

☔️ The latest upstream changes (presumably #42447) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc nrc added S-waiting-on-bors and removed S-waiting-on-review labels Jun 8, 2017

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member Author

nrc commented Jun 8, 2017

@bors r=eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 8, 2017

📌 Commit 29d4436 has been approved by eddyb
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented Jun 8, 2017

@bors r- Please rebase first (you have a merge commit)

@nrc nrc force-pushed the nrc:save-sig-2 branch from 29d4436 to 2758c7b Jun 8, 2017

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member Author

nrc commented Jun 8, 2017

@bors r=eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 8, 2017

📌 Commit 2758c7b has been approved by eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 9, 2017

⌛️ Testing commit 2758c7b with merge 3ecb3ad...

bors added a commit that referenced this pull request Jun 9, 2017

@bors
Auto merge of #42471 - nrc:save-sig-2, r=eddyb 
save-analysis: signatures for everything!
Loading status checks…
3ecb3ad
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 9, 2017

💔 Test failed - status-travis
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
Copy link
Member

Mark-Simulacrum commented Jun 9, 2017

Legitimate failure.

[00:00:11] error: failed to parse lock file at: /checkout/src/Cargo.lock

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author and removed S-waiting-on-bors labels Jun 9, 2017

nrc added some commits May 29, 2017

@nrc
Add a sig module to save-analysis 
Generates signatures for use in Rustdoc and similar tools.
600237f
@nrc
Update rls-data
0058fdd
@nrc
Use the new signature stuff 
And fix a couple of bugs
a2a999f

@nrc nrc force-pushed the nrc:save-sig-2 branch from 2758c7b to 34bd80a Jun 12, 2017

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member Author

nrc commented Jun 12, 2017

@bors: r=eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 12, 2017

📌 Commit 34bd80a has been approved by eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 12, 2017

⌛️ Testing commit 34bd80a with merge 0683264...

@nrc nrc added S-waiting-on-bors and removed S-waiting-on-author labels Jun 12, 2017

bors added a commit that referenced this pull request Jun 12, 2017

@bors
Auto merge of #42471 - nrc:save-sig-2, r=eddyb 
save-analysis: signatures for everything!
Loading status checks…
0683264
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 12, 2017

💔 Test failed - status-travis

@carols10cents carols10cents added S-waiting-on-author and removed S-waiting-on-bors labels Jun 12, 2017

@carols10cents

This comment has been minimized.

Sign in to view
Copy link
Member

carols10cents commented Jun 12, 2017

Looks like a legit failure to me?

[00:58:45] error[E0512]: transmute called with differently sized types: rls_data::Analysis (2176 bits) to data::Analysis (1984 bits)
[00:58:45]    --> /checkout/src/tools/rls/src/build.rs:588:57
[00:58:45]     |
[00:58:45] 588 |                                                         ::std::mem::transmute(a.clone())
[00:58:45]     |                                                         ^^^^^^^^^^^^^^^^^^^^^ transmuting between 2176 bits and 1984 bits
@Nashenas88

This comment has been minimized.

Sign in to view
Copy link
Contributor

Nashenas88 commented Jun 12, 2017

Crate version mismatch! I've found the cargo-tree project very useful for narrowing this one down.
@nrc

This comment has been minimized.

Sign in to view
Copy link
Member Author

nrc commented Jun 12, 2017

@bors: r=eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 12, 2017

📌 Commit 7669fec has been approved by eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 13, 2017

⌛️ Testing commit 7669fec with merge e2602be...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 13, 2017

💔 Test failed - status-travis
@nrc
Update RLS again
Loading status checks…
ffd83fd

@nrc nrc force-pushed the nrc:save-sig-2 branch from 7669fec to ffd83fd Jun 13, 2017

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member Author

nrc commented Jun 13, 2017

@bors: r=eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 13, 2017

📌 Commit ffd83fd has been approved by eddyb

@nrc nrc added S-waiting-on-bors and removed S-waiting-on-author labels Jun 13, 2017

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 13, 2017

⌛️ Testing commit ffd83fd with merge e7fffa2...

bors added a commit that referenced this pull request Jun 13, 2017

@bors
Auto merge of #42471 - nrc:save-sig-2, r=eddyb 
save-analysis: signatures for everything!
Loading status checks…
e7fffa2
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 13, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing e7fffa2 to master...

@bors bors merged commit ffd83fd into rust-lang:master Jun 13, 2017
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details

@bors bors referenced this pull request Jun 13, 2017

Merged

Add warnings when rustdoc html rendering differs #41991

@nrc nrc deleted the nrc:save-sig-2 branch Jun 13, 2017

@KenanSulayman

This comment has been minimized.

Sign in to view
Copy link

KenanSulayman commented on src/librustc_save_analysis/lib.rs in 35abf13 Jul 9, 2017

Why did you make this method private?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.