Updated releases notes for 1.19 #42503

XAMPPRocky · Jun 7, 2017

This is waiting on any beta backports in the coming weeks, and the lib stabilisations pr.

rust-highfive · Jun 7, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

XAMPPRocky · Jun 7, 2017

In this release there has been a lot of error codes added by @GuillaumeGomez I was wondering should they each get a line item, or is the current fine?

jtdowney · Jun 7, 2017

jtdowney reviewed Jun 7, 2017

View changes

jtdowney · Jun 7, 2017

RELEASES.md

+--------
+
+- [Numeric fields can now be used for creating tuple structs.][36868]
+  For example `struct Point(u32, u32); let x = Foo { 0: 7, 1: 0 };`.


Wouldn't this be let x = Point { 0: 7, 1: 0 };

Nemo157 · Jun 7, 2017

Nemo157 reviewed Jun 7, 2017

View changes

Nemo157 · Jun 7, 2017

RELEASES.md

+  the members in a given workspace.][cargo/3988]
+- [Updated `libssh2-sys` to 0.2.6][cargo/4008]
+- [Target directory path is now in the cargo metadata][cargo/4022]
+- [Cargo no longer checks the crates.io index locally][cargo/4026] This should


I would word this something like "Cargo no longer checks out a local working directory for the crates.io index"

ollie27 · Jun 7, 2017

ollie27 suggested changes Jun 7, 2017

View changes

Looks like a few things are missing:

From<Box<str>> for Box<[u8]> #41258
eprint! and eprintln! #41192
closure_to_fn_coercion #42162

ollie27 · Jun 7, 2017

RELEASES.md

+- [Ending a float literal with `._` is now a hard error.
+  Example: `42._` .][41946]
+- [Ending a str literal with an underscore is now a hard error
+  Example: `"foo"_`][41990]


This didn't make it into 1.19.

This is also a warning, not error.

ollie27 · Jun 7, 2017

RELEASES.md

+- [Added `rust-windbg.cmd`][39983] for loading rust `.natvis` files in the
+  Windows Debugger.
+- [Rust Language Server is now packaged as a non default component with the
+  `.exe`, `.msi`, and `.pkg` installers][42306]


I think this has been reverted: #42472

petrochenkov · Jun 7, 2017

petrochenkov reviewed Jun 7, 2017

View changes

petrochenkov · Jun 7, 2017

RELEASES.md

+Language
+--------
+
+- [Numeric fields can now be used for creating tuple structs.][36868]


The correct PR is #41145

petrochenkov · Jun 7, 2017

petrochenkov reviewed Jun 7, 2017

View changes

petrochenkov · Jun 7, 2017

RELEASES.md

+- [Ending a str literal with an underscore is now a hard error
+  Example: `"foo"_`][41990]
+- [Publicly exposing a private type is now a hard error][34537] This was
+  previously a warning.


Nah, this is wrong. Most of #34537 isn't going to be an error, only some tiny piece of it (public reexports of private enum variants) has become an error.

petrochenkov · Jun 7, 2017

petrochenkov reviewed Jun 7, 2017

View changes

petrochenkov · Jun 7, 2017

RELEASES.md

+- [Publicly exposing a private type is now a hard error][34537] This was
+  previously a warning.
+- [Type parameter defaults in trait impls and functions is now a
+  hard error][36887] This was previously a warning.


This is still a warning, there was too much breakage (as you can see, the issue is still open).

petrochenkov · Jun 7, 2017

petrochenkov reviewed Jun 7, 2017

View changes

petrochenkov · Jun 7, 2017

RELEASES.md

+- [Type parameter defaults in trait impls and functions is now a
+  hard error][36887] This was previously a warning.
+- [`use` imports on a private `extern crate` in a module is now a hard
+  error.][36886] This was previously a warning.


#36886 is about any use of private extern crates outside of their module, not about imports or reexports.

mbrubeck · Jun 7, 2017

mbrubeck reviewed Jun 7, 2017

View changes

These look great! Here are a few additions that I think would clarify some of them.

mbrubeck · Jun 7, 2017

RELEASES.md

+  For example: `let x = loop { break 7; };`
+- [C compatible `union`s are now available.][42068] They can only contain `Copy`
+  types and cannot have a `Drop` implementation.
+  Example: `union Foo { bar: u8 }`


A union with two fields of different types might be a clearer example.

mbrubeck · Jun 7, 2017

mbrubeck reviewed Jun 7, 2017

View changes

mbrubeck · Jun 7, 2017

RELEASES.md

+Compiler
+--------
+
+- [Added bootstrap support for Android.][41370]


I suggest expanding this to "Add support for bootstrapping the Rust compiler toolchain on Android."

mbrubeck · Jun 7, 2017

RELEASES.md

+
+- [Added bootstrap support for Android.][41370]
+- [Change `arm-linux-androideabi` to correspond to the `armeabi`
+  official ABI.][41656]


It might be useful to note that developers must now use --target armv7-linux-androideabi if they want to continue targeting the armeabi-v7a ABI.

cuviper · Jun 7, 2017

Should this now mention LLVM4 support? (i.e. rust-llvm is upgraded, and external LLVM4 works too.)

TimNN · Jun 7, 2017

TimNN reviewed Jun 7, 2017

View changes

TimNN · Jun 7, 2017

RELEASES.md

+  Example: `union Foo { bar: u8 }`
+
+Compiler
+--------


This section should probably mention the LLVM upgrade #40123.

Edit: Nevermind this comment, I didn't notice @cuviper's comment when looking at the diff.

XAMPPRocky · Jun 7, 2017

@cuviper @TimNN Is there anything to be said about using LLVM 4.0, or is Now uses LLVM 4.0 enough?

ranma42 · Jun 8, 2017

@brson on the rust side, XZ compression of the tarballs should ready. Should it be mentioned in the release notes or is it better to wait for the next rustup release?

cuviper · Jun 8, 2017

@Aaronepower There are two sides to it, both the version of LLVM that Rust is shipped with and the external versions it supports in custom builds. For the LLVM 3.9 update it simply said, "The compiler can now be built against LLVM 3.9".

brson · Jun 8, 2017

Thanks a bunch @Aaronepower.

Added a link to the rendered notes to the OP.

@Aaronepower do any of these have RFC's that can be referenced for further info? I bet numeric fields, break return, unions, maybe closure coercions.

I see that 'compatibility notes' is not last this time. Any particular reason? I've put them last in the past to deemphasize them.

I don't see custom CRT linkage, xz compression.

I've added a milestone issue to make sure rustup with xz gets released: #42542

brson · Jun 8, 2017

@ranma42 Yes, I think it should be mentioned. rustup will be out in time.

brson · Jun 8, 2017

@Aaronepower I think one line for the error codes is fine.

alexcrichton · Jun 15, 2017

ping @Aaronepower, just wanted to keep this on your radar!

kennytm · Jun 18, 2017

I think rust-lang/cargo#3954 (Add support for custom target-specific runners — target.$triple.runner in .cargo/config) is worth mentioning.

brson · Jul 8, 2017

It is possible the RangeArgument type will change names before release: #43033

brson · Jul 13, 2017

RangeArgument is not in the release.

brson · Jul 13, 2017

Updated for all comments. #42635 is slated to be fixed and doesn't need a compat note. We might wait to see that reverted and then this is probably good to go.

mbrubeck · Jul 13, 2017

mbrubeck reviewed Jul 13, 2017

View changes

mbrubeck · Jul 13, 2017

RELEASES.md

+  a warning.
+- [From the pound escape, lines consisting of multiple `#`s are
+  now visible][41785]
+- [`for` loop desugaring has changed such that `break` does nat


Typo: s/nat/not/

mbrubeck · Jul 13, 2017

mbrubeck reviewed Jul 13, 2017

View changes

mbrubeck · Jul 13, 2017

RELEASES.md

+- [Rust will now release XZ compressed packages][rust-installer/57]
+- [rustup will now prefer to download rust packages with
+  XZ compression][rustup/1100] over GZip packages.
+- [Added the ability to escape `#` in rust documentation][41785] By adding


This change is mentioned twice (once here, then again in "Compatibility Notes" below).

Yeah, I noticed that and decided that it's ok - it's a feature addition with compatibility concerns. shrug

brson · Jul 13, 2017

@steveklabnik since we're reverting this change that affects nmake, at least temporarily, to give more time for the ecosystem to adapt, it might be worth mentioning in the release announcement so users are aware.

Zoxc · Jul 13, 2017

Zoxc reviewed Jul 13, 2017

View changes

Zoxc · Jul 13, 2017

RELEASES.md

+- [From the pound escape, lines consisting of multiple `#`s are
+  now visible][41785]
+- [`for` loop desugaring has changed such that `break` does not
+  affect type inference][42634]


This pull request is a fix for #42265 which has never been stable.

This should say: for loop desugaring has changed such that the iterator is not borrowed during the loop body.
#42265 should also be referenced.

It probably doesn't belong in compatibility notes since it should have no effect on Rust code.

Thanks @Zoxc. Since it has no effect, I just removed it completely.

brson · Jul 13, 2017

Oh, if the jobserver patch is reverted, it will need to be removed from the relnotes.

XAMPPRocky · Jul 13, 2017

@brson I'm not seeing any revert PR, was this mentioned somewhere?

jimmycuadra · Jul 14, 2017

jimmycuadra reviewed Jul 14, 2017

View changes

jimmycuadra · Jul 14, 2017

RELEASES.md

+  `aborting due to N previous errors`][42150] This was previously inaccurate and
+  would only count certain kinds of errors.
+- [The compiler now supports Visual Studio 2017][42225]
+- [The compiler is now be built against LLVM 4.0.1 by default][42948]


Typo: "is now be built"

jimmycuadra · Jul 14, 2017

In the compatibility notes, #34537 and #42460 are both linked with nearly identical descriptions. Do these represent the same underlying subject, and if so, should one of those links be removed?

brson · Jul 14, 2017

@Aaronepower jobserver was reverted here, which was actually merged here.

brson · Jul 14, 2017

@jimmycuadra yeah, they are both pretty much the same, probably we should only keep the link to the private_in_public PR.

sfackler · Jul 19, 2017

sfackler reviewed Jul 19, 2017

View changes

sfackler · Jul 19, 2017

RELEASES.md

+  command, which has been available since 1.16.
+- [Ending a float literal with `._` is now a hard error.
+  Example: `42._` .][41946]
+- [Any use of a private `extern crate` outside of it's module is now a


its not it's I think?

brson · Jul 19, 2017

@bors p=100 needs to land before the release!

steveklabnik · Jul 19, 2017

steveklabnik reviewed Jul 19, 2017

View changes

steveklabnik · Jul 19, 2017

RELEASES.md

+[RFC 1558]: https://github.com/rust-lang/rfcs/pull/1558
+[RFC 1624]: https://github.com/rust-lang/rfcs/pull/1624
+[RFC 1721]: https://github.com/rust-lang/rfcs/pull/1721
+[`Command::envs`]: https://doc.rust-lang.org/nightly/std/process/struct.Command.html#method.envs


it'd be nice if this didn't link to nightly but it's not a blocker

alexcrichton · Jul 20, 2017

@bors: r+

bors · Jul 20, 2017

📌 Commit a911c0c has been approved by alexcrichton

bors · Jul 20, 2017

🔒 Merge conflict

steveklabnik · Jul 20, 2017

Github shows no conflict. Dunno whats up.

@bors: retry

maybe?

Mark-Simulacrum · Jul 20, 2017

This needs to be rebased, the conflict is presumably in a submodule.

XAMPPRocky · Jul 20, 2017

Closing in favour of a new PR without submodule problems. #43368

Updated releases notes for 1.19

Loading status checks…

88bacc4

rust-highfive assigned aturon Jun 7, 2017

Update RELEASES.md

Loading status checks…

2e19040

Update RELEASES.md

Loading status checks…

c74b4c3

aidanhs added the S-waiting-on-review label Jun 7, 2017

Create RELEASES.md

Loading status checks…

a8daa00

carols10cents added S-waiting-on-author and removed S-waiting-on-review labels Jun 12, 2017

Update RELEASES.md

Loading status checks…

1b73fd6

Update 1.19 relnotes

Loading status checks…

525bc2e

Aaron Power added some commits Jul 15, 2017

Update RELEASES.md

Loading status checks…

ff23f2d

Removed jobserver note.

Loading status checks…

c0dbb12

Update typo

Loading status checks…

7d70604

Update RELEASES.md

Loading status checks…

a911c0c

XAMPPRocky referenced this pull request Jul 20, 2017
Merged
Update release notes for 1.19.0 #43368

XAMPPRocky closed this Jul 20, 2017

rust-lang/rust

Join GitHub today

Updated releases notes for 1.19 #42503

Conversation

XAMPPRocky commented Jun 7, 2017 • edited by brson

rust-highfive assigned aturon Jun 7, 2017

This comment has been minimized.

rust-highfive commented Jun 7, 2017

This comment has been minimized.

XAMPPRocky commented Jun 7, 2017

jtdowney reviewed Jun 7, 2017 View changes

This comment has been minimized.

Nemo157 reviewed Jun 7, 2017 View changes

This comment has been minimized.

ollie27 suggested changes Jun 7, 2017 View changes

ollie27 left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov reviewed Jun 7, 2017 View changes

This comment has been minimized.

petrochenkov reviewed Jun 7, 2017 View changes

This comment has been minimized.

petrochenkov reviewed Jun 7, 2017 View changes

This comment has been minimized.

petrochenkov reviewed Jun 7, 2017 View changes

This comment has been minimized.

mbrubeck reviewed Jun 7, 2017 View changes

mbrubeck left a comment

This comment has been minimized.

mbrubeck reviewed Jun 7, 2017 View changes

This comment has been minimized.

This comment has been minimized.

mbrubeck Jun 7, 2017 • edited

This comment has been minimized.

cuviper commented Jun 7, 2017

TimNN reviewed Jun 7, 2017 View changes

This comment has been minimized.

TimNN Jun 7, 2017 • edited

This comment has been minimized.

XAMPPRocky commented Jun 7, 2017

aidanhs added the S-waiting-on-review label Jun 7, 2017

This comment has been minimized.

ranma42 commented Jun 8, 2017

This comment has been minimized.

cuviper commented Jun 8, 2017

This comment has been minimized.

brson commented Jun 8, 2017

This comment has been minimized.

brson commented Jun 8, 2017

This comment has been minimized.

brson commented Jun 8, 2017

carols10cents added S-waiting-on-author and removed S-waiting-on-review labels Jun 12, 2017

This comment has been minimized.

alexcrichton commented Jun 15, 2017

This comment has been minimized.

kennytm commented Jun 18, 2017

This comment has been minimized.

brson commented Jul 8, 2017

This comment has been minimized.

brson commented Jul 13, 2017

This comment has been minimized.

brson commented Jul 13, 2017

mbrubeck reviewed Jul 13, 2017 View changes

This comment has been minimized.

mbrubeck reviewed Jul 13, 2017 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

brson commented Jul 13, 2017 • edited

Zoxc reviewed Jul 13, 2017 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

brson commented Jul 13, 2017

This comment has been minimized.

XAMPPRocky commented Jul 13, 2017

jimmycuadra reviewed Jul 14, 2017 View changes

This comment has been minimized.

This comment has been minimized.

XAMPPRocky commented Jun 7, 2017 •

edited by brson

jtdowney reviewed Jun 7, 2017

View changes

Nemo157 reviewed Jun 7, 2017

View changes

ollie27 suggested changes Jun 7, 2017

View changes

petrochenkov reviewed Jun 7, 2017

View changes

petrochenkov reviewed Jun 7, 2017

View changes

petrochenkov reviewed Jun 7, 2017

View changes

petrochenkov reviewed Jun 7, 2017

View changes

mbrubeck reviewed Jun 7, 2017

View changes

mbrubeck reviewed Jun 7, 2017

View changes

mbrubeck Jun 7, 2017 •

edited

TimNN reviewed Jun 7, 2017

View changes

TimNN Jun 7, 2017 •

edited

mbrubeck reviewed Jul 13, 2017

View changes

mbrubeck reviewed Jul 13, 2017

View changes

brson commented Jul 13, 2017 •

edited

Zoxc reviewed Jul 13, 2017

View changes

jimmycuadra reviewed Jul 14, 2017

View changes

sfackler reviewed Jul 19, 2017

View changes

steveklabnik reviewed Jul 19, 2017

View changes