Skip to content

/ rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redox: Use create() instead of open() when setting env variable #42783

Merged
merged 1 commit into from Jun 23, 2017
Merged

Redox: Use create() instead of open() when setting env variable #42783

merged 1 commit into from Jun 23, 2017

Conversation

@ids1024
Copy link
Contributor

@ids1024 ids1024 commented Jun 20, 2017

See redox-os/kernel#25.
@ids1024
Redox: Use create() instead of open() when setting env variable
Verified
This commit was signed with a verified signature.
ids1024 Ian Douglas Scott
GPG key ID: 4924E10E199B5959 Learn about signing commits
Loading status checks…
9f91a4d
@ids1024 ids1024 closed this Jun 20, 2017
@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Jun 20, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.
@ids1024 ids1024 reopened this Jun 20, 2017
@sfackler
Copy link
Member

@sfackler sfackler commented Jun 22, 2017

@bors r+
@bors
Copy link
Contributor

@bors bors commented Jun 22, 2017

📌 Commit 9f91a4d has been approved by sfackler
@bors
Copy link
Contributor

@bors bors commented Jun 22, 2017

⌛ Testing commit 9f91a4d with merge 7ef2b7b...
bors added a commit that referenced this pull request Jun 22, 2017
@bors
Auto merge of #42783 - ids1024:redox-env, r=sfackler
Loading status checks…
7ef2b7b 
Redox: Use create() instead of open() when setting env variable

See redox-os/kernel#25.
@bors
Copy link
Contributor

@bors bors commented Jun 22, 2017

💔 Test failed - status-travis
@Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Jun 22, 2017

Timeout on OS X.

@bors retry
@Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Jun 22, 2017

@bors rollup
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 22, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42783 - ids1024:redox-env, r=sfackler
34d22cb 
Redox: Use create() instead of open() when setting env variable

See redox-os/kernel#25.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 22, 2017
Closed
bors added a commit that referenced this pull request Jun 23, 2017
@bors
Auto merge of #42845 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Loading status checks…
8f1791e 
Rollup of 9 pull requests

- Successful merges: #42724, #42777, #42783, #42787, #42821, #42822, #42825, #42829, #42833
- Failed merges:
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 23, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42783 - ids1024:redox-env, r=sfackler
753da4b 
Redox: Use create() instead of open() when setting env variable

See redox-os/kernel#25.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 23, 2017
Closed
bors added a commit that referenced this pull request Jun 23, 2017
@bors
Auto merge of #42846 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Loading status checks…
7a94eac 
Rollup of 8 pull requests

- Successful merges: #42724, #42783, #42787, #42821, #42822, #42825, #42829, #42833
- Failed merges:
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 23, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42783 - ids1024:redox-env, r=sfackler
d22eb08 
Redox: Use create() instead of open() when setting env variable

See redox-os/kernel#25.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 23, 2017
Merged
bors added a commit that referenced this pull request Jun 23, 2017
@bors
Auto merge of #42856 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Loading status checks…
67dd868 
Rollup of 8 pull requests

- Successful merges: #42777, #42783, #42787, #42821, #42822, #42825, #42829, #42833
- Failed merges:
bors added a commit that referenced this pull request Jun 23, 2017
@bors
Auto merge of #42856 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
Loading status checks…
229d0d3 
Rollup of 8 pull requests

- Successful merges: #42777, #42783, #42787, #42821, #42822, #42825, #42829, #42833
- Failed merges:
@bors bors merged commit 9f91a4d into rust-lang:master Jun 23, 2017
1 of 2 checks passed
1 of 2 checks passed
homu Test failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ids1024 ids1024 deleted the ids1024:redox-env branch Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BurntSushi BurntSushi

Labels
S-waiting-on-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@ids1024 @rust-highfive @sfackler @bors @Mark-Simulacrum @alexcrichton @BurntSushi
You can’t perform that action at this time.