Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[libstd_unicode] Upgrade to Unicode 10.0.0 #42999
Conversation
rust-highfive
assigned
nikomatsakis
Jun 30, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
@jonas-schievink, I ran the script to generate the file. I didn't mention that part because I thought it's obvious. In #42998, I applied the change manually, because running the script also causes these changes. So, we can apply #42998 after this one, hopefully, to avoid breaking any instructions, theoretically. |
This comment has been minimized.
This comment has been minimized.
|
CC'ing from file's blame/history: @petrochenkov, @cuviper, @alexcrichton, @SimonSapin |
This comment has been minimized.
This comment has been minimized.
|
Oh, nevermind then, I thought you'd have to do some changes to the script itself. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, the script always fetches the So, is there any reason to keep it as it is, or can I send a PR? |
This comment has been minimized.
This comment has been minimized.
|
r? @alexcrichton -- I think this falls more into libs |
Mark-Simulacrum
assigned
alexcrichton
and unassigned
nikomatsakis
Jul 2, 2017
Mark-Simulacrum
added
the
S-waiting-on-review
label
Jul 2, 2017
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
alexcrichton
added
the
relnotes
label
Jul 3, 2017
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jul 3, 2017
This comment has been minimized.
This comment has been minimized.
|
|
bors
merged commit a6994d7
into
rust-lang:master
Jul 3, 2017
bors
referenced this pull request
Jul 3, 2017
Merged
[libstd_unicode] Change UNICODE_VERSION to use u32 #42998
behnam
deleted the
behnam:ucd10
branch
Jul 3, 2017
This comment has been minimized.
This comment has been minimized.
H2CO3
commented
Sep 7, 2017
|
Could you please check rust-lang/regex#391 as well. The |
This comment has been minimized.
This comment has been minimized.
|
See rust-lang/regex#400 for Unicode 10.0. |
This comment has been minimized.
This comment has been minimized.
H2CO3
commented
Sep 7, 2017
|
@cuviper Awesome! |
behnam commentedJun 30, 2017
Update
libstd_unicode's data tables to Unicode 10.0.0, as released on 2017 June 20: http://www.unicode.org/versions/Unicode10.0.0/