Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libstd_unicode] Upgrade to Unicode 10.0.0 #42999

Merged
merged 1 commit into from Jul 3, 2017

Conversation

Projects
None yet
9 participants
@behnam
Copy link
Contributor

behnam commented Jun 30, 2017

Update libstd_unicode's data tables to Unicode 10.0.0, as released on 2017 June 20: http://www.unicode.org/versions/Unicode10.0.0/

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jun 30, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jonas-schievink

This comment has been minimized.

Copy link
Member

jonas-schievink commented Jun 30, 2017

// NOTE: The following code was generated by "./unicode.py", do not edit directly
@behnam

This comment has been minimized.

Copy link
Contributor Author

behnam commented Jun 30, 2017

@jonas-schievink, I ran the script to generate the file. I didn't mention that part because I thought it's obvious.

In #42998, I applied the change manually, because running the script also causes these changes. So, we can apply #42998 after this one, hopefully, to avoid breaking any instructions, theoretically.

@behnam

This comment has been minimized.

Copy link
Contributor Author

behnam commented Jun 30, 2017

CC'ing from file's blame/history: @petrochenkov, @cuviper, @alexcrichton, @SimonSapin

@jonas-schievink

This comment has been minimized.

Copy link
Member

jonas-schievink commented Jun 30, 2017

Oh, nevermind then, I thought you'd have to do some changes to the script itself.

@behnam

This comment has been minimized.

Copy link
Contributor Author

behnam commented Jun 30, 2017

Yeah, the script always fetches the latest version and there's no CLI option to change that. I think we should fix that, so we don't have to upgrade if we don't want to. (We don't keep the text data files in the repo.)

So, is there any reason to keep it as it is, or can I send a PR?

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Jul 2, 2017

r? @alexcrichton -- I think this falls more into libs

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jul 3, 2017

@bors: r+

Thanks @behnam!

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 3, 2017

📌 Commit a6994d7 has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 3, 2017

⌛️ Testing commit a6994d7 with merge 734c836...

bors added a commit that referenced this pull request Jul 3, 2017

Auto merge of #42999 - behnam:ucd10, r=alexcrichton
[libstd_unicode] Upgrade to Unicode 10.0.0

Update `libstd_unicode`'s data tables to Unicode 10.0.0, as released on 2017 June 20: http://www.unicode.org/versions/Unicode10.0.0/
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jul 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 734c836 to master...

@bors bors merged commit a6994d7 into rust-lang:master Jul 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@behnam behnam deleted the behnam:ucd10 branch Jul 3, 2017

@H2CO3

This comment has been minimized.

Copy link

H2CO3 commented Sep 7, 2017

Could you please check rust-lang/regex#391 as well. The regex crate would benefit from more recent Unicode compatibility as well.

@cuviper

This comment has been minimized.

Copy link
Member

cuviper commented Sep 7, 2017

See rust-lang/regex#400 for Unicode 10.0.

@H2CO3

This comment has been minimized.

Copy link

H2CO3 commented Sep 7, 2017

@cuviper Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.